mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: 刘永志 <lyz_cs@pku.edu.cn>
To: "greg kh" <gregkh@linuxfoundation.org>
Cc: pawell@cadence.com, peter.chen@nxp.com,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	fuyq@stu.pku.edu.cn
Subject: Re: Re: [PATCH] usb: cdnsp:  Fix potential dereference of NULL pointer
Date: Fri, 20 May 2022 01:10:01 +0800 (GMT+08:00)	[thread overview]
Message-ID: <1f0d2a84.29f34.180dd4c3680.Coremail.lyz_cs@pku.edu.cn> (raw)
In-Reply-To: <YoZpKzT6txHJoAxP@kroah.com>

> -----Original Messages-----
> From: "Greg KH" <gregkh@linuxfoundation.org>
> Sent Time: 2022-05-19 23:58:35 (Thursday)
> To: "Yongzhi Liu" <lyz_cs@pku.edu.cn>
> Cc: pawell@cadence.com, peter.chen@nxp.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, fuyq@stu.pku.edu.cn
> Subject: Re: [PATCH] usb: cdnsp:  Fix potential dereference of NULL pointer
> 
> On Wed, May 18, 2022 at 09:35:43AM -0700, Yongzhi Liu wrote:
> > The return value of cdnsp_get_transfer_ring()
> > needs to be checked to avoid use of NULL pointer
> > in case of an acquisition failure.
> 
> Please use the full 72 columns
> 
> > 
> > Fixes: 3d8290455 ("usb: cdnsp: cdns3 Add main part of Cadence USBSSP DRD Driver")
> > 
> > Signed-off-by: Yongzhi Liu <lyz_cs@pku.edu.cn>
> 
> Please do not put a blank line between "Fixes:" and your signed off by
> line.
> 
> > ---
> >  drivers/usb/cdns3/cdnsp-ring.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/usb/cdns3/cdnsp-ring.c b/drivers/usb/cdns3/cdnsp-ring.c
> > index 1b14384..9f206b9 100644
> > --- a/drivers/usb/cdns3/cdnsp-ring.c
> > +++ b/drivers/usb/cdns3/cdnsp-ring.c
> > @@ -655,6 +655,8 @@ static int cdnsp_cmd_set_deq(struct cdnsp_device *pdev,
> >  	 * to reflect the new position.
> >  	 */
> >  	ep_ring = cdnsp_get_transfer_ring(pdev, pep, deq_state->stream_id);
> > +	if (!ep_ring)
> > +		return -EINVAL;
> 
> How did you test this?
> 
> Don't you need to properly clean up and handle the hardware issues if
> you exit early here?

I find this by a static analyzer based on frequency and similarity, which report many null ptr deref bugs.
In cdns3/cdnsp-ring.c, I find that we usually check the return value when call function 'usb_get_intfdata'.
If 'deq_state->stream_id' is special, the 'ep_ring' is also null. Therefore, i think we should add null checks here.
I will resubmit a new patch if you think the bug is real.
Thanks for your reply and advice.

> 
> Without good testing, I am loath to take this.
> 
> thanks,
> 
> greg k-h

      reply	other threads:[~2022-05-19 17:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-18 16:35 Yongzhi Liu
2022-05-19 15:58 ` Greg KH
2022-05-19 17:10   ` 刘永志 [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f0d2a84.29f34.180dd4c3680.Coremail.lyz_cs@pku.edu.cn \
    --to=lyz_cs@pku.edu.cn \
    --cc=fuyq@stu.pku.edu.cn \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    --cc=peter.chen@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®