From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754055AbeASGPV (ORCPT ); Fri, 19 Jan 2018 01:15:21 -0500 Received: from fllnx209.ext.ti.com ([198.47.19.16]:39905 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750785AbeASGPM (ORCPT ); Fri, 19 Jan 2018 01:15:12 -0500 Subject: Re: [PATCH v5 43/44] ARM: da8xx-dt: switch to device tree clocks To: David Lechner , , , CC: Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , Adam Ford , References: <1515378307-23718-1-git-send-email-david@lechnology.com> <1515378307-23718-4-git-send-email-david@lechnology.com> <8b30f1e6-74dc-3fd6-71a6-c9ceaf77a9d1@ti.com> From: Sekhar Nori Message-ID: <1f0e81de-21c2-8f17-c85d-9e04648939cd@ti.com> Date: Fri, 19 Jan 2018 11:44:03 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 19 January 2018 12:10 AM, David Lechner wrote: > On 01/18/2018 09:27 AM, Sekhar Nori wrote: >> On Monday 08 January 2018 07:55 AM, David Lechner wrote: >>> This removes all of the clock init code from da8xx-dt.c. This includes >>> all of the OF_DEV_AUXDATA that was just used for looking up clocks. >>> >>> Note: You need to have clocks defined in your device tree or your system >>> won't boot after this patch. >> >> I am not sure we can do this then, as we cannot break DT compatibility. >> > > In the past, you have told me that you don't want the .dts changes and code > changes in the same patch. In this case, if you apply either one Thats still true. > separately, > it will break clocks. It does not matter which one is first. > > So either we have to squash [PATCH v5 44/44] ARM: dts: da850: Add clocks > into this patch or deal with the breakage. I am not so much concerned about temporary breakage in the middle of the series, but more about DT compatibility after the entire series is applied. Thanks, Sekhar