From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 133F1481A87 for ; Wed, 21 Jan 2026 13:57:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003831; cv=none; b=X6f5mEGJwL73f1obyHkinU6k+7sTG2E7aJfB4zDXE3MZ16l2lsfXwrQ6PmYiqYUnZ/fjA4/Bby4mwgWqCyVfncnak9FODosTKwmCKsR4qQi4fmzQNP/bK24ZACms6BuZBp3Vun8NuIBQ8cKPyjrowGyzLsCtUHmkgYV4BbpF/CM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769003831; c=relaxed/simple; bh=JdplGQJf+BfrG/OQ6lJ2yz0j9UM5Z34otsbxl3N6ZvA=; h=Message-ID:Subject:From:To:Date:In-Reply-To:References: Content-Type:MIME-Version; b=Qvm92CWfAC9pdMm1cW+gxpjiLWqUyc7u5T422HwrwAKGjYbWhlWXop+yp8JE/xagTopKhDhSfKeTm2QZ8ap8mW7wxwrp2WXtFIhW1Xe/GHXeSC9TPTXANjLk4slQNtAUhrqBfRGoHyzEZSwZS63BqLNuHurzl7wfuHoLg9OarQ8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Xay2r6dV; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=RwEBf9WM; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Xay2r6dV"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="RwEBf9WM" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1769003827; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=JdplGQJf+BfrG/OQ6lJ2yz0j9UM5Z34otsbxl3N6ZvA=; b=Xay2r6dVRcZh8Th7o6XL2jbqMilS1N4vH3VRzXOdYC3xEvldWzdKkkTopbeaG6E7/8xecy epb/B5ExIvBjkmOALs/Cs9tAM9vcFElhZhIGFzDHgXQ3EGBJaVkKQdXegH45UI/VD1F0Ya KVD10ltfAh/Ek0COgsXIOtKMJJlV2M4= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-vSZ0OzQPPnGjoYPWzK74Rw-1; Wed, 21 Jan 2026 08:57:05 -0500 X-MC-Unique: vSZ0OzQPPnGjoYPWzK74Rw-1 X-Mimecast-MFC-AGG-ID: vSZ0OzQPPnGjoYPWzK74Rw_1769003824 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-4804157a3c9so13687095e9.1 for ; Wed, 21 Jan 2026 05:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1769003824; x=1769608624; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id:from:to:cc :subject:date:message-id:reply-to; bh=JdplGQJf+BfrG/OQ6lJ2yz0j9UM5Z34otsbxl3N6ZvA=; b=RwEBf9WMrtNaTufLCbgeMAJX4U7y5CihKtMk4UA3WzkIcvBf0EnJ1hL9kHY8Ug2pJu 3QH3UI3n4+iwuwbDK39L2ubYMDxi+sxPcP44c6o2lzU8xYkI9H8wu0lthQxsaDkUWsdh ITrWEYapu+XSlTD5MG0xdjvXXWwIRKVk6FlnBXMJ3ir69aRiiXZkhb6MfT7ejCowyhmP mLujFnxd7zojOy9fhu35UWussVy1oCPOBlr09WzD4rVmiL6CL4y5Mw0aY1xQYWbgCo8C /ny4uWXDrGCLjlBTROrBtB+rYMG5e9bwMd93QAnOtc0wSaXGf4YKyGa7B3HGmgSCM9X0 dfhA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769003824; x=1769608624; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JdplGQJf+BfrG/OQ6lJ2yz0j9UM5Z34otsbxl3N6ZvA=; b=Yj0Zx3w7Hnto2ISFPH2UkY1p3haGsSPTnKtaNv+HrvredldGweedOvtXWh/pTFlU9D lPUlI9MnAO0Z4Sl4IaG0pEkY72e9rjttIhfwWNl+OMZzZQ2LcfvcK1MKPSbrVU1W3PmD zUVIxSsWTMpztYTLnYQwXB1GSS4sPkBd/ES2a/yu25+1fGAmD4RX2RPalcfsF/nRygUV b2GTvzq/GexslDOUGhDprhBCXh8QTjJR9Os9ji254Yl3hKMDLWgA/5liD6sAGivVevtj T2yzt2bKfSgz0yCVka4P8shsLIZxxv7aRyuLI27ZGT3JVSNrHDNBR9hR/cMjrM8zJf2/ 0Uag== X-Forwarded-Encrypted: i=1; AJvYcCViy5g3Qt3fjPi4wWn3raQvQjELzKT48uV52rtWtV+eIwD74V4L7Qi+6HuM8xVcQzfWIpprx973ziIqMvY=@vger.kernel.org X-Gm-Message-State: AOJu0Yx+Bl9Q7JNY9OQRCKVR3RPBYYqVWdqqMlsicX+UjqyjdzfUufNV Ut2RnOPebOZ6g3+SCgB+oO17/TcF/d5qZjzbGRA8HV4p3uLe69ZZyuC/pnZS1QtQu3BRLF6mnp9 ht5es1I6vsN/dHb8XEuu+2S2fob9vgXF4C/vT7PU1apNnfIsfsZWT9T9stPFTgQGErw== X-Gm-Gg: AZuq6aKk29UDyxY9R3erlQyAi7gaUIepxyU5go4dUNjNm1tnm/GzN1E/qsOe1IeSiMK r3WNGF6D6C5bxOmdGIFMGG4JEGcf28QYkd9ytxa2KmfvWGiGfyECGt4Oyh5l5e9wri9H4IH7Jjk XtCC2gmaP1Fs/KcwDaDG0vOdCW4Ho0ZRtmREmi5/87ujv+ETO8vLOLq8ce9P3Tjz6/b2kVwzdOn 4V5MZaLCX3/v+JEzfuKNX4RRqVkDvMTZ512HWodrP9Q0SguebVzcvDRhMbvLk0hcBa731w/8ynx 4BS+hRxD9N3lMOFIuq8AZTeoAwooIMFiA/bnX5H7TA+Py2snuP4/n9UHw+2rOXrPAoTS0Ej0r94 vdt/xo91BollRJRQkwkNHAkf9aU9cbBXTZWn8jkQypyoxcGPE/C6AySSPpqk8ufU+w+6oongDz7 kFdwJ/RXwc X-Received: by 2002:a05:600c:81c8:b0:47e:e807:a042 with SMTP id 5b1f17b1804b1-4801eac800amr231482515e9.15.1769003824439; Wed, 21 Jan 2026 05:57:04 -0800 (PST) X-Received: by 2002:a05:600c:81c8:b0:47e:e807:a042 with SMTP id 5b1f17b1804b1-4801eac800amr231482265e9.15.1769003824080; Wed, 21 Jan 2026 05:57:04 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47f4b2755absm469405775e9.15.2026.01.21.05.57.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jan 2026 05:57:03 -0800 (PST) Message-ID: <1f168ff5ffb531570fd83e3f398380e8df053275.camel@redhat.com> Subject: Re: [PATCH 18/26] rv/rvgen: add fill_tracepoint_args_skel stub to ltl2k From: Gabriele Monaco To: Wander Lairson Costa , Steven Rostedt , Nam Cao , open list , "open list:RUNTIME VERIFICATION (RV)" Date: Wed, 21 Jan 2026 14:57:02 +0100 In-Reply-To: <20260119205601.105821-19-wander@redhat.com> References: <20260119205601.105821-1-wander@redhat.com> <20260119205601.105821-19-wander@redhat.com> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Mon, 2026-01-19 at 17:45 -0300, Wander Lairson Costa wrote: > The ltl2k class inherits from Monitor which requires subclasses to > implement fill_tracepoint_args_skel(). However, the ltl2k template > uses hardcoded tracepoint arguments rather than the placeholders that > this method would fill. The base class fill_trace_h() method calls > fill_tracepoint_args_skel() unconditionally, which was exposed when > the @not_implemented decorator was introduced. >=20 > Add a stub implementation that returns an empty string. Since the > ltl2k trace.h template does not contain the placeholder strings that > would be replaced, the empty return value has no effect on the > generated output while satisfying the base class interface contract. >=20 > Signed-off-by: Wander Lairson Costa Mmh, this is a bit fishy though. We the patch using the decorator seems fine, but highlights how this method isn't meant to be in Monitor if not all monitors use it.. Adding a stub here is just sweeping dust under the carpet. Here should probably keep the common part of fill_trace_h() in Monitor (e.g= . replacing MODEL_NAME and other common things) and create specific implementations in dot2k and ltl2k for what is not common while calling the super() counterpart for the rest. Does it make sense to you? Thanks, Gabriele > --- > =C2=A0tools/verification/rvgen/rvgen/ltl2k.py | 3 +++ > =C2=A01 file changed, 3 insertions(+) >=20 > diff --git a/tools/verification/rvgen/rvgen/ltl2k.py > b/tools/verification/rvgen/rvgen/ltl2k.py > index 94dc64af1716d..f1eafc16c754b 100644 > --- a/tools/verification/rvgen/rvgen/ltl2k.py > +++ b/tools/verification/rvgen/rvgen/ltl2k.py > @@ -257,6 +257,9 @@ class ltl2k(generator.Monitor): > =C2=A0 > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return '\n'.join(buf) > =C2=A0 > +=C2=A0=C2=A0=C2=A0 def fill_tracepoint_args_skel(self, tp_type) -> str: > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "" > + > =C2=A0=C2=A0=C2=A0=C2=A0 def fill_monitor_class_type(self): > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 return "LTL_MON_EVENTS_I= D" > =C2=A0