mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Miroslav Lichvar <mlichvar@redhat.com>,
	Ingo Molnar <mingo@elte.hu>
Subject: Re: [GIT pull] ntp updates for 2.6.31
Date: Mon, 15 Jun 2009 16:41:43 -0700	[thread overview]
Message-ID: <1f1b08da0906151641u4cd964e6vf1a61afe50cc1d90@mail.gmail.com> (raw)
In-Reply-To: <1f1b08da0906151316s7d25f8ceraa1bc967a8abe172@mail.gmail.com>

On Mon, Jun 15, 2009 at 1:16 PM, john stultz<johnstul@us.ibm.com> wrote:
> On Mon, Jun 15, 2009 at 7:06 AM, Thomas Gleixner<tglx@linutronix.de> wrote:
>> Linus,
>>
>> Please pull the latest timers-for-linus-ntp git tree from:
>>
>>   git://git.kernel.org/pub/scm/linux/kernel/git/tip/linux-2.6-tip.git timers-for-linus-ntp
>>
>> Thanks,
>>
>>        tglx
>>
>> ------------------>
>> John Stultz (2):
>>      ntp: adjust SHIFT_PLL to improve NTP convergence
>>      ntp: fix comment typos
>
> Thomas,
>   Could we hold off on pushing this? I'm still working with Miroslav
> to try to work out a solution here from ntpd user-side.

Linus,
    You probably didn't see this before merging.  Could you yank the
above two patches?  Miroslav (RH package maintainer for ntpd), has
voiced concerns that the SHIFT_PLL patch breaks the NTP design and is
worried it may negatively effect NTP networks of systems running with
different SHIFT_PLL values.

While the patch does greatly improve NTP convergence times, and so far
no negative results have been seen in tests, its out of an abundance
of caution and a desire to keep the adjtimex behavior stable that I
requested Thomas and Ingo to hold off on merging this patch, while I
work with Miroslav to see if we cannot get the same benefit by
adjusting the userspace NTPd.

So if you could revert the two patches until we either sort things out
in userspace or I resubmit, I'd appreciate it.

Sorry for the mixup here.

thanks
-john

  reply	other threads:[~2009-06-15 23:41 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-15 14:06 Thomas Gleixner
2009-06-15 20:16 ` john stultz
2009-06-15 23:41   ` john stultz [this message]
2009-06-16  9:06     ` Ingo Molnar
2009-06-16 11:29       ` Thomas Gleixner
2009-06-16 12:52       ` Miroslav Lichvar
2009-06-17 15:38         ` John Stultz
2009-06-17 16:51           ` Ingo Molnar
2009-06-17 17:23           ` Miroslav Lichvar
2009-06-17 17:26             ` Ingo Molnar
2009-06-17 17:55               ` John Stultz
2009-06-18 12:13               ` Miroslav Lichvar
2009-06-23  9:57                 ` Ingo Molnar
2009-06-23 13:16                   ` Miroslav Lichvar
2009-06-23 13:36                     ` Ingo Molnar
2009-06-23 14:33                       ` Miroslav Lichvar
2009-06-23 19:18                         ` Ingo Molnar
2009-06-23 19:49                           ` Miroslav Lichvar
2009-06-23 21:41                       ` john stultz
2009-06-24  9:29                         ` Alan Cox
2009-06-24 13:39                           ` Martin Schwidefsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f1b08da0906151641u4cd964e6vf1a61afe50cc1d90@mail.gmail.com \
    --to=johnstul@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mlichvar@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®