From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51C11C10F11 for ; Wed, 10 Apr 2019 12:07:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 10D6E20818 for ; Wed, 10 Apr 2019 12:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=themaw.net header.i=@themaw.net header.b="PmHfLUla"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="rEh+n2A7" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731700AbfDJMHV (ORCPT ); Wed, 10 Apr 2019 08:07:21 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59741 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728687AbfDJMHV (ORCPT ); Wed, 10 Apr 2019 08:07:21 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 3CB9321CE2; Wed, 10 Apr 2019 08:07:20 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 10 Apr 2019 08:07:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=themaw.net; h= message-id:subject:from:to:cc:date:in-reply-to:references :content-type:mime-version:content-transfer-encoding; s=fm2; bh= /YKC0FxhMfLTi++7VWFpBU98/DzgwlOa6GPmr8Lp08g=; b=PmHfLUlaZ9Xxofy9 gFpmIXkrVoG9lAmEt4beGcSRv+y3yvJjzkSQ7/aCR2QtoBlqMpcvLfYYSq6vVrhc 93fV0w2B8r5bKHUFXsrwM/ciqA6dad5un+BgAxsLbsWcYRFeQtGhiag4sZsw19UZ WqOJGqtuRcjmXl4/vqNH8z2AihPhPofG/YQjX38nFEGsK6XQNUEnP80Z7gTEy7bl gSDEPWkzb25NMEXFaLpg39LL8CdRH2rAeEkGs8F94dsQWE44RhA4VnsYCeurFW2L 1yg9ohpCDHU1ndxysxpMaKxx6A66r16QqMPGiH6gTYjWhasJSE2SIb27we751gjw RliJPg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=/YKC0FxhMfLTi++7VWFpBU98/DzgwlOa6GPmr8Lp0 8g=; b=rEh+n2A7CSZC61zJ0kAiyW8I0fGuDhbkhpInrAUv+fjSqOvZpaqaxqEJU 2oGLDwYEwRmAUFtjMfRYLaUkC1dfn95ltrKCCUWz0Pdxa6+5g5zKAsDRAOWuZuEv eZf28/4JKEoxYH7IVfY8Cy9k6bOAAyDo5VkJaBHy4jPOiVmvy3ejVuxq+O/m1LLN jM7/2ys7jT86bOvwZg55678/st2guK5+cow4K/c9YLWzFmfJDs4t5S7IXaXf28vn VBakedWTqFn02V3s3/0IvmMaWQsmzw/7PA+duao/ssVy3sMOxO9g1T5bVMhqa79w 1YOez3xhuo5xOiCDgoRTgi8jrYZ7g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrudejgdegkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenog fuuhhsphgvtghtffhomhgrihhnucdlgeelmdenucfjughrpefkuffhvfffjghftgfoggfg sehtjeertdertdejnecuhfhrohhmpefkrghnucfmvghnthcuoehrrghvvghnsehthhgvmh grfidrnhgvtheqnecuffhomhgrihhnpehgohhordhglhdprghpphhsphhothdrtghomhen ucfkphepuddukedrvddtkedrieefrddvfedvnecurfgrrhgrmhepmhgrihhlfhhrohhmpe hrrghvvghnsehthhgvmhgrfidrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from pluto.themaw.net (unknown [118.208.63.232]) by mail.messagingengine.com (Postfix) with ESMTPA id E8C60103AD; Wed, 10 Apr 2019 08:07:18 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by pluto.themaw.net (Postfix) with ESMTP id 6F48B1C0070; Wed, 10 Apr 2019 20:07:15 +0800 (AWST) Message-ID: <1f1d3b95189b6b8acfdf61dd05a804744791d313.camel@themaw.net> Subject: Re: kernel BUG at fs/inode.c:LINE! From: Ian Kent To: Dmitry Vyukov Cc: Al Viro , syzbot , Andrew Morton , Amir Goldstein , linux-fsdevel , LKML , Tetsuo Handa , syzkaller-bugs Date: Wed, 10 Apr 2019 20:07:15 +0800 In-Reply-To: <5c581e6eadc946b965e3138c9daffda75b1fba56.camel@themaw.net> References: <00000000000051e9c2057d31a563@google.com> <00000000000036a4a9058619dff3@google.com> <20190410002603.GS2217@ZenIV.linux.org.uk> <5c581e6eadc946b965e3138c9daffda75b1fba56.camel@themaw.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-2.fc28) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2019-04-10 at 19:57 +0800, Ian Kent wrote: > On Wed, 2019-04-10 at 13:40 +0200, Dmitry Vyukov wrote: > > On Wed, Apr 10, 2019 at 12:35 PM Ian Kent wrote: > > > > > > On Wed, 2019-04-10 at 10:27 +0200, Dmitry Vyukov wrote: > > > > On Wed, Apr 10, 2019 at 2:26 AM Al Viro wrote: > > > > > > > > > > On Tue, Apr 09, 2019 at 07:36:00AM -0700, syzbot wrote: > > > > > > Bisection is inconclusive: the first bad commit could be any of: > > > > > > > > > > [snip the useless pile] > > > > > > > > > > > bisection log: > > > > > > https://syzkaller.appspot.com/x/bisect.txt?x=15e1fc2b200000 > > > > > > start commit: [unknown > > > > > > git tree: linux-next > > > > > > dashboard link: > > > > > > https://syzkaller.appspot.com/bug?extid=5399ed0832693e29f392 > > > > > > syz repro: > > > > > > https://syzkaller.appspot.com/x/repro.syz?x=101032b3400000 > > > > > > C reproducer: > > > > > > https://syzkaller.appspot.com/x/repro.c?x=16534063400000 > > > > > > > > > > > > For information about bisection process see: > > > > > > https://goo.gl/tpsmEJ#bisection > > > > > > > > > > If I'm not misreading the "crash report" there, it has injected an > > > > > allocation > > > > > failure in dentry allocation in d_make_root() from autofs_fill_super() > > > > > ( > > > > > root_inode = autofs_get_inode(s, S_IFDIR | 0755); > > > > > root = d_make_root(root_inode); > > > > > ) which has triggered iput() on the inode passed to d_make_root() (as > > > > > it > > > > > ought > > > > > to). At which point it stepped into some BUG_ON() in fs/inode.c, but > > > > > I've > > > > > no idea which one it is - line numbers do not match anything in linux- > > > > > next > > > > > or in mainline. Reported line 1566 is > > > > > if (inode->i_nlink && (inode->i_state & I_DIRTY_TIME)) > > > > > { > > > > > in all of them; as the matter of fact, the diff in fs/inode.c between > > > > > -next and mainline is empty. > > > > > > > > > > There is a BUG_ON() several lines prior, and in 4.20 it used to be > > > > > line > > > > > 1566, > > > > > so _probably_ that's what it is. With that assumption, it's > > > > > BUG_ON(inode->i_state & I_CLEAR); > > > > > IOW, we'd got I_CLEAR in the inode passed to d_make_root() > > > > > there. Which > > > > > should not happen - the inode must have come from new_inode(), which > > > > > gets it from new_inode_pseudo(), which zeroes ->i_state. And I_CLEAR > > > > > is set only in clear_inode(). For autofs inodes that can come only > > > > > from autofs_evict_inode(), called as ->evict() from evict_inode(). > > > > > Which should never ever be called for inode with positive ->i_count... > > > > > > > > > > It might be memory corruption; it might be a dangling inode pointer > > > > > somewhere, it might be something else. > > > > > > > > > > To get any further we really need a confirmation of the identity of > > > > > triggered BUG_ON(). > > > > > > > > > > As an aside, your "sample crash reports" would've been much more > > > > > useful > > > > > if > > > > > they went with commit SHA1 in question, especially when they contain > > > > > line > > > > > numbers. > > > > > > > > Hi Al, > > > > > > > > This is the commit for matching lines: > > > > > > > > > HEAD commit: d14b746c6c1c Add linux-next specific files for > > > > > 20181214 > > > > > > Are you sure? > > > what does 20181214 mean? > > > > Yes, I just copy-pasted from the report. "d14b746c6c1c" is the commit > > hash. "Add linux-next specific files for 20181214" is the commit > > subject. > > > > > > > Looking at current next code (and several branches) it doesn't > > > appear the problem is possible? > > > > > > > > git tree: linux-next > > > > > > But which branch is it really, master (which doesn't match the > > > line numbers btw)? > > > > This is d14b746c6c1c commit hash. I don't know if there is a branch > > with HEAD pointing to this commit or not, but it seems unimportant. > > Tree+commit is the identity of code state. > > > > > > > > fs/inode.c:1566 points to: > > > > > > > > void iput(struct inode *inode) > > > > { > > > > ... > > > > BUG_ON(inode->i_state & I_CLEAR); > > > > > > > > > > > > The dashboard page provides kernel git repository and commit for each > > > > crash. > > > > > > Those links don't seem to make sense to me ... > > > > > > Help me out here! > > > > There is git repo name provided and commit hash. It's meant to be > > self-explanatory. What exactly is unclear? > > I'm unable to find a branch matching the line numbers. > > Given that, on the face of it, the scenario is impossible I'm > seeking clarification on what linux-next to look at for the > sake of accuracy. > > So I'm wondering if this testing done using the master branch > or one of the daily branches one would use to check for conflicts > before posting? Sorry those are tags not branches. On a newly updated linux-next I get: [raven@pluto linux-next.git]$ git show d14b746c6c1c fatal: ambiguous argument 'd14b746c6c1c': unknown revision or path not in the working tree. Use '--' to separate paths from revisions, like this: 'git [...] -- [...]' So I guess I'm confused ... Are you sure some thing's not amiss somewhere here? > > Or perhaps the master branch has been updated and the testing was > done on something different. > > Ian