From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8FA19C31E46 for ; Wed, 12 Jun 2019 12:36:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 62DC7208C2 for ; Wed, 12 Jun 2019 12:36:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="XCK8nLrx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2408255AbfFLMgy (ORCPT ); Wed, 12 Jun 2019 08:36:54 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:17513 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405938AbfFLMgy (ORCPT ); Wed, 12 Jun 2019 08:36:54 -0400 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 12 Jun 2019 05:36:53 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Wed, 12 Jun 2019 05:36:52 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Wed, 12 Jun 2019 05:36:52 -0700 Received: from [10.21.132.143] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 12 Jun 2019 12:36:49 +0000 Subject: Re: [PATCH v2 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes To: Sameer Pujar , , , CC: , , , References: <1560243406-2535-1-git-send-email-spujar@nvidia.com> From: Jon Hunter Message-ID: <1f2020ae-12f3-2ad1-c844-b4b7885d41f9@nvidia.com> Date: Wed, 12 Jun 2019 13:36:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <1560243406-2535-1-git-send-email-spujar@nvidia.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1560343013; bh=l/KPUA8SA1zZ0jib8qJ2prVlUEp09ihngQ3+RWqn+j0=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=XCK8nLrxKZJM0vFDsRjUUSHFB2qrYL58qNKiKWkXI0dApwyz88s4wcB6ZQ9a+tXIG wbO9BN/RHYDqYCJhT184/D4UiKy7Lod5dHbuG4zWVkvOleH3E21BLN+QllMyVn1ZiS 3/UwiCssSnEhbJivKwaZD3bD+0g1XPVYBUI8PlD24fA53LfyR3g3FfYjpT4PjwEgew bVwK0X1AHHj4zLpZZsqoYKy0QWw0G4w1KaETAA6RbxcfvuQsB/F8JgY0kuylK3eRZb ZqYppAvHFWVucKaduEXk0UxI0aw1p3uJhpvXV5st8wH8cY+YRwizCDs/ViuwpojsvY tCakX2O0Koj4g== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2019 09:56, Sameer Pujar wrote: > Add DT nodes for following devices on Tegra186 and Tegra194 > * ACONNECT > * ADMA > * AGIC > > Signed-off-by: Sameer Pujar > --- > arch/arm64/boot/dts/nvidia/tegra186.dtsi | 68 ++++++++++++++++++++++++++++++++ > arch/arm64/boot/dts/nvidia/tegra194.dtsi | 68 ++++++++++++++++++++++++++++++++ > 2 files changed, 136 insertions(+) > > diff --git a/arch/arm64/boot/dts/nvidia/tegra186.dtsi b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > index 426ac0b..ccd902b 100644 > --- a/arch/arm64/boot/dts/nvidia/tegra186.dtsi > +++ b/arch/arm64/boot/dts/nvidia/tegra186.dtsi > @@ -1295,4 +1295,72 @@ > (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>; > interrupt-parent = <&gic>; > }; > + > + aconnect@2a41000 { > + compatible = "nvidia,tegra210-aconnect"; > + clocks = <&bpmp TEGRA186_CLK_APE>, > + <&bpmp TEGRA186_CLK_APB2APE>; > + clock-names = "ape", "apb2ape"; > + power-domains = <&bpmp TEGRA186_POWER_DOMAIN_AUD>; > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x02930000 0x0 0x02930000 0x50000 > + 0x02a41000 0x0 0x02a41000 0x3000>; We only need one address range here that covers the entire APE. > + status = "disabled"; > + > + dma-controller@2930000 { > + compatible = "nvidia,tegra186-adma"; > + reg = <0x02930000 0x50000>; > + interrupt-parent = <&agic>; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + #dma-cells = <1>; > + clocks = <&bpmp TEGRA186_CLK_AHUB>; > + clock-names = "d_audio"; > + status = "disabled"; > + }; > + > + agic: agic@2a41000 { > + compatible = "nvidia,tegra210-agic"; > + #interrupt-cells = <3>; > + interrupt-controller; > + reg = <0x02a41000 0x1000>, > + <0x02a41000 0x2000>; These addresses should not overlap. Cheers Jon -- nvpublic