From: Zhou Yanjie <zhouyanjie@wanyeetech.com>
To: Paul Cercueil <paul@crapouillou.net>,
Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-mips@vger.kernel.org,
GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
paul@boddie.org.uk, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, sernia.zhou@foxmail.com
Subject: Re: [PATCH 1/3] pinctrl: Ingenic: Fix bug and reformat the code.
Date: Wed, 10 Mar 2021 22:28:01 +0800 [thread overview]
Message-ID: <1f213c50-cc8b-b290-aa71-e5d4be47f1fe@wanyeetech.com> (raw)
In-Reply-To: <XRBRPQ.2KHLLNUGZDFB1@crapouillou.net>
Hi Paul,
On 2021/3/10 下午10:19, Paul Cercueil wrote:
>
>
> Le mer. 10 mars 2021 à 16:03, Andy Shevchenko
> <andy.shevchenko@gmail.com> a écrit :
>> On Tue, Mar 9, 2021 at 6:42 PM 周琰杰 (Zhou Yanjie)
>> <zhouyanjie@wanyeetech.com> wrote:
>>>
>>> 1.Add tabs before values to align the code in the macro definition
>>> section.
>>> 2.Fix bugs related to the MAC of JZ4770, add missing pins to the
>>> MII group.
>>> 3.Adjust the sequence of X1830's SSI related codes to make it
>>> consistent
>>> with other Ingenic SoCs.
>>> 4.Fix bug in "ingenic_pinconf_get()", so that it can read the
>>> configuration
>>> of X1830 SoC correctly.
>>>
>>
>> Split to 4 patches then.
>> It's quite hard for everybody to handle regression fixes like this.
>
> Agreed. And the fixes should have a Fixes: tag.
>
Sure.
> -Paul
>
next prev parent reply other threads:[~2021-03-10 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 16:40 [PATCH 0/3] Fix bugs and add support for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-03-09 16:40 ` [PATCH 1/3] pinctrl: Ingenic: Fix bug and reformat the code 周琰杰 (Zhou Yanjie)
2021-03-10 14:03 ` Andy Shevchenko
2021-03-10 14:19 ` Paul Cercueil
2021-03-10 14:28 ` Zhou Yanjie [this message]
2021-03-10 14:27 ` Zhou Yanjie
2021-03-09 16:40 ` [PATCH 2/3] dt-bindings: pinctrl: Add bindings for new Ingenic SoCs 周琰杰 (Zhou Yanjie)
2021-03-09 16:40 ` [PATCH 3/3] pinctrl: Ingenic: Add support " 周琰杰 (Zhou Yanjie)
2021-03-10 8:23 ` [kbuild] " Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f213c50-cc8b-b290-aa71-e5d4be47f1fe@wanyeetech.com \
--to=zhouyanjie@wanyeetech.com \
--cc=andy.shevchenko@gmail.com \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=hns@goldelico.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paul@boddie.org.uk \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®