From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Pengpeng Hou <pengpeng@iscas.ac.cn>,
kashyap.desai@broadcom.com, sumit.saxena@broadcom.com,
shivasharan.srikanteshwara@broadcom.com,
chandrakanth.patil@broadcom.com, martin.petersen@oracle.com
Cc: megaraidlinux.pdl@broadcom.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: megaraid_sas: validate dynamic RAID map descriptor element counts
Date: Tue, 24 Mar 2026 09:50:19 -0400 [thread overview]
Message-ID: <1f224ade5e006b0e94ac8c46549e3b52cf330dc2.camel@HansenPartnership.com> (raw)
In-Reply-To: <20260324085201.75176-1-pengpeng@iscas.ac.cn>
On Tue, 2026-03-24 at 16:52 +0800, Pengpeng Hou wrote:
> MR_PopulateDrvRaidMap() uses raid_map_desc_elements from the
> firmware's dynamic RAID map to drive memcpy() sizes and array-copy
> loops into the driver-owned devHndlInfo[], ldTgtIdToLd[], arMapInfo[]
> and ldSpanMap[] buffers. Those destinations are fixed-size arrays,
> but the descriptor element counts are currently trusted without
> checking that they fit the corresponding driver map arrays.
The values for the array sizes come from the driver headers, which are
supposed to be in sync with the firmware. They're also pretty huge
(mostly 512) so what makes you think there's an actual problem here?
> Reject dynamic RAID map descriptors whose element counts exceed the
> destination array capacities before copying them into the driver map.
Even assuming there was some way the firmware and the driver could get
out of sync over the maximum, wouldn't the best thing we could do be to
warn and truncate?
Regards,
James
prev parent reply other threads:[~2026-03-24 13:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-24 8:52 Pengpeng Hou
2026-03-24 13:50 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f224ade5e006b0e94ac8c46549e3b52cf330dc2.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=chandrakanth.patil@broadcom.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=pengpeng@iscas.ac.cn \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®