From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20A0239E17E for ; Thu, 15 Jan 2026 13:59:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485592; cv=none; b=M7H1JmvFpTePjUK/Y9IVm0sdFYoNZqob160yQc7RLgXHlWnzyreS3mh4AElqYCFeGi1iTvOZoJSwqsorrvOyCpcGtqHOWm7K730OnBQozuXsiP+yIhsdhPC/Xx8byhNQyyxLg+TSiyv3o/JOFPQ0Mg1quGQAjV8CcBwMO1QEj20= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768485592; c=relaxed/simple; bh=fUlaZgpdBz4lX7Y6bddTVT/L42Pwda9ID64q5rmBzd8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=C+9HwXEjmmLdTaxvd6R3Tqg2N84412OJX28DotN+RNKk4mJJsrgSe/hY936qy+0KkZULJzbJZw8E9zlHMPt/rQNnbqFTgrz9h8WuQUoIHmAX5lCak47QjIDuilT+AugCcGljPqrfgSsHMgUgkhcEoOkfVSF3VElViuI0K6mRZ68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net; spf=pass smtp.mailfrom=pardini.net; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b=PMLAk9lr; arc=none smtp.client-ip=209.85.208.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pardini.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pardini.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=pardini.net header.i=@pardini.net header.b="PMLAk9lr" Received: by mail-ed1-f53.google.com with SMTP id 4fb4d7f45d1cf-6505d141d02so1521580a12.3 for ; Thu, 15 Jan 2026 05:59:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pardini.net; s=google; t=1768485589; x=1769090389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SYIhPG6x60jF1PxiSFq6Xnv+Wsxju3BBfQyn7pIJfb8=; b=PMLAk9lrMiN0AqySbt/M4ViEjCJZjcZv9s3l/2Ktq/1THsQ1dixd6xvHBNtW+gEjsn fvn8N4v58rCKg16jhccuSU2Vqmzb+iAB36bU9Ii5RydRcTxf99RGzHc9YrelcDJihuwA PeIMzOduU3yIvsmFqIDYHYu+O6cRMRoqjl44AF8rOIBQo/Lq6IyREAlUnekgxpWI2sDT L4B8u5dduuUD0jlexf83H4tyPoZNWgKuOoP9trpZO5tTd52Zp4yOy0w/77e9crqHZTS/ GLGoaPP41vF4/9VakPN1UijcSJnYGbCXNMry2YqfGZcUDrNhpyWihOQS8U2AlzhSoebF mImw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768485589; x=1769090389; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SYIhPG6x60jF1PxiSFq6Xnv+Wsxju3BBfQyn7pIJfb8=; b=p22NUoRNSndEObUjpaMK7e1eZAgSUW5iqfSoeH2lkJaT4p8OS/NGpbI2z7anFwpKve oit09+hl8eUHMwGXvr9uwZyBCL22d2ZiJl1FH0SNAoDy7GBBBxDv7rZhpRU1GEYrnJoh p2ZsGagyIcN92/567PMjN6AroVQmYwDkrbraF4voc6qd5mUf0ZfIxYsj9tfvNzhTTKMt bdh8YA3FEE9UOg5IihZgJ19jX7scCpK8HG//j2A1XBcZbFtkRNUaAimlcMeYOouAJdpT TYUarc2IGqBg9HahLCL2oV6qwwVrbIyFwkKTE2BezJKmXSp846xr5OgkRwybOZdXpWM3 bFzQ== X-Forwarded-Encrypted: i=1; AJvYcCWWSyjHoEXykRA3PiP951kLE6uyBwjhsi/njrGkVRP0hiTXebXajVfMZs4btovXm1XJKkOKMWsthaYSFok=@vger.kernel.org X-Gm-Message-State: AOJu0Yxlzy4rZ/pVO/TgbRHUvxziXf6C7DZiMM39QjNXvnw4WvIR9xRs M1QMJQMiBZFWg346Gf6SaaA2MWAev4qwA0XMPqfgsxIuSA1oZxUSR83mmPPZmqV7Yg== X-Gm-Gg: AY/fxX7m5KFqEXJl/WwZg1nl39k2TYtyULNLROrGkyWwsY6/CgbMbdUL+eUVKIV1igs 5HPm2jAoQdEflu1t9RTXm5h5wfFG+dTF/80y5//9c0svwnZhWP4vwRgUer6sWfthstH/S9W2gBY WqEVshTRWYaLIl57j0Cetw7m205G5PZ3zH+1cYNiKQBLt++2t+B4PIsAxL24ToebD+TSyFboTnY dCu69yxtBdP79NEr50EsooTttspszJcT198uEb/ivO/kjlgneR84qk+aykdWsy7+/DIaJfGt5AJ 4XTrD0v5HmFaweDDUzUHU34gH0qxpMICfgLptSxymNCfNEWV1DXUHO3XqOVH9xLTD952PXiIJW7 yUoOVcHtAwi8YrMp6zAZNQSVvGFZgAtEk8O7kcJsYAIpP+cE4G/UA67lrmTTT1xRhBGt8Q+TU9a Y5K1hR/2EtXcPS/UfUWGkCaA+cxdLDYajjhyXZg12O92z8If7yQy6jIY1Pi0qcqgRBcVsXQ0a8O xevdHSwWcKxlzrmiNlppG2y8yG9cYV4KyoxAfB04Owy+zwTWwxOOQIJKw== X-Received: by 2002:a17:907:3f21:b0:b73:8b79:a31a with SMTP id a640c23a62f3a-b8761059dc7mr555045166b.16.1768485589247; Thu, 15 Jan 2026 05:59:49 -0800 (PST) Received: from ?IPV6:2a02:a466:4d7a:0:ed4f:c8ed:4383:1c08? (2a02-a466-4d7a-0-ed4f-c8ed-4383-1c08.fixed6.kpn.net. [2a02:a466:4d7a:0:ed4f:c8ed:4383:1c08]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b86f0d6d7c6sm1614104466b.42.2026.01.15.05.59.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 05:59:48 -0800 (PST) Message-ID: <1f256bf2-2739-4785-88fd-25101df9dad9@pardini.net> Date: Thu, 15 Jan 2026 14:59:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] arm64: dts: amlogic: add the type-c controller on Radxa Zero 2 To: Neil Armstrong , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260114-arm64-dts-amlogic-radxa-zero2-additions-v1-0-8b5cdf328fde@pardini.net> <20260114-arm64-dts-amlogic-radxa-zero2-additions-v1-2-8b5cdf328fde@pardini.net> Content-Language: en-US From: Ricardo Pardini In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Neil, On 15/01/2026 14:00, Neil Armstrong wrote: >> The Radxa Zero2 has an FUSB302 controller on i2c3 at address 0x22 and >> INT# wired to GPIOA-13. >> >> +        interrupts = <13 IRQ_TYPE_LEVEL_LOW>; > > OK it seems I did read too fast, this should be 74 ! > > S922X Datasheet (same as A311D for this) > > Table 6-32 GPIO Interrupt Sources > > --------------------------------------------- > | Input Mux Location    |    Description | > --------------------------------------------- > | [76:61]        |    gpioA[15:0] | > --------------------------------------------- > > So gpioA13 ==> 74 Indeed. Sorry for this. >> + >> +        vbus-supply = <&ao_5v>; >> + >> +        status = "okay"; > > And I get: > >   DTC [C] arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dtb > arch/arm64/boot/dts/amlogic/meson-g12b-radxa-zero2.dtb: fusb302@22 > (fcs,fusb302): 'connector' is a required property >         from schema $id: http://devicetree.org/schemas/usb/ > fcs,fusb302.yaml# > > Please add a minimal connector, like: > > +               connector { > +                       compatible = "usb-c-connector"; > +                       label = "USB-C"; > +                       data-role = "host"; > +                       power-role = "source"; > +                       source-pdos = PDO_FIXED_USB_COMM)>; > +               }; > > I'll drop this change from my tree. Again, my bad. My intention here was a "minimal" description, mostly to reserve 0x22 so end-users can run `i2cdetect` or such on the 40-pin exposed i2c3 and not be surprised. Guess I didn't run dtbs_check hard enough and missed the required connector. > > And you may also add support for the superspeed mux to switch the USB3 > polarity. > > I have a prototype at https://gitlab.com/superna9999/linux/-/tree/topic/ > amlogic/radxa-zero2/fusb302?ref_type=heads I'll try your prototype. I had no idea it actually had those capabilities. Do you think it is worth to resend this with just the fixed 74 pin & the minimal connector as you suggested? Now that I've seen your work, a "add FUSB302" that does nothing (while being capable) feels frivolous and confusing. Thanks, Ricardo