From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B72D4189A0 for ; Tue, 7 Jul 2026 13:28:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783430906; cv=none; b=O2SqdfPZknPz72iRtThhA8Dg+cbO2EX0t3lr+TWt/S8jobvir977P+tIie4ETecTIfKfZ8SPbfCA/9aFKTdkBDBryWax6KY+oCyzI1yKpczLE/YCwN+CWGzvM3vRSdBW1bJgG1RPhUZp4WYfQ/WcFI8884SXk0m9e8/ZLRLNgUE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783430906; c=relaxed/simple; bh=nuLeoUEvOpXq9AkGBJOxyT85nniQu7opj6lTMbg2iLs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HDmjlR+4F7LDfeMSa2BFZXOdQLylzckmd1sQtcNz8hl8uJ1oKPX8JIqv2uERMKm+2/pxpYh9/G10HBGyF+SnJ8Hd+IRwa8Qgz3IrI6k57c2x62wwOzc636NslPeEsxiHubWARHnUStkn495pnsTdqsaKU85rIMx3FWZWQUTN57Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NWuVIwir; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ap3G1o2z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NWuVIwir"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ap3G1o2z" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 667C8bK83755342 for ; Tue, 7 Jul 2026 13:28:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 3+BWYw27ihfmCLaAceDPp5weMHgOmeY7qTCbRdEdx+o=; b=NWuVIwirqTZmHAMA 2nzlt/+8dYkyruTu4xT2JDM9ZJYh2QtSz837mrOje0yYqeSby9B3Vx83PpTA2fYO V82Dk/A111COS09W1pr9G/vUnn/CClXsvcF90V8ik3MESbxd4Wa1te7vLKPv2F5f SozhbPVZIwvz4h8FdSQ/GAtZqdqjggXo5TUuAMBHkUiZ+oVJ2ZERG8R3kCnTC2Il Ky3F9N2MEMQ9/qrzTRmPPvf3h1TsjJbQJ0xY3/Zk7gnU2kd7hl3oBFbTlvo1rirN eM3grW0Glae5H4Xm/mKhTkgUdd2OG/+Shtgt7FdW/RPscPJ8zn9J4xr+kIPcZ/Ft LB6mtA== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f8wep1ar1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Jul 2026 13:28:24 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-8478ff5d801so7910561b3a.2 for ; Tue, 07 Jul 2026 06:28:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783430904; x=1784035704; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=3+BWYw27ihfmCLaAceDPp5weMHgOmeY7qTCbRdEdx+o=; b=ap3G1o2ziE0vTEBZes9PNqXrCMvicB38n3Oz8r6kOfI4IDVW4vfvPAHNmKx6+mSCKV PHrGvRIqGSX6oIOGyuL9no67B7GkQxc1PPfErbklx29ON8S7abWWTYphVHpDNbcjaUNr HFBPxgRJ9A825Y7BnRtPaaUIdDXTWWW+j9XHxRrwezSaC0imsAqM4KqmfF6X5sZAKPto PX4Mcdwfni2QCorQLGiygoUm5QC/GuYdkDIYIAZpdyW3iB9HXjdp5ap8YI34ROCMI/1e ia9NcQ5odKqkASwQwVAI86rwCCqd3n4K1jiSooiWTf0J34uK0a1NRTTBhTAxwG/aDbLW eGpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783430904; x=1784035704; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3+BWYw27ihfmCLaAceDPp5weMHgOmeY7qTCbRdEdx+o=; b=jAZfNVEkDL41IAbxo7P85TYoVxDIT6fRi9OPnXJKvZy2QZCJDjDCLAl4jFLHQ5We+/ xo7oVvO1kIlhZRdoi+jsAvAwcVYobu+e/+gb8AnKYaXexKcGuStxe73mZlQPqrRnsPlt sU9+jg1yEkpl5ebxBltIkByS2XkOPKaMyPT3f+cOoVkzwEw5ikLcw/hIOF1xAjTyOxRM Ba86RHN7xaBAlKtReoacVgjhxlz1SCfm4eylSgMXxnM2pBdZVlb3P2hekas9qZAephk6 f9ohvnTyrbXlQmI0fg5Tup0o7ZIM/S5HxCtUQp6tAAPO+F4poKJu9VuObgQaHca/qohr 0HlA== X-Forwarded-Encrypted: i=1; AHgh+RrfhVBn7JS1RJXV1ydtztTWFrcfywock2DU6OJeHfLdPQXOIRL2PUHFo/enre/bmndrJgdCMf6MbQ7CT6E=@vger.kernel.org X-Gm-Message-State: AOJu0Yw59lOIGKMpkRjNbMNQN0kAVIKb+D5WmJKdyg0kEeSWDpLD233h Cz9zYPDEY2MCslhwxXbZff1UvP32D9KVPtNUa7ht9V/pvYntHjTRlvEwNc8LoEHn97t41eitVHd an3R9HAG1bfvN1CYclCSE/x4IyrtPAgjuaFdYwKR3Krw1JoCsQV9XEvjhP9ybP5AkOh0= X-Gm-Gg: AfdE7cke15q1dfLa3HUmNnMkP84NrktbKsEX+rIPlybVDDRRpRzbum6umU6KbWY9rdc geAoMkOb755JYpBPpNgZLSnDrV2YEbag5V1vLOya4WLO+BqavdmdmEZyWN7r2wfjz7mwocFd2oM 9MjTVMBLntJwm5y9IAoSPqQhdpfFulruFkreqjezBQe3S6U9VaIFXNCmWm3vVQrQHEGg3bz6FtC coH/rpKk9BWRxL5PlRyZrwwzzEe92JpPHDq7dv+coH2sLBYX+aU6hT8aFAtUbfFwgttsWihu4UD eL+o61JBpa/ujcFPxm2R7BKOWsBAUss/6j0iAWqsonpeU+nOijTxMO2WOTNi8/EGAYW3r6jEPlj ZUcYs/YMHiDz+y6PNV181m3Q81piOFFnViryfa4xg8emz X-Received: by 2002:a05:6a20:cfa8:b0:3c0:9c1a:8936 with SMTP id adf61e73a8af0-3c09c1a9bebmr3947198637.62.1783430903567; Tue, 07 Jul 2026 06:28:23 -0700 (PDT) X-Received: by 2002:a05:6a20:cfa8:b0:3c0:9c1a:8936 with SMTP id adf61e73a8af0-3c09c1a9bebmr3947139637.62.1783430902989; Tue, 07 Jul 2026 06:28:22 -0700 (PDT) Received: from [10.204.101.214] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b659fa13bsm8137106c88.15.2026.07.07.06.28.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2026 06:28:22 -0700 (PDT) Message-ID: <1f258146-4ef4-4442-85e3-84af7ad735b5@oss.qualcomm.com> Date: Tue, 7 Jul 2026 18:58:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 11/16] media: iris: update buffer requirements based on received info To: Dmitry Baryshkov Cc: Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Vishnu Reddy , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Dikshita Agarwal References: <20260616-iris-ar50lt-v5-0-583b42770b6a@oss.qualcomm.com> <20260616-iris-ar50lt-v5-11-583b42770b6a@oss.qualcomm.com> <6f7622c5-2bfe-49f1-ac05-81e33c8bd66a@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: oqMv65JAbwwRJA0vvG5T3vz9WhIeOk7V X-Proofpoint-ORIG-GUID: oqMv65JAbwwRJA0vvG5T3vz9WhIeOk7V X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfXxBgxrWx3Ws1I zh9A55G2x+oHtO/vEGw98jR5qcv/HnJUVzmAl5r/pgszHcZUAN3Au8AH/AfWWVr8KSCCSPUwX0A MjjIFfAm+BiXFdEDnkJQgmsCX630eh77O2LtnACce9MA/QflezPC6+rratVR/ceETbVTjK8txH4 FVyKxXh0ow+s9vJf9g9BNQhbo6fmWudIHaA8xxY77wXRbPthFxUtQblXnsH9S8Q5WRUCzggAcDE Q9iskioNpCEScoqeI1dObXODBFdHgWFyVqkBljluDfbCfZW1lcVhs997O/p8pn8J6vcm5MqvTaP 2kyA0vgt4z9kj70RgkJEN+IkY46NB5KLa9jCpFH1mHwWd4LRzdQdLYyAYUlqRlJw0VvEU4LJT2t eTOCUcA+H5Hp/czmwAPYXROUs4BVmmxLphY6w3D7A4fhtIuUUtCo76PDsaWeJzkoEbCZPEbnWHV zECC6MGgBGLTFPVMSRw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNzA3MDEzMiBTYWx0ZWRfXwtDS2qh5opc5 WhmE2B35CE6ayzXKOeSDV5csgUeHi8VWCeobJ7sN5EGWUwGtLgZLoxw+WY/SEpY4qjnRviAw4AX KfEZCaB9mwJO2QiPYvjPCdJxZSOt6GA= X-Authority-Analysis: v=2.4 cv=atSCzyZV c=1 sm=1 tr=0 ts=6a4cfef8 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=--w9Y1qBsydm4NR-mTQA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-07_03,2026-07-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607070132 On 7/1/2026 6:55 PM, Dmitry Baryshkov wrote: > On Wed, Jun 24, 2026 at 01:37:12PM +0530, Vikash Garodia wrote: >> >> On 6/16/2026 5:34 AM, Dmitry Baryshkov wrote: >>> Upon receiving data for HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS the >>> driver should update buffer sizes and counts from the received data. >>> Implement corresponding functionality updating buffers data. This will >>> be used for upcoming support of AR50Lt platforms with Gen1 firmware. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> .../platform/qcom/iris/iris_hfi_gen1_response.c | 75 +++++++++++++++++++++- >>> 1 file changed, 74 insertions(+), 1 deletion(-) > >>> +static void iris_hfi_gen1_session_property_info(struct iris_inst *inst, void *packet) >>> +{ >>> + struct hfi_msg_session_property_info_pkt *pkt = packet; >>> + >>> + if (!pkt->num_properties) { >>> + dev_err(inst->core->dev, "error, no properties\n"); >>> + goto out; >>> + } >>> + >>> + switch (pkt->property) { >>> + case HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS: >> >> If i check the venus message parsing logic, it loops through the packet till >> it hits the case. > > It doesn't, see hfi_session_prop_info() > I see the loop happens a layer before during msg processing in iris_hfi_gen1_response_handler(). It calls for iris_hfi_gen1_session_property_info() for every packet of session property type, i was wrong in assuming that one property packet would have multiple property types in it. Logic is fine. >> Here, we are assuming the first packet type, in the pkt to >> be the property "HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS". There can be >> multiple properties in the packet, and if >> "HFI_PROPERTY_CONFIG_BUFFER_REQUIREMENTS" is not the first one, the usecase >> would break with incorrect buffer sizes. >> >>> + iris_hfi_gen1_session_buffer_requirements(inst, pkt->data, >>> + pkt->shdr.hdr.size - sizeof(*pkt)); >>> + break; >>> + default: >>> + dev_warn(inst->core->dev, "unknown property id: %x\n", pkt->property); >>> + } >>> + >>> +out: >>> + complete(&inst->completion); >>> +} >>> + >>> struct iris_hfi_gen1_response_pkt_info { >>> u32 pkt; >>> u32 pkt_sz; > Reviewed-by: Vikash Garodia