From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752123AbdGDHsb (ORCPT ); Tue, 4 Jul 2017 03:48:31 -0400 Received: from mx2.suse.de ([195.135.220.15]:51115 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750921AbdGDHsa (ORCPT ); Tue, 4 Jul 2017 03:48:30 -0400 Subject: Re: [PATCH v6 15/18] xen/pvcalls: implement the ioworker functions To: Stefano Stabellini , xen-devel@lists.xen.org Cc: linux-kernel@vger.kernel.org, boris.ostrovsky@oracle.com, Stefano Stabellini References: <1499116119-15638-1-git-send-email-sstabellini@kernel.org> <1499116119-15638-15-git-send-email-sstabellini@kernel.org> From: Juergen Gross Message-ID: <1f261107-e5bf-baed-cc76-dff01ebbafd1@suse.com> Date: Tue, 4 Jul 2017 09:48:27 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1499116119-15638-15-git-send-email-sstabellini@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/17 23:08, Stefano Stabellini wrote: > We have one ioworker per socket. Each ioworker goes through the list of > outstanding read/write requests. Once all requests have been dealt with, > it returns. > > We use one atomic counter per socket for "read" operations and one > for "write" operations to keep track of the reads/writes to do. > > We also use one atomic counter ("io") per ioworker to keep track of how > many outstanding requests we have in total assigned to the ioworker. The > ioworker finishes when there are none. > > Signed-off-by: Stefano Stabellini > Reviewed-by: Boris Ostrovsky > CC: boris.ostrovsky@oracle.com > CC: jgross@suse.com > --- > drivers/xen/pvcalls-back.c | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/xen/pvcalls-back.c b/drivers/xen/pvcalls-back.c > index 71a42fc..d59c2e4 100644 > --- a/drivers/xen/pvcalls-back.c > +++ b/drivers/xen/pvcalls-back.c > @@ -96,8 +96,35 @@ static int pvcalls_back_release_active(struct xenbus_device *dev, > struct pvcalls_fedata *fedata, > struct sock_mapping *map); > > +static void pvcalls_conn_back_read(void *opaque) > +{ > +} > + > +static int pvcalls_conn_back_write(struct sock_mapping *map) > +{ > + return 0; > +} Any reason for letting this function return int? I haven't spotted any use of the return value in this or any later patch. Juergen