From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 12123248F4B for ; Sun, 9 Aug 2026 15:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786287955; cv=none; b=d3rSR58y4FSQyDX6zUwa8o3iO+BjjHQ3WdnFz0PFIx3nDLk5rCbi8EqLac6DtyWHSIGFbACp2PNj555gKmCk02tMW0m1LkdqYHFm8NGvJFaBLVBEA3IJQruDJvHYSIoKHDJYFLc2lIyu3/vOe5RsGu/jCcLB8ggtDRIot4F7YSg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786287955; c=relaxed/simple; bh=N5EHcxRiFGQHcoZiSsmbsKQuX0XPu4+xUIXYTfGij6I=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=nC1pBVJ2xBoPDIjl/nGmgDUoWegh8FWkhB5M9MxW3UIO5DnFrUp+s+YfI6IK+XjnDBzbwq6/XCOQVY/CmLI/DFtFc4kb3ApPN5nuIHla9km8XvdcycYkR3WeyT/HPwbeT6HPhKngdLU2iCemAG06eThGIOPsmeATwGRi1mdCZ3g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZTZnLmhj; arc=none smtp.client-ip=209.85.210.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZTZnLmhj" Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-84a2dcede83so1438236b3a.3 for ; Sun, 09 Aug 2026 08:05:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1786287951; x=1786892751; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:from:to:cc :subject:date:message-id:reply-to:content-type; bh=0xMkbVk8Vq9ADk/FsQY03JHzIZEPQoL7wUy/e23YhPc=; b=ZTZnLmhjHnJC41sh6cCP/VpheJz2FuqcrOUJSeYxmisz6j8YJoiCpxtGheyzHebrTl 6mpQVPCkpsKTi7nnQQsyIEpxBHefvbmPyPqScwMgWvk14Lu2d/99fGeA1U2kHuokBmk6 QMA+ogORdNFTNOeq/5901H3/dcn7Q94Td4NLC7TdykALSLeVW+wJkJC/5LsY6vT/dMb9 uGWh3ouxJzd7EhP692vaOc/3m6AYKr6oJEWuwgWtdUhqE1B6jNLAdPZsqPd9cjctPlrK ZJq9nT9k6xUsqaCSTPPAR8qV7ilpluD5Mb/OSDIMS5ZszWyamgwgdrihwVmFUc7zFnpd FuSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786287951; x=1786892751; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:sender:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0xMkbVk8Vq9ADk/FsQY03JHzIZEPQoL7wUy/e23YhPc=; b=BSGEaFK4Cqr5FtgHtoVD/kcKNJQ1nEyom1x6B/TvnujTAbZS3MSbUVSlxHg8Jo0WyQ 8GPr8UurUUkd6JE+ymtWJQbpxLNZgBtepPUxut1IGdfyP2lOza07Rl5XceAyoojelIXg mwSPGhh2OoA9Tc0U4GdOoNFHgKPPYdffnajNhkokaWc8XsFHbZ7snSG6PovPARrBd7Y9 xIGZqjFtdVE0u7ivrhZudA4HSdXbAPuEpVCQBfMWJ+dhd6nPh/dzbcI4bGhyiLrKGhGD yNLN81nG2/QVDv/aD87I8Ant3fcJjlMNf2vmtHKrgV9y1xGQwh+zooPmZzqPmBmvbIMo XVCA== X-Forwarded-Encrypted: i=1; AHgh+RplKo8rDMcagCsEHKD9gHm42I4sZTas2gQ/4VzrTYk2Pj9hwYLcwXfhb1GMsGIb57MHRumr3clm+laiwiE=@vger.kernel.org X-Gm-Message-State: AOJu0YzbILWHiNg93d0psuU84N6r4bDGI6QnKfs/U1NZIBJ9Txer2wpC Fd1RNc8kLx+s9sAotHEyu6T/jKDMsT5QfDh3uI+Fat8L5G3dviSusKHb X-Gm-Gg: AR+sD12B2EHlfZ3YoEYkTPiVcsQ5dw/ctM2Z+uLhWdmoa5+fV3wA4rQMxwwJoEu8a0o PnshNh1K9HvUnV5e3ahUNUzKK7ooyTWGEUwC5Q+oGUJM5JL7XV1fWZkgYwkq2YekqyaKq1NX22z gqSzmxkk8IhBUYvkxJhNi+NQYmYp0Ijq/x6p9p3U8y+dUQjNvPolsqXqcmoHYMT2nbBoNTA5Rwt UmQGh7XAj/vC5JAgSkXBSQl9zDOqyc4g/5rMROBCdkbPg3qpsotIUsdswm85YUlEMfKDzsi1PyM S8CpJB3t7cmkSrBxuHzt/PasiWN9gbB/gOdTtvy5CPSgRssCAp/lBhIwpgpSGxtW2ne+9+Ug233 xp9rr6urv2zPFX/aKJV7Z25iMzpT953vyZ6pQAndscwPOR32OCN2BRUp5u+mAkkxQa253RwzkBK gHL7dB9QzTxd5U15tENckJJpcwe7Yam2Lmq7+F3i9sG9eWrre1uOnbXKJxhr6G+tEnLZLJGL4KG A== X-Received: by 2002:a05:6a20:9f09:b0:3b4:8f57:3205 with SMTP id adf61e73a8af0-3cbc04eb981mr20974725637.36.1786287951463; Sun, 09 Aug 2026 08:05:51 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-315beb88413sm54797483eec.18.2026.08.09.08.05.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 09 Aug 2026 08:05:50 -0700 (PDT) Sender: Guenter Roeck Date: Sun, 9 Aug 2026 08:05:50 -0700 From: Guenter Roeck To: phucduc.bui@gmail.com Cc: Wim Van Sebroeck , Joel Stanley , Andrew Jeffery , AngeloGioacchino Del Regno , linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org, linux-aspeed@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 4/4] watchdog: aspeed: Propagate errors from optional IRQ lookup Message-ID: <1f26fc28-da13-4ca3-990f-676b53d23630@roeck-us.net> References: <20260807081652.38692-1-phucduc.bui@gmail.com> <20260807081652.38692-4-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260807081652.38692-4-phucduc.bui@gmail.com> On Fri, Aug 07, 2026 at 03:16:52PM +0700, phucduc.bui@gmail.com wrote: > From: bui duc phuc > > platform_get_irq_optional() returns a positive IRQ number on success or > a negative error code on failure. For an optional IRQ, -ENXIO indicates > that no IRQ is available, while other errors should be propagated. > > Propagate errors such as -EPROBE_DEFER and -EINVAL instead of continuing > probe without the IRQ. > > Signed-off-by: bui duc phuc > --- > drivers/watchdog/aspeed_wdt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/watchdog/aspeed_wdt.c b/drivers/watchdog/aspeed_wdt.c > index c9e79851504c..48454ac86074 100644 > --- a/drivers/watchdog/aspeed_wdt.c > +++ b/drivers/watchdog/aspeed_wdt.c > @@ -429,6 +429,8 @@ static int aspeed_wdt_probe(struct platform_device *pdev) > if (wdt->cfg->irq_mask) { > int irq = platform_get_irq_optional(pdev, 0); > > + if (irq < 0 && irq != -ENXIO) > + return irq; > if (irq > 0) { This if () is no longer needed. Thanks, Guenter > ret = devm_request_irq(dev, irq, aspeed_wdt_irq, > IRQF_SHARED, dev_name(dev),