From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752816AbdBNSrQ (ORCPT ); Tue, 14 Feb 2017 13:47:16 -0500 Received: from terminus.zytor.com ([65.50.211.136]:53732 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752752AbdBNSrI (ORCPT ); Tue, 14 Feb 2017 13:47:08 -0500 Subject: Re: [PATCH 1/6] x86: drop unneded members of struct cpuinfo_x86 To: Geert Uytterhoeven , Borislav Petkov References: <1486933932-585-1-git-send-email-minipli@googlemail.com> <1486933932-585-2-git-send-email-minipli@googlemail.com> <20170214161700.fmrp2a4hl2fsjevs@pd.tnic> Cc: Mathias Krause , Thomas Gleixner , Ingo Molnar , Andrew Morton , "David S. Miller" , Jesper Nilsson , Mikael Starvik , the arch/x86 maintainers , "linux-kernel@vger.kernel.org" , "H. Peter Anvin" From: "H. Peter Anvin" Message-ID: <1f27da30-12ec-831a-b722-9834a0d12de4@zytor.com> Date: Tue, 14 Feb 2017 10:46:29 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/14/17 09:56, Geert Uytterhoeven wrote: >> >> Well, almost. You need the wp_works_ok removal patch too, otherwise you >> have the 3 bytes hole below. > > That's because you removed a char in commit 93a829e8e2c292f1 > ("x86, cpu: Convert FDIV bug detection), without compensating with padding ;-) > Padding isn't a problem (other than efficiency) for a structure which is strictly internal to the kernel as opposed to an ABI structure. -hpa