From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8AA628489B; Fri, 12 Sep 2025 21:11:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757711490; cv=none; b=Zyf6Zwmwr1a0yhU2D9K456v+82K+8z6SUcNyDFxV3uLB+7mFrnsByLGSPQpO1NM0D40i1RI2Udcsv5RTZ5RZJGwIklE+3LKdUr1/9GZHHDEjyknjIFBuYMHHbC3HZjAL4zmpeSu6QTVnyGqnGwcKaoHmYVwP+WVXXUYS6dB0+yM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757711490; c=relaxed/simple; bh=D/Cyd1SWByXhnXhlXz5eUp4WAyTJXeELIf5f2DNwVQs=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kSxRtD46pwCJJJ7U8sCV1fg+OTE/VsweIx70gheOtGjvu/0Pp6BifV+EzFM266YAgHNIzXH+P2ORDSliB5He9ixszPo7+jwuiXsctj/bJizwKNj3PUM5S8nUQ0d98wqTfH25ViLQckqJ4Lx3mCLan+Xsh8vN4yHkcaZ53NN7t0Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=zKdZd0GQ; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="zKdZd0GQ" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=QBCLCLlywXx8YW7RXuqLyrr43UeZ+UsFUs7lNnZijXg=; b=zKdZd0GQBLbpnow2hX0mg4RLTq IgzOfcH2SoMMqohYhoOP+iTYzRufSCKI0yoRY30bhcZFvebxzYUMIMRYf0lxbN68kbmIb3/lqh8kC dUIwc8WCtQdH+K4F0ooyAVxJZBLfuNczJhEKI5WpqwFGevsxAh5FnJFIzzCyEiADL5qY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1uxB2h-008G1n-Rx; Fri, 12 Sep 2025 23:10:51 +0200 Date: Fri, 12 Sep 2025 23:10:51 +0200 From: Andrew Lunn To: Vivian Wang Cc: Andrew Lunn , Jakub Kicinski , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Yixun Lan , "David S. Miller" , Eric Dumazet , Paolo Abeni , Philipp Zabel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Vivian Wang , Vadim Fedorenko , Junhui Liu , Simon Horman , Maxime Chevallier , netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, linux-kernel@vger.kernel.org, Troy Mitchell Subject: Re: [PATCH net-next v11 2/5] net: spacemit: Add K1 Ethernet MAC Message-ID: <1f2887e4-2644-48a4-8171-98bd310d190f@lunn.ch> References: <20250912-net-k1-emac-v11-0-aa3e84f8043b@iscas.ac.cn> <20250912-net-k1-emac-v11-2-aa3e84f8043b@iscas.ac.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250912-net-k1-emac-v11-2-aa3e84f8043b@iscas.ac.cn> > +static u32 emac_rd(struct emac_priv *priv, u32 reg) > +{ > + return readl(priv->iobase + reg); > +} > +static int emac_mii_read(struct mii_bus *bus, int phy_addr, int regnum) > +{ > + struct emac_priv *priv = bus->priv; > + u32 cmd = 0, val; > + int ret; > + > + cmd |= FIELD_PREP(MREGBIT_PHY_ADDRESS, phy_addr); > + cmd |= FIELD_PREP(MREGBIT_REGISTER_ADDRESS, regnum); > + cmd |= MREGBIT_START_MDIO_TRANS | MREGBIT_MDIO_READ_WRITE; > + > + emac_wr(priv, MAC_MDIO_DATA, 0x0); > + emac_wr(priv, MAC_MDIO_CONTROL, cmd); > + > + ret = readl_poll_timeout(priv->iobase + MAC_MDIO_CONTROL, val, > + !(val & MREGBIT_START_MDIO_TRANS), 100, 10000); > + > + if (ret) > + return ret; > + > + val = emac_rd(priv, MAC_MDIO_DATA); > + return val; emac_rd() returns a u32. Is it guaranteed by the hardware that the upper word is 0? Maybe this needs to be masked? Andrew