From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7626DC433FE for ; Thu, 24 Nov 2022 12:58:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229978AbiKXM6a (ORCPT ); Thu, 24 Nov 2022 07:58:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48884 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229967AbiKXM6V (ORCPT ); Thu, 24 Nov 2022 07:58:21 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 46D479E979; Thu, 24 Nov 2022 04:58:14 -0800 (PST) Received: from kwepemi500016.china.huawei.com (unknown [172.30.72.57]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NHyhM6FWFz15Mb6; Thu, 24 Nov 2022 20:57:39 +0800 (CST) Received: from [10.174.178.129] (10.174.178.129) by kwepemi500016.china.huawei.com (7.221.188.220) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 24 Nov 2022 20:58:11 +0800 Subject: Re: [PATCH 08/11] blk-throttle: remove repeat check of elapsed time from last upgrade in throtl_hierarchy_can_downgrade To: Tejun Heo CC: , , , , References: <20221123060401.20392-1-shikemeng@huawei.com> <20221123060401.20392-9-shikemeng@huawei.com> From: Kemeng Shi Message-ID: <1f2bb84b-6c8b-aaf1-053a-46fe8c773767@huawei.com> Date: Thu, 24 Nov 2022 20:58:10 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="gbk" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.178.129] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To kwepemi500016.china.huawei.com (7.221.188.220) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org on 11/24/2022 2:28 AM, Tejun Heo wrote: > On Wed, Nov 23, 2022 at 02:03:58PM +0800, Kemeng Shi wrote: >> static bool throtl_hierarchy_can_downgrade(struct throtl_grp *tg) >> { >> + if (time_before(now, tg->td->low_upgrade_time + td->throtl_slice)) >> + return false; > > Does this even build? Where is td defined? Sorry for this mistake, CONFIG_BLK_DEV_THROTTLING_LOW seems not be set on default. I will fix this and build with CONFIG_BLK_DEV_THROTTLING_LOW set. -- Best wishes Kemeng Shi