From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.221.44 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795210249; b=hVvxlvo5FEl9wAPS8o+Pr+WJZk5pY98TR81I1O40rry8C7gr/8+wsdSbBN5uveYPe7mr eISZtfZsvUQCQedR5jc38I2eX8c5xzMpun7RGBSMNmr3TajsSGcyeizxclooQUr5yLSYb 9tvoBxH75ObpKbRUFtf5a7My/hdSHjY0qk9TJQm/pwBL2OqMxroEPbiD4VzTAy1CPNQr4 1qDh8RztoI3YVRWvHsS65WIYtLacrmBZTxVXPBvA+qMPCUYjjyMQfK+VDkhLvHiZBlBQm J2oWq98W2AVtVd9NWp9GzcXtRurAnhCHviZtYHEHfgibw20YHSLVi7AU1TEpu5CrLSw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795210249; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:Autocrypt:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=a1ho229usvH7WXbHz/geyTJETW2rhXcPAgdJKyw9+jY=; b=sXgIWwAHkI6r7qR1EjaqcZ2zrew6TWqn8U4zA1k0PiR5Jt7m9qKdsCHpz27KS9o25fK4 ZD8WXxCQpj9yrDvkCJsp8CfFrwklLox731a1yKsqslcsSWjUG0amjDIr/umDl+YRkZUN7 4Km/fGHd7NcjngRs8ye3i09J9ANeKKUybiFEfWgXTKi9yHsiQ0oB8cce6OXDB2BKD29WF oVbD3AI+Sbt3AI+qNOgK3wp329lm9xJi5UNV5sUWUSIH3S75J6zjWdY7Csf0PYLEIKJwo 4k5XRmvZaQRboAmzB02MKoX5C9m5Rodem3LXVNHgjaB6Dh8p7+ejkhOUGtG6v+6DVrg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=f7vbJLAa; arc=none smtp.remote-ip=209.85.221.44 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D5B65606A6B8 for ; Fri, 20 Nov 2026 21:30:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D5B65606A6B8 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20260707 header.b=f7vbJLAa Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-4a3dd785f65so120311f8f.0 for ; Fri, 20 Nov 2026 13:30:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1795210246; x=1795815046; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=a1ho229usvH7WXbHz/geyTJETW2rhXcPAgdJKyw9+jY=; b=f7vbJLAauX1ju+cWR/RmICqMbM2gmqeyAfkOA+IV9lUo0n7cqt3FtIyoEBOCmidg4r Y/00HD2ZViRnBRaMyjLwYyxKajWQbPmBRwIQeDGm4dKK72y/JS2CTjPrcFEvWbcOgnlh Q0rssmXAUfQVfZ7kspfX7P+ghLUBLZaulP6GmPHa4My1mI8Cq2+Zx7cTQbH8+vqd37zQ V1RHgHvnH15edOMT9iXCkWcyvnQ7wnuVKkQ93KHC6SIU4kR8C8ImnONF3sjwstaMPly+ d3PlW7FycgUnemmyMjswQBXnUXKj2umCWjGtKlroR49RMbH7NOcE+DKJWU5/Lmw3x3QB 7I8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1795210246; x=1795815046; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=a1ho229usvH7WXbHz/geyTJETW2rhXcPAgdJKyw9+jY=; b=JtC6EnRPE5mUmFlh4pm1LOTGTz11WqRIkvOyw3EBc5UcAYfjBP0uu0caWrqP/YmU8n /erIzxFTCRaq70IESS2sW1gQ8iizPOX2PSkG955YFnCrVZJJTuN/UoVM8oP2kB+TcTyt HmFk78nHAbGAosoMULZpehs8s8X7MuC2vPIBEZNufb5/xviMHY+KkCGHC4EBULanukfr iTZwZly+XMRNyQNmkyfcSiMMaueQP6pA0qrOzWOYQwegm9TOPdxdJzE0WIXhjYUutxoK iAxIz8YG08ETmX91/AEf+CkGAlNVOTHY071FAvjX7bWc1XNl2JZFGNNsG+k2UYF/x0fZ ezOg== X-Forwarded-Encrypted: i=1; AL+hErGaw5mhopWoIO1sMB1x6/n1Bis5U+tPv6UZRkVlTB94/hOR5KM73xF/Psyoezlwlf3d4cUw4vmOCoxdhyg=@vger.kernel.org X-Gm-Message-State: APuU4Z87+Q69rvTfvzRvvZ1gwo0h7qmcvlQGm/n2mu0HdZeC3CFk+oUs Gl19aCEbcuV/jEydgPaltpCOixY5kWbPeMOwZDhP7wj89fLozZ/oOtDJ X-Gm-Gg: AYBFou0FahtRp9yamF7PrjDw1JUFeBTog9ipV+jz0rlVmdFk6HTjIk72BLQMe1w1Q1X b+Q6Tgr2hu9atZmf39RLrAsKv6tR8QvCkeFUIzQGIXPrgfSmMOM+xEMnf8fuqeZJNE1eAv7o9Y6 ymkBarpV/lcr+QCyriYQnsUDtygGlRoXkXifaAMYF5LJzb5VCskIF6H8DSLs3adFsEONz8A3bAX O9QwLrPHZYDRGv7/uwSHYeLcJMnlgKuoowse4XknyhM8FhMFTsZO1wYXGHofVsR25f1BWVjkVrX m6bKHoyUWki/z2Ta7wkcEqGeeYzgnlh4ZBXC34AC6D8drHSdX4Cbz5f1rRnoz0/5ypTpSucw43M 09W7NHJyeTmJr4UU7+KBEOaL2B1YVP72equNgC65L/q4HbbRE8INo8aghMtGL3B9lBlLaacHXYZ Qmu3mG4EkYZ2Hmgt7Vlkpilbv3AlIFIn+bkscd2+h4+UWKuD4EbOYQw9BxCKluEIjpkPozoCWg4 LkZfD7Bxajl4JJ/wAXXGXdSpzSsyHAzXZgd0ZL08tfpIzWir506LINnW4yEd9cYBi40aXrCgX4p qXwJuWvboiobNhj5tVufNQnOjI2tsrzqBdA/r1/RlIWWeN2WSTMyhwk+OagQBIRxLacy5Kdr1Xi 5p4zOaGG7Tbom28jgkL1t/tXDFp+IXeaoRlLbxvzV/BPLG2phRxzWfOjTbDVm2IGVW67DQY6dtx B8dpWElkBxYdV/8pDyvjRNT9Jtf6mKw65fl+BHnHtLzNZtLo3Mr2Kr3jLrfsj4q7xGiQf/ X-Received: by 2002:a05:600c:217:b0:4bb:6a02:d42e with SMTP id 5b1f17b1804b1-4bb887f3fb8mr69726355e9.1.1795210246073; Fri, 20 Nov 2026 13:30:46 -0800 (PST) Received: from ?IPV6:2a02:3100:65ed:8fc:216e:bbeb:a7f9:ea1d? (dynamic-2a02-3100-65ed-08fc-216e-bbeb-a7f9-ea1d.310.pool.telefonica.de. [2a02:3100:65ed:8fc:216e:bbeb:a7f9:ea1d]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4ab6baa3c4dsm6400500f8f.46.2026.11.20.13.30.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Nov 2026 13:30:45 -0800 (PST) Message-ID: <1f2ccb87-9017-4053-b8c8-5b31a211bd21@gmail.com> Date: Fri, 20 Nov 2026 22:30:44 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v10 2/4] net: hsr: refuse forwarding devices as HSR/PRP ports To: netdev-bot+sashiko@kernel.org Cc: netdev@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, davem@davemloft.net, edumazet@kernel.org, kuba@kernel.org, pabeni@redhat.com, horms@kernel.org, andrew+netdev@lunn.ch, shuah@kernel.org, kees@kernel.org, petr.wozniak@gmail.com, qingfang.deng@linux.dev, fmaurer@redhat.com, luka.gejak@linux.dev, bigeasy@linutronix.de, xiaoliang.yang_1@nxp.com, skhawaja@google.com, liuhangbin@gmail.com, stable@vger.kernel.org, sdf.kernel@gmail.com, lukma@denx.de, fmancera@suse.de, danishanwar@ti.com References: <20261117141922.20-3-xiexinet@gmail.com> <179514132185.3136.17085396682149520983@kernel.org> Content-Language: en-GB From: Xin Xie Autocrypt: addr=xiexinet@gmail.com; keydata= xsDNBGpiHugBDADJ5KuJaOYfUx7TGbRw0UE1km4dLnJomCSNtgq2T9BqgZ6TRPEy37soAmW3 XxCPvhfL6CPLldzy6O6EkUD7/8zlbQP1DM6gUIQUyKxxkb8uR+oCogDKjsxt0QPycP/dR9fk SL4qKReprnkOOcGeLahLHzofVdn46mc5igCBsAA/PPSpo1GqsfGk+zYV97rSVa8zhnSXsqZ/ 9DbUfQynZKVqYN4tm1B30JE5SEWDCko95Qw9fAORX2W356MOQJGr05z9qMSy7CkF7bAUkziG d6ZSPsGEsel5jYByP8ZvwQ2A8kdKpRy8+zQCaC+vEotTH7Fs7SIzE/Z5mEVIi1xQqEzN1rqG BW7KgzRDWjw8lKsoBbxv20nfhUzuZLan2HzUJ+LxZ18Os4zkWg9sxHgMi+AGqn/+0ppbDcOH 9Jm072/xA7O1MCXLgr4FOP+4PJH1vcqU+0EZVz7KCjrwkdz+l5Ojso2FLXq2MGoqWGShIsDV bF1JYpgm4spdPbnISkidUC0AEQEAAc0cWGluIFhpZSA8eGlleGluZXRAZ21haWwuY29tPsLB DQQTAQgANxYhBAHOahKZFnMu2n/CxrTrSufyPi3LBQJqYh7oBQkFo5qAAhsDBAsJCAcFFQgJ CgsFFgIDAQAACgkQtOtK5/I+LctmngwAlmrGPWnWxDW6PSJeR9SM0faqwuY33TWAE35nshm/ EEkBgpVVhG4z4Cdy7L+6TG6NHVDnvl+IHLyyOZlL3LQPQIpiKVgo6jHmm9TF6mK+Vo3nsXAA uSJYu9iY9Aywmy2JVQ15ttQ0NfcoZ0sV14bT7pSr9zXB6D8p3XA4AQI6IBeLvj993Z1+tPyC 6BJ+2aWWLBx7xGpFo3X8dhjS/Lm8QoietKbI+ACefKKCDNiM2KG53P76wdXJp52u4dqP6eFc +Qv35QefnALoPkOGQEdd1qvUycyZhuaCj8h0AxDu7bL3G/IM8G2K8qsbSJuui8zCSZ9b/QZf H7u1nevPOgxyWC1Pep/TbRZ62ktn8lrmWA8PZjuaJJQGjahuK1GgTQZNG+7DB7NwjLr6aXIm JirtT4FeR+IUovvL/ll+VHzpGpFbgXz4GTsWsikQkT1huFSB8MRLlWMXdAKblL96L754j8Z5 p/YV26YTppXI56uJ3XyOwZSrfrK1pfqNIp2Yr9vUzsDNBGpiHukBDACePM1YZ1FvAiFay/2v KVDNpuazmpVb1CBFy+rqM9HcuHe+5CuxLd4RI4hb0qmjlm5Vi5M8+AuNB/wi/f8oDuhJwlMn v9L0lfgpRRdShnB26hnt2wWwWFgOU3BwymSruxhEYq+eIjjxCAo6yW7Qm+ArZ+riETMI67sy ZyLx6o4yRiWxOrh1nhwV/f6PIOl+Iv4yLAG3eFXpU7/EZpim610bKMwcXEpiRkf3NjiflIha adoKHV0LCiVNrU7r8TICjjnugpl1tXAR2RlaRcSxmvOzrXY2O/xBLpwPr5erbdk8RCaxUzS0 kK0hw+/On3Sr4Z4gtLl2xtDkjRh3KQ9ZqMPrFD/5XOs842ueNivwIyAf2kQJjKfJGWc771EM 0ZWo1r1AthbuM+IeN5QM74rMJxaf5WyDX3ZeqBA55fCJGJ3zrp7Tqeoq8DYufiNkppE9S71z Cvxva2f8mUWTlTUf8s33sRD7C87XpT0whKpn1I9/nJB9Kb0dKyRCdcsT4o1ynxUAEQEAAcLA /AQYAQgAJhYhBAHOahKZFnMu2n/CxrTrSufyPi3LBQJqYh7pBQkFo5qAAhsMAAoJELTrSufy Pi3L/iwL/3aoCeq19Pog3fqisRyEZeX8pXw2GYlrJWYoM0mQ1USaTpdsMwCXaoFMoSBqid0F VPrqlH4bSIEEAzVmFPX0NjGhREDMrQ9eR5S9yqSpBvX+hz+xgpt4NOPhbVQmV+9f4lX9TJT7 GOO3EX2eeokg6ZAISycCAx7srXuc8oyRTJtnUQziH9GXrEeon88LHf1QHg0Z0sL/c7DfDqvW 9924M4ngQAZ8RgCBGZocoWuXCemSPkfQVLt5DzycSgSQODhbNSEmr+jb1V9Svf9D9k0CQfEY cB3uwOHWb6Z/yaEARbGZPSPn89YjXBncQTpgSvUM578b5x3pKi6PjZB/hwtUsRgrWGWoIwRi +ZmcHnCzsuo6uuNYX8VvmWqYsVajykjnpjdCGmU89QUsVmrtnDPBrfr8VVJcZPnCJhE595Pk LO29Oj0au9kr7kMW5Q+fBeHj5zz6VggAaRRU74/sgtwLODBWESPZ9LqUUdB5L/XbrSq2VDlD sNySbH3veZ/55EtlXA== In-Reply-To: <179514132185.3136.17085396682149520983@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 20/11/2026 03:22, netdev-bot+sashiko@kernel.org wrote: > Can a plain veth slave still re-enter the xmit path of its own HSR master? Yes. The redirect case exists without the patch, and the commit message lists it as not covered. seqnr_lock has been held across the port transmit since 06afd2c31d33 and 430d67bdcb04. The patch refuses port types that make no sense as HSR/PRP ports, which covers the syzbot topology, as Sebastian suggested [1]. > Would it be > better to stop holding seqnr_lock across dev_queue_xmit() in this fix, > instead of adding a denylist that the planned lock narrowing would > replace? Releasing seqnr_lock before the port transmit closes the whole class, but it can reorder frames for receivers without aae9d6b616b5 ("hsr: Implement more robust duplicate discard for HSR"). It is left to net-next, where Hangbin's patch [2] fits. > Could this hunk move into the GRO policy patch, or could a stable > dependency note be added? No stable backport is requested for this series. The macvlan GRO check depends on patch 1 and makes no sense in a tree without it. [1] https://lore.kernel.org/netdev/20261014151838.6RyMIRVM@linutronix.de/ [2] https://lore.kernel.org/netdev/20260805-hsr_deadlock-v1-1-d8a6f06fc5a8@kylinos.cn/ -- Xin