From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 986A536D512 for ; Tue, 31 Mar 2026 08:20:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945233; cv=none; b=sv3JNOt7PghBWeX1Cgm1Rmzw1Ka+LWgioHoAXS0N2yPCSygxha2O9g94gLP8viEh/xj2Ig25qb020ER7LBhhlXKof7tJh3TylQ85/Fk8DxA3aCQ1FyBEzByXMh2o3j6m69uNHuSWmYoTBaKBQHm3kcTpUBhcRqvqXq8062K8xxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774945233; c=relaxed/simple; bh=pIn7DVo83rKFtZQ4lodJgGsSWTKSw7e3XyL9bBLwCOI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Wz6cEFKmVPyx5QjbdJOHmoz2XA268tnFDB64MCVHY7Ej0TJMkoB3YMli/jilkbdnsEcxvT+V3MOgacaOglIhL4V7FFBPyOA8v55/DRMuepHAjwa//W8Ve7mv2g9ra/CGTn3re44yUPvwoRDe/9ZCSrABuePkiXvCg7Hl6x5Bz3U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Wk85xRbJ; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Q+zvWklN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Wk85xRbJ"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Q+zvWklN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62V2QN0Y4013544 for ; Tue, 31 Mar 2026 08:20:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BG1I/liNZmNcrk2tkigeYR5Je0NJszVTJPmGzNZ557U=; b=Wk85xRbJ/ntis3Z+ Dhhc9zf1ImvmsxEsvaPG1qqvEceuza5QEtVsZTpleMgA2EIbh/4qzqYUTWNDyMpB 5RuuZe1ObVti7NPPMc6GMdbK/OZmpv4foFfYmjK5wKfh782JnVHwkkD0yf8TUr1c Y8DzGb5XoJM5x3ejmCUy8HTdwPZNuYYai5La0njIEUZYhczQRXtMnOxgG1qDjkqu RLBc4A6afMz2T2Yp0paWi489yCWGs35hf61Tf4KLCWMBXl06wE0Mvjy7oW7OAAoU DTXikLj7F05QnSdgmQX9vtcSqY1vztUnUUpzQr3k3seTfOyHCGietHg4TermHOSp k8xnmQ== Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d7regv9rn-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 31 Mar 2026 08:20:31 +0000 (GMT) Received: by mail-pj1-f70.google.com with SMTP id 98e67ed59e1d1-35d9010602bso3881591a91.3 for ; Tue, 31 Mar 2026 01:20:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774945231; x=1775550031; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BG1I/liNZmNcrk2tkigeYR5Je0NJszVTJPmGzNZ557U=; b=Q+zvWklNYPcunN46OkLuUblcNtykZyWpPRMS2lzbZqE7DQcpWB2ZIWehsZfrOeIbCF kiEOF6nX3vT6+6i++luREMKynilzkLC+PBOUzyVg7bxBKkvWzUxI7v4aJkm/MT8CaARk wyr7hWyxFTP7fTKY4zVrw9ZKFIbRif7//cfE0ax1gURaDEjMMO06vYFdK/yQE16w9aP4 6MpM3selLekny7irmPou4aNnOujzyriqmX/cAFOoDo+w92QTj7iVyYpEz2v4VZf27JSO Wc9W0KP3ra51XQzOCUEKpxScXce/xTVx9Hrn/P2btUKBPoPd8HNvavGKHBdkQ4TgaZf4 UmIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774945231; x=1775550031; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BG1I/liNZmNcrk2tkigeYR5Je0NJszVTJPmGzNZ557U=; b=kyzoatzbKSryDWNMJsAnE+WnaI7FfuJ/GvS9emTulOAdOqZaiiyP2WQhf5KEY3qetx NtA5QpE7QrBJxzRgKQddNTLbWwBPV9YLcWnEY4voEra7lwe410x1c6HTiuDFPwcaFbUB /ewdZmDmn+QOio3ByobBJ1JWyqOyqwEh6pj1uMFvKWDWQOhYLXVVmInu9FuugEQh18ed G+RZ898Aa2SN5cfy4IaWX4W7F8iTwd2RI8ib6Vh9DxuAOEJjru6xxaji34XVs2CGwdpp d+hzOaN3pebAoZjSdxbzuXKkJcXJOBBUK/Jmhx3eZV1DPxAOMzgg8sopgYGGlj6KoBw/ 2hrg== X-Forwarded-Encrypted: i=1; AJvYcCXL/t/FYcWSk7w2ih/UXSGRBUwK+Of48wnAKsXpydIqdpKJTHCWFYIpTOX2oHE8stQjJIv9FGlwv+tJ1z4=@vger.kernel.org X-Gm-Message-State: AOJu0YwKkYnK6xhevDVh8NJTBg8TqczaF2kfvCYp+XyxgkEWOk0cZGCn ulUG3gTa/XqHLecceDonxK8BJBT/8vlC+Jzd516E6WEw0wUaM8/5Z6dDXY7phVWsm61bbjCTHQc HHiHDoBrYC3FizUqsMWtrnLC/LqTe9mObUrxf730Vi2SLM6qzHpyhqqPW9pXIB1xcfjw= X-Gm-Gg: ATEYQzyC7LHFxEKG6172JhE3FaBSdZ1s7JWlKDfLfCOrs7pSacdOA6wiwU/ktyly/9O fBDB7NdHCqLOcpZyKKMeXZWNKuoYuwzDqYYOZoiNtZ0lgHn1QoqAegLCnTw3s147m5dJhNKje8z Ftaw9Z0UDNwL+/8QWOTKa42eDk0LCSSe8zrYCoo32R828eBOfjWY1mp6FxCPwdQm74Pqiz8xawI +2716ys1SbMV3xcu1WYIkjuvEpw4c9UCQ/OqDqFc/0m1W1ESbmYpH9QIPyt04SWzTyax67EpJaB fsk8zxdRWAdc/tdC5putcMieJWhhhA16dz4kHsP6oCZu9HxIPZcDZzaGPA6f0UuCQwMDmnFxY0i hp/bCoHH453gPf9D8ILCYByljX7UCkFwlIfAcLJWF9zFmeJK9GC0qLw== X-Received: by 2002:a17:90b:5288:b0:35d:a557:e41 with SMTP id 98e67ed59e1d1-35da5572476mr7580359a91.14.1774945231123; Tue, 31 Mar 2026 01:20:31 -0700 (PDT) X-Received: by 2002:a17:90b:5288:b0:35d:a557:e41 with SMTP id 98e67ed59e1d1-35da5572476mr7580341a91.14.1774945230674; Tue, 31 Mar 2026 01:20:30 -0700 (PDT) Received: from [10.204.101.77] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-35dbe959886sm852242a91.14.2026.03.31.01.20.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 01:20:30 -0700 (PDT) Message-ID: <1f2e1608-100d-4a3e-99cf-6a7a6d39fbef@oss.qualcomm.com> Date: Tue, 31 Mar 2026 13:50:25 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/3] media: iris: Switch to hardware mode after firmware boot To: Dikshita Agarwal , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Vishnu Reddy Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260331-kodiak-gen2-support-v3-0-958296fab838@oss.qualcomm.com> <20260331-kodiak-gen2-support-v3-1-958296fab838@oss.qualcomm.com> Content-Language: en-US From: Vikash Garodia In-Reply-To: <20260331-kodiak-gen2-support-v3-1-958296fab838@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=G6wR0tk5 c=1 sm=1 tr=0 ts=69cb83cf cx=c_pps a=0uOsjrqzRL749jD1oC5vDA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=vonRipBiouzHufA7OUcA:9 a=QEXdDO2ut3YA:10 a=mQ_c8vxmzFEMiUWkPHU9:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMxMDA3OSBTYWx0ZWRfX8rqOD/p8228r ClO69dbjcBzFWjdHi9j79pfY2Rrbjy2t7i9MQBTzk/+HD7mog4aSYEMrG47PvV13Hyxb4VZW2YW TdfxPWLVXI5yKhHCi5/PAstDDRL2ADW8Sp/X60x9BzT/TSHJKRT6a3FdtAxFnmswqHvxjxVYemw fXhxkl7NaZ3zUwtH+7LnO9NTmIw7K4eC2/0S+N4ndMSWbYI/Ij/T0EUPaRGy6FuX0GPzIs1duHU ADD4mlOpsyuky82ElZtUawwrgHbuzlicnjoWE2MLRKtVgr/oMOsnEw5VaqyTsukjEkOJ6yg+JeC G8cm/oOVmZtCmG27FZ10GsGGNsA92lNoEH6cDPnEE+aYZMJcGAlr9yiwzsAOqDWKAOjrwV+pHBS qqpw/iFd2YDaEHe8vNz+kbuhLfkERgjf4aTztHs6kZD0vfLt7dkXrr5kXK9wXoApZHcndOslBXQ y0Qk9ng7Jbu87jJUMAg== X-Proofpoint-ORIG-GUID: oYXd94fNoazlybRut2gXdBYNo8ehIPEZ X-Proofpoint-GUID: oYXd94fNoazlybRut2gXdBYNo8ehIPEZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-31_02,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 clxscore=1015 suspectscore=0 bulkscore=0 malwarescore=0 adultscore=0 spamscore=0 priorityscore=1501 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603310079 On 3/31/2026 1:09 PM, Dikshita Agarwal wrote: > Currently the driver switches the vcodec GDSC to hardware (HW) mode > before firmware load and boot sequence. GDSC can be powered off, > keeping in hw mode, thereby the vcodec registers programmed in TrustZone > (TZ) carry default (reset) values. > Move the transition to HW mode after firmware load and boot sequence. > > The bug was exposed with driver configuring different stream ids to > different devices via iommu-map. With registers carrying reset values, > VPU would not generate desired stream-id, thereby leading to SMMU fault. > > The efuse tells us which hardware blocks are actually present. If efuse > status is disabled for a block, the driver will skip powering it on or > resetting it. otherwise the driver will perform the necessary resets and > then switch that block into hardware mode. This makes sure we only touch > hardware that really exists and is enabled on the silicon. > > Fixes: dde659d37036 ("media: iris: Introduce vpu ops for vpu4 with necessary hooks") > Co-developed-by: Vishnu Reddy > Signed-off-by: Vishnu Reddy > Signed-off-by: Vikash Garodia > Signed-off-by: Dikshita Agarwal > --- It is missing the RB tags