From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755471AbcI2Iqr (ORCPT <rfc822;w@1wt.eu>);
        Thu, 29 Sep 2016 04:46:47 -0400
Received: from mail-wm0-f66.google.com ([74.125.82.66]:36209 "EHLO
        mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753248AbcI2Iqm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 29 Sep 2016 04:46:42 -0400
Subject: Re: [PATCH] drm/mediatek: fix a typo
To: CK Hu <ck.hu@mediatek.com>, Bibby Hsieh <bibby.hsieh@mediatek.com>
References: <1475119322-58657-1-git-send-email-bibby.hsieh@mediatek.com>
 <1475121682.18843.2.camel@mtksdaap41>
Cc: David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel.vetter@ffwll.ch>,
        dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org,
        Yingjoe Chen <yingjoe.chen@mediatek.com>,
        Cawa Cheng <cawa.cheng@mediatek.com>,
        Daniel Kurtz <djkurtz@chromium.org>,
        Philipp Zabel <p.zabel@pengutronix.de>, YT Shen <yt.shen@mediatek.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Mao Huang <littlecvr@chromium.org>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Sascha Hauer <kernel@pengutronix.de>
From: Matthias Brugger <matthias.bgg@gmail.com>
Message-ID: <1f324471-bebb-c8bf-75c1-391355c50a99@gmail.com>
Date: Thu, 29 Sep 2016 10:46:38 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1475121682.18843.2.camel@mtksdaap41>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 29/09/16 06:01, CK Hu wrote:
> Acked-by: CK Hu <ck.hu@mediatek.com>
>
> On Thu, 2016-09-29 at 11:22 +0800, Bibby Hsieh wrote:
>> Fix the typo: OD_RELAYMODE->OD_CFG
>>

Although it is quite clear what the patch does, could you write one 
sentence to explain what it does. Maybe explain even which effect it 
has, which error get fixed etc.

As we are getting public available boards now, we should take more care 
about fixes. If you have a fix for a commit introduced in an earlier 
version of linux and it should be fixed for this version as well (e.g. 
v4.6 does have the feature but it does not work correctly) then please 
add these two lines before your Signed-off-by:

Fixes: <commit-hash> ("<commit subject line>")
Cc: stable@vger.kernel.org # v4.6+

Where v4.6+ stands for the oldest version where this should get fixed.

Thanks a lot,
Matthias

>> Signed-off-by: Bibby Hsieh <bibby.hsieh@mediatek.com>
>> ---
>>  drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
>> index df33b3c..aa5f20f 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c
>> @@ -123,7 +123,7 @@ static void mtk_od_config(struct mtk_ddp_comp *comp, unsigned int w,
>>  			  unsigned int bpc)
>>  {
>>  	writel(w << 16 | h, comp->regs + DISP_OD_SIZE);
>> -	writel(OD_RELAYMODE, comp->regs + OD_RELAYMODE);
>> +	writel(OD_RELAYMODE, comp->regs + OD_CFG);
>>  	mtk_dither_set(comp, bpc, DISP_OD_CFG);
>>  }
>>
>
>