From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: gregkh@linuxfoundation.org, rafael@kernel.org,
ckeepax@opensource.cirrus.com, tanureal@opensource.cirrus.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] regmap: sdw: check for invalid multi-register writes config
Date: Tue, 23 May 2023 18:13:25 +0100 [thread overview]
Message-ID: <1f34ca48-75cc-d824-2230-7375146ad970@linaro.org> (raw)
In-Reply-To: <dd2d2484-13f9-4fa6-85d2-5a540f137b3a@sirena.org.uk>
On 23/05/2023 17:58, Mark Brown wrote:
> On Tue, May 23, 2023 at 04:47:47PM +0100, Srinivas Kandagatla wrote:
>
>> + /* Only bulk writes are supported not multi-register writes */
>> + if (config->can_multi_write)
>> + return -ENOTSUPP;
>> +
>
> This doesn't seem like the right fix - I'd expect us to simply choose
> not to use multiple writes, with an additional flag/check for bus
> support.
Is there a way to check if bus support multi-register writes?
All I can see from the code is that regmap can_multi_write is set based
on regmap_config from device and write callback from bus.
--srini
next prev parent reply other threads:[~2023-05-23 17:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 15:47 Srinivas Kandagatla
2023-05-23 16:58 ` Mark Brown
2023-05-23 17:13 ` Srinivas Kandagatla [this message]
2023-05-23 17:25 ` Mark Brown
2023-05-24 11:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f34ca48-75cc-d824-2230-7375146ad970@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tanureal@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®