Re: [PATCH v3 1/2] dt-bindings: iio: adc: xlnx,zynqmp-ams: limit external channels to 30-50

[Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>]

On 11/4/2026 10:15 PM, Arnav Kapoor wrote:
> Channels 20 to 29 of the PL-SYSMON block are its fixed channels (PL
> temperature to VCCADC), which the driver always provides. Only channels
> 30 to 50 (the differential input, VUser0-3 and VAux0-15) are external
> channels that can be described as "channel@N" child nodes, yet the
> binding accepts any N from 20 to 50. Listing one of the fixed channels
> there only makes the driver add it a second time.
> 
> Limit the child nodes to channels 30 to 50.
> 
> Fixes: 39dd2d1e251d ("dt-bindings: iio: adc: Add Xilinx AMS binding documentation")
> Suggested-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com>
> ---

Looks good to me.
Reviewed-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>

Regards
Sai krishna

>   .../devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml       | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> index 3ae1a0bab38f..0872f5f314c1 100644
> --- a/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/xlnx,zynqmp-ams.yaml
> @@ -160,17 +160,18 @@ properties:
>           const: 0
>   
>       patternProperties:
> -      "^channel@([2-4][0-9]|50)$":
> +      "^channel@([34][0-9]|50)$":
>           type: object
>           description:
> -          Describes the external channels connected.
> +          Describes the external channels connected. Channels 20 to 29 are
> +          always available and are not listed here.
>   
>           properties:
>             reg:
>               description:
>                 Pair of pins the channel is connected to. This value is
>                 same as Channel Number for a particular channel.
> -            minimum: 20
> +            minimum: 30
>               maximum: 50
>   
>             xlnx,bipolar: