From: Dave Jiang <dave.jiang@intel.com>
To: Yang Li <yang.lee@linux.alibaba.com>,
jdmason@kudzu.us, allenbh@gmail.com
Cc: ntb@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next v2] ntb: Fix kernel-doc param for ntb_transport_create_queue
Date: Fri, 7 Jun 2024 09:14:29 -0700 [thread overview]
Message-ID: <1f393cc9-7195-4d58-b1ab-3616a184a88f@intel.com> (raw)
In-Reply-To: <20240607075720.77136-1-yang.lee@linux.alibaba.com>
On 6/7/24 12:57 AM, Yang Li wrote:
> The patch updates ntb_transport_create_queue() kdoc header to specify the
> correct input parameters used by the function.
>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Thank you!
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
I do recommend attaching the revision history below the '---' line next time for common patch posting practice. Thanks
> drivers/ntb/ntb_transport.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/ntb/ntb_transport.c b/drivers/ntb/ntb_transport.c
> index f9e7847a378e..5d466a3f117b 100644
> --- a/drivers/ntb/ntb_transport.c
> +++ b/drivers/ntb/ntb_transport.c
> @@ -1966,9 +1966,10 @@ static bool ntb_dma_filter_fn(struct dma_chan *chan, void *node)
>
> /**
> * ntb_transport_create_queue - Create a new NTB transport layer queue
> - * @rx_handler: receive callback function
> - * @tx_handler: transmit callback function
> - * @event_handler: event callback function
> + * @data: user-defined data to associate with the queue
> + * @client_dev: the device structure of the NTB client
> + * @handlers: structure containing receive, transmit, and event callback
> + * functions
> *
> * Create a new NTB transport layer queue and provide the queue with a callback
> * routine for both transmit and receive. The receive callback routine will be
prev parent reply other threads:[~2024-06-07 16:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-07 7:57 Yang Li
2024-06-07 16:14 ` Dave Jiang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f393cc9-7195-4d58-b1ab-3616a184a88f@intel.com \
--to=dave.jiang@intel.com \
--cc=allenbh@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=ntb@lists.linux.dev \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®