From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Andi Shyti <andi.shyti@kernel.org>,
Jesper Nilsson <jesper.nilsson@axis.com>
Cc: Alim Akhtar <alim.akhtar@samsung.com>,
linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@axis.com
Subject: Re: [PATCH] i2c: exynos5: Init data before registering interrupt handler
Date: Mon, 4 Mar 2024 16:08:00 +0100 [thread overview]
Message-ID: <1f4a2ada-0867-4ee0-bf27-4d69ab85b2e4@linaro.org> (raw)
In-Reply-To: <vpe5jvnhz3r5cpfiofwrelp62awe74knbxrz47i2deflczx276@yahhrshr355r>
On 04/03/2024 16:04, Andi Shyti wrote:
>> -
>> i2c->variant = of_device_get_match_data(&pdev->dev);
>> + if (!i2c->variant) {
>> + dev_err(&pdev->dev, "can't match device variant\n");
>> + return -ENODEV;
>
> return dev_err_probe(), please.
How this condition even possibly happen? And how is this related to the
problem described here?
No, don't mix two different issues.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-03-04 15:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-04 11:01 Jesper Nilsson
2024-03-04 15:04 ` Andi Shyti
2024-03-04 15:08 ` Krzysztof Kozlowski [this message]
2024-03-04 16:17 ` Jesper Nilsson
2024-03-04 16:15 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4a2ada-0867-4ee0-bf27-4d69ab85b2e4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=andi.shyti@kernel.org \
--cc=jesper.nilsson@axis.com \
--cc=kernel@axis.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®