From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E71AD1C5F0F for ; Mon, 13 Jan 2025 19:23:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796200; cv=none; b=IDox7SLBD2nBR3QQGVIjLCNm3njVIAZiLWwQju0vbuyayIbeZDm8Rx/gJO7IPtsR3G9kveFyR3ruiafWSH81iv+z2vz7vzVLqU/MEWv94rIY3xXU4nPgQ/296cfjPtVca+g62AIgya3kcisGeeof7RjK7b+V6VPjjKfyLvb/6tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736796200; c=relaxed/simple; bh=ioCmS8njMkyX0e58/rs7GvdQSegjZRe7GCoZzgunyY8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=HGvi6bY6mDx2uGKPl7Hkp/qrapXVL6icjI7oDhs+E7srMObsUaLAUXdk7HRhRmdI9ujlu0SPzEETyDCrZS4HlQJA6YvH51kA+Zt1fbwklkCOkhtOTVCmow71Z7CN/DK6s1NrAKbBZmMq1LYjK01dpsMH6y8JJaoTD8LfZ3CaL+o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Y7Bz+49i; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Y7Bz+49i" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50DErVUD021534 for ; Mon, 13 Jan 2025 19:23:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= MFV3aWNNS+t43F5uwTgcNEgS2obH2Bxb2qDmFQO3CYE=; b=Y7Bz+49ii3WJMBW9 qgjk1kc/D+3bkwkSYJl482XuzAHPOauUZv8rKjUuvcC199I0aUQkmJ+vnJceobDU rh6dCM/1//bXoME0cOSjhRtcqRIhRZ96OSmdrv/IqueT9FaqPEsNNLpvdSGvz88u l73x5MrQVqkJL34mbkv3oBIBYCs2sL3eYn1sIKBXKvFviKozzyajPatmnuTJGclP Xnx/RX3JYy/IZm8TsuYiGdLQE8Vh2nTRcLRyBzJJFVTnAElRwpomXEervL3aeEvi 1Lw/LbuQ/ETV8pZxuS3l0P44hLrY8sBp/Z/v7ew/kTeX4yekE+daPIwIWNuzq13K Ux/xqA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 44550agnuv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 13 Jan 2025 19:23:17 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2166f9f52fbso142297755ad.2 for ; Mon, 13 Jan 2025 11:23:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736796196; x=1737400996; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MFV3aWNNS+t43F5uwTgcNEgS2obH2Bxb2qDmFQO3CYE=; b=Vywlv32a81NV4nnpr6E6btGsNwmXc09jFczZxABTLiJsVYv1IwnTIjpJvn4rk4ydtk TxgNtX8M7/V3v1mHE2cms7EKrzv2hsFOjI5anTsFM1xU2XVRiC9XU7VZYtykuynQWFRb Op9MmZ4E95DYQVih3IVtyeMPciWxu7wmMvVuqtmm+n6Zo9zyZkcrFUwJWyeUxzvAP5gg /7aV6qS1C6fX3a4kZR93w2WSf9dprcs3Al+PdLMAJYk7/JPDuTPr77L1rDylG7Zd3msO cHWIlreE8idk11w1fqzL/hJ6eywK9Gzcqq6AIXavML74hJCCq2KGfyPZzx4lfIYVhlBl aHCA== X-Forwarded-Encrypted: i=1; AJvYcCUxKQfBpj011NQSxYLmHK3a9VOch90o5vgMfzxlhKRY/hKS/nBbIlMNWIj4iC9KBKKYjpPVlkjzfS/XdAw=@vger.kernel.org X-Gm-Message-State: AOJu0YyWUVuqMrxH1s1LZT21qMfgIDI//v5esGL5VtYEsjDmPmGjhm+P pCtysAAROrIzS1okvEnz7b42eeXwh/IRrLKYlPN4peIfGfG/LH9aKHVgxgWcmuMze0jTXErwxga 9g8xQvja4KeDL9J2PtFcYBCMehbx0iW0K92ES+95PaVtzEqq7iuAaGHUTRRRUXRU= X-Gm-Gg: ASbGncuIZFHYZaAYqiHhVEINzCNhtRhdEuysSzSGHydjnmZaXksxRqwfvcEcB6jagp4 0jrVQOs2pW8QG3vDrCzu04jhHzoTPU/DtoRRpJL61T/YVHxIp8hL6h7RiEQOivDWgj/xT8Zn12V 6D2GOuyMCR0TAub/DM3vQDVdHMLSogWHVzokyyc0YOZ327BH94lu42jPp3kTqi6p+QZxJmK9iXe ZRs+RSONZPZ50ZzZLycTUcxgpjVNmcTggJRT3HpzOvccyjZVpDpx2W/CVeS+gLJT34PB56bO5w2 0PHFCHWeDcm6Z5m1VLcmQYtGYJ97dvJ8GXwOga/93Q6fOxXMHg== X-Received: by 2002:a17:902:f54d:b0:216:5af7:5a8e with SMTP id d9443c01a7336-21a83f65878mr319923105ad.26.1736796196391; Mon, 13 Jan 2025 11:23:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IH+hkVFHMduF9zujMICY19YD28FULovU7wGDvUztcC3lTrH9ftOX4fFFpXyDrtI6NVzk4ROMg== X-Received: by 2002:a17:902:f54d:b0:216:5af7:5a8e with SMTP id d9443c01a7336-21a83f65878mr319922775ad.26.1736796196028; Mon, 13 Jan 2025 11:23:16 -0800 (PST) Received: from [192.168.1.111] (c-73-202-227-126.hsd1.ca.comcast.net. [73.202.227.126]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-21a9f23499csm56196645ad.193.2025.01.13.11.23.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Jan 2025 11:23:15 -0800 (PST) Message-ID: <1f4d5894-c04f-476e-83f6-71e3c5aff231@oss.qualcomm.com> Date: Mon, 13 Jan 2025 11:23:14 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 07/10] wifi: ath12k: fix ATH12K_FLAG_REGISTERED flag handling To: Aditya Kumar Singh , Kalle Valo , Jeff Johnson , Karthikeyan Periyasamy , Harshitha Prem Cc: Kalle Valo , linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20250109-fix_reboot_issues_with_hw_grouping-v1-0-fb39ec03451e@quicinc.com> <20250109-fix_reboot_issues_with_hw_grouping-v1-7-fb39ec03451e@quicinc.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: <20250109-fix_reboot_issues_with_hw_grouping-v1-7-fb39ec03451e@quicinc.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: QDr2rXHS4_dNddzLgdp-ep4TLlX-jbvZ X-Proofpoint-GUID: QDr2rXHS4_dNddzLgdp-ep4TLlX-jbvZ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 suspectscore=0 mlxlogscore=999 adultscore=0 impostorscore=0 spamscore=0 clxscore=1015 malwarescore=0 bulkscore=0 phishscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501130155 On 1/8/2025 8:25 PM, Aditya Kumar Singh wrote: > Commit a5686ae820fa ("wifi: ath12k: move ATH12K_FLAG_REGISTERED handling to > ath12k_mac_register()") relocated the setting of the ATH12K_FLAG_REGISTERED > flag to the ath12k_mac_register() function. However, this function only > accesses the first device (ab) via ag->ab[0], resulting in the flag being > set only for the first device in the group. Similarly, > ath12k_mac_unregister() only unsets the flag for the first device. The flag > should actually be set for all devices in the group to avoid issues during > recovery. > > Hence, move setting and clearing of this flag in the function > ath12k_core_hw_group_start() and ath12k_core_hw_group_stop() respectively. > > Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.3.1-00173-QCAHKSWPL_SILICONZ-1 > > Fixes: a5686ae820fa ("wifi: ath12k: move ATH12K_FLAG_REGISTERED handling to ath12k_mac_register()") > Signed-off-by: Aditya Kumar Singh Acked-by: Jeff Johnson