mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Zhouyi Zhou" <yizhouzhou@ict.ac.cn>
To: "Jason Baron" <jbaron@akamai.com>
Cc: "Zhouyi Zhou" <zhouzhouyi@gmail.com>,
	drjones@redhat.com, konrad.wilk@oracle.com,
	raghavendra.kt@linux.vnet.ibm.com, mingo@kernel.org,
	davem@davemloft.net, hannes@stressinduktion.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] jump_label: tidy jump_label_ratelimit.h
Date: Thu, 21 Aug 2014 10:58:18 +0800 (GMT+08:00)	[thread overview]
Message-ID: <1f4dead.5721.147f680239b.Coremail.yizhouzhou@ict.ac.cn> (raw)
In-Reply-To: <53F50C74.7080304@akamai.com>

Thanks Jason for reviewing it 
> -----Original Messages-----
> From: "Jason Baron" <jbaron@akamai.com>
> Sent Time: Thursday, August 21, 2014
> To: "Zhouyi Zhou" <zhouzhouyi@gmail.com>
> Cc: drjones@redhat.com, konrad.wilk@oracle.com, raghavendra.kt@linux.vnet.ibm.com, mingo@kernel.org, davem@davemloft.net, hannes@stressinduktion.org, linux-kernel@vger.kernel.org, "Zhouyi Zhou" <yizhouzhou@ict.ac.cn>
> Subject: Re: [PATCH 1/1] jump_label: tidy jump_label_ratelimit.h
> 
> Yes, that looks good. While at it I grep'd the tree for
> 'CONFIG_JUMP_LABEL', and found some uses in the
> netfilter code which should probably be
> 'HAVE_JUMP_LABEL' as well.
I have submitted two patches according to you suggestions:
https://lkml.org/lkml/2014/8/20/885
https://lkml.org/lkml/2014/8/20/883
Hope I have made them right

Thanks 
Zhouyi
> 
> Thanks,
> 
> -Jason
> 
> On 08/20/2014 05:29 AM, Zhouyi Zhou wrote:
> > jump_label_ratelimit.h is split from jump_label.h to enable the 
> > includers who don't want linux/workqueue.h.
> > As HAVE_JUMP_LABEL is only defined in jump_label.h, will following  
> > patch makes jump_labe_ratelimit.h more tidy?
> >
> > Compiled and Tested in x86_64
> > Signed-off-by: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
> > ---
> >  include/linux/jump_label_ratelimit.h |    5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >
> > diff --git a/include/linux/jump_label_ratelimit.h b/include/linux/jump_label_ratelimit.h
> > index 089f70f..0d34d7e 100644
> > --- a/include/linux/jump_label_ratelimit.h
> > +++ b/include/linux/jump_label_ratelimit.h
> > @@ -4,15 +4,12 @@
> >  #include <linux/jump_label.h>
> >  #include <linux/workqueue.h>
> >  
> > -#if defined(CC_HAVE_ASM_GOTO) && defined(CONFIG_JUMP_LABEL)
> > +#ifdef HAVE_JUMP_LABEL
> >  struct static_key_deferred {
> >  	struct static_key key;
> >  	unsigned long timeout;
> >  	struct delayed_work work;
> >  };
> > -#endif
> > -
> > -#ifdef HAVE_JUMP_LABEL
> >  extern void static_key_slow_dec_deferred(struct static_key_deferred *key);
> >  extern void
> >  jump_label_rate_limit(struct static_key_deferred *key, unsigned long rl);
> 





  reply	other threads:[~2014-08-21  2:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-20  9:29 Zhouyi Zhou
2014-08-20 21:00 ` Jason Baron
2014-08-21  2:58   ` Zhouyi Zhou [this message]
2014-08-22 14:35     ` Jason Baron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f4dead.5721.147f680239b.Coremail.yizhouzhou@ict.ac.cn \
    --to=yizhouzhou@ict.ac.cn \
    --cc=davem@davemloft.net \
    --cc=drjones@redhat.com \
    --cc=hannes@stressinduktion.org \
    --cc=jbaron@akamai.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=raghavendra.kt@linux.vnet.ibm.com \
    --cc=zhouzhouyi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®