From: Andrew Lunn <andrew@lunn.ch>
To: netdev-bot+sashiko@kernel.org
Cc: hongmei.xu@oss.qualcomm.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: phy: aquantia: AQR113c fix up PMA capabilities
Date: Sun, 27 Sep 2026 16:02:38 +0200 [thread overview]
Message-ID: <1f4f03ee-59c9-4789-ac84-81bb7c8a7959@lunn.ch> (raw)
In-Reply-To: <179047527921.2160803.15181990521063252187@kernel.org>
> [Severity: Medium]
> Does this drop EEE capability discovery on AQR113C?
>
> Before this patch, the AQR113C entry had neither .features nor
> .get_features, so phy_probe() took the is_c45 branch:
>
> drivers/net/phy/phy_device.c:phy_probe() {
> ...
> if (phydrv->features) {
> linkmode_copy(phydev->supported, phydrv->features);
> genphy_c45_read_eee_abilities(phydev);
This is a good point. And it is probably a bigger issue, since none of
the get_feature functions in this driver call
genphy_c45_read_eee_abilities(). Please could you add another patch
the series addressing this.
Andrew
next prev parent reply other threads:[~2026-09-27 14:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-27 2:14 netdev-bot+sashiko
2026-09-27 14:02 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-09-23 2:02 Hongmei Xu
2026-09-23 15:26 ` Andrew Lunn
2026-09-24 3:41 ` Hongmei Xu
2026-09-24 12:43 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f4f03ee-59c9-4789-ac84-81bb7c8a7959@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=hongmei.xu@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®