From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 425C4C77B73 for ; Tue, 2 May 2023 06:33:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233504AbjEBGd3 (ORCPT ); Tue, 2 May 2023 02:33:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47226 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231608AbjEBGd0 (ORCPT ); Tue, 2 May 2023 02:33:26 -0400 Received: from mail-ej1-x62d.google.com (mail-ej1-x62d.google.com [IPv6:2a00:1450:4864:20::62d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B7621FDE for ; Mon, 1 May 2023 23:33:24 -0700 (PDT) Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-94f109b1808so668343666b.1 for ; Mon, 01 May 2023 23:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683009203; x=1685601203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uaq8RBsdIqA9qX9LHQLxBDk7YAiPOkXhWlKDq4LcMaQ=; b=EpygdFOp3Lz9pVvAeiqhRO4O0tSkCEG98YuTXFSr4DGYFduehhNrQkFQ5T+I9eaUiK cIGtzHJFJ8+/339aQa/xr2TGVtQvBH+tSaZsm6atNza48b+aGrOAH4OV5mdZlQNMbLzQ 7P5L03w64lexL7WTFwFZwKaAP6hUEqOTF/kxpaTM1uNi+y6blULTspzwTlhjOCvUX6Uw wGBhtpKDS+bBuRE0hHKCl4cosrVEmT9r7lPwhRO3/EoBV8jC+8j2yT1wgTTdu/L1D9yX 7cUFb+aQozs+IlrMxvz5tLpg3yUUDGP7dCjz091cUhPCpqIeadiLehf6GbZ1fFwsSG7O s1tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683009203; x=1685601203; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uaq8RBsdIqA9qX9LHQLxBDk7YAiPOkXhWlKDq4LcMaQ=; b=CPn0PAzOj30RAkAztcuww17V4Ij217Ok9siz+AEJPTz3Z1uhuPShaJQdWwi1RZHKYj IVi0FIWSXWXgufVjFGhSNCgTPhkPmPiS21V79RDUc8n+ihXtXkoz8opki6kSL60qKF9Z n0lDtjO5oF5tiaN4xvHDFX78XGFFSlaeFVLmU11lWHVRPl3ye+L5OlwJe1en00GidLmg yF1jIsuAg0Fv5y/MSQnlXogn0Hhz1g8+16W55D/5/q0C7qjOM4s0eYkR+rIcAJOUWm5T eoOHKkx23FdMDKDqjpmQ5cdDXuArDvhCcRlo++USSo/syhaHxxR8ijgcboDuAiUqcuoR D6sQ== X-Gm-Message-State: AC+VfDx5jFDUHx6Z21fN+Bs4YXKsRwox/FTwbNc9CJrDpjzjbFMDYRLK s/ODWO9v0yvL8IxnzxHiGxcTxA== X-Google-Smtp-Source: ACHHUZ6apAeClITPtCDbSvp+k0+epqog8ZneVuhMCyHGOrgUaR0bY1xE7MdImkH2oGmxG23D9UxS+w== X-Received: by 2002:a17:907:9345:b0:961:272d:bda5 with SMTP id bv5-20020a170907934500b00961272dbda5mr9382786ejc.49.1683009202824; Mon, 01 May 2023 23:33:22 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:bafd:1283:b136:5f6a? ([2a02:810d:15c0:828:bafd:1283:b136:5f6a]) by smtp.gmail.com with ESMTPSA id qt2-20020a170906ece200b0094e1344ddfdsm15562427ejb.34.2023.05.01.23.33.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 01 May 2023 23:33:21 -0700 (PDT) Message-ID: <1f520e8a-7785-f4dc-2f9b-d6afd1e3f671@linaro.org> Date: Tue, 2 May 2023 08:33:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [PATCH v2 5/8] dt-bindings: power: supply: max77658: Add ADI MAX77658 Battery Content-Language: en-US To: "Arslanbenzer, Zeynep" Cc: "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-pm@vger.kernel.org" , "lee@kernel.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "sre@kernel.org" , "lgirdwood@gmail.com" , "broonie@kernel.org" References: <20230322055628.4441-1-Zeynep.Arslanbenzer@analog.com> <20230322055628.4441-6-Zeynep.Arslanbenzer@analog.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2023 22:20, Arslanbenzer, Zeynep wrote: >> You already said it above. >> >>> + in battery.yaml, with the following properties being required: >>> + - alert-celsius >>> + >>> +required: >>> + - compatible >> >> Why reg and monitored-batter are not required? >> > If no monitored-battery information is supplied, we set default values for alert-celsius. So the device can operate without battery? Interesting... are you sure, you can physically remove battery and device will work? > The reg property is the I2C address of the device and it is part of the parent schema. Therefore, both are not required in this file. What does it mean "in parent schema"? You have reg here, so how parent schema is related to this? Since you did not reply, I assume all other comments will be implemented. Best regards, Krzysztof