From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932936AbdKBRcx (ORCPT ); Thu, 2 Nov 2017 13:32:53 -0400 Received: from mail-cys01nam02on0047.outbound.protection.outlook.com ([104.47.37.47]:28458 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932383AbdKBRcq (ORCPT ); Thu, 2 Nov 2017 13:32:46 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; Cc: brijesh.singh@amd.com, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Paolo Bonzini , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= , Herbert Xu , Gary Hook , Tom Lendacky , linux-crypto@vger.kernel.org Subject: Re: [Part2 PATCH v7 13/38] crypto: ccp: Add Secure Encrypted Virtualization (SEV) command support To: Borislav Petkov References: <20171101211623.71496-1-brijesh.singh@amd.com> <20171101211623.71496-14-brijesh.singh@amd.com> <20171102171017.t7auzgm7zqp4ncjb@pd.tnic> From: Brijesh Singh Message-ID: <1f54e39f-7e2b-26d0-2d22-b8ccbef67c3d@amd.com> Date: Thu, 2 Nov 2017 12:32:39 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171102171017.t7auzgm7zqp4ncjb@pd.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: DM5PR21CA0057.namprd21.prod.outlook.com (10.175.112.147) To SN1PR12MB0158.namprd12.prod.outlook.com (10.162.3.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a1aab991-88db-4585-7962-08d52217b9bc X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(48565401081)(2017052603199);SRVR:SN1PR12MB0158; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;3:nsvriQ+10I+bleuj2qHF/WNUnYDX4onbNU7XcdAQ1EHcIZvxsy/82hREElvkhC8+smzgRCbeCfU6WQjHvX8bdpUtm/wdBDcVmFNlaUm2mtMwR0d6SNmoDAE/LnriODVB1YvSCkfnsLEq4Pz86+wn6L9D3QDt3dBBuTpEuBFR3M8/i2gNQMXA1WZaqQw30KcVymPw2dHJZedcMoJoS8ymHYbccDHgm2m3fHWtwgVhXrZOj26Sn3XdEjx93UZKMhsA;25:di8IaE/qXd/GGhCf6EC4S6Z8p3QAZVUWOXPmL7dl8xZNfB7nBuXsNUBh30eoNTmfvLe2EdO4pj2KOx2c8ByPidWOiabq7Ld7w6ve7EtDEtaGpl+2nnbE+xZ4oRKuzYZuNim0We5mWqba6G1R9oORdE1LHGo+O1P8KmL5xYp4Mj2l8mMl8q5j0z/n7JUBOBKl8l7PtjCzEx4dm96q06KPpzlzbtV5eOlv2D7vyjz3V3K33Tr7Ov0p8MfdmWrQlo0dxAn1E7a1bJlQKo7G9iam9WB0+xNzLqtxRCjF3yjo7kTwqjjKMclhK/nmB3mhh4QLMPBS+72Pj/FPqgVZDTCc6g==;31:7ow2GGgl8DzJ0ZCVme2zNdvD8sOHyf9ev6Ranf01UoEqL0gxDVmGcddySKIYYuTEmB/C1V9+3z44xX0waFqnx23Hv1AOPIxgScH+r+86lUC80wQ0zEmcDa9bvoUIt994xGR2vkBsqJoLKaUbv2mwHWzPwOJgLW42WIPrs6xOOcdCW9v/YzuMvicl+C74BKLJmW/TWs9lLe5F5V5n+cQDvyiIwiZ/bNhgJHS+UlVw6kc= X-MS-TrafficTypeDiagnostic: SN1PR12MB0158: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:leSSxXvC/x9VO7KmqylBZtBxRpg+x+/P2c72riDyU/duS/RyXKNPFCp7sRqROieM3AItXcEHdmbPsqusvncHeLJrGKPXnzwrrrslfAsLW/6kTNhWm68e3n0Yx+e11uHua38B18IVwSNL3GAshyOiaKIQtG7IIRvW/1RTztg4RB0y8lvDDFKEi9U7NMmwbZnJy/5osLFwgzBVlQV2YdYRZcc+2JSqWj9AIF4lE0j9fTi+HLOYTo7nT7G7Rtow5ve/syOeBGXEp5QadY7fNxrBR3rRB8yM703fo5W4FLbg2nfNOrYGZUODJd6bJNP/PcPglV+cLnwCpgUmNxL8CfUi18UEmrtNTAUN0h9XEG42SksQro7VVxcTTGkc4K+BznQ2YOHiyKAYAT2+d+lKQwvEe8xlozO9uamm8httevtklWdjqhZMfax2+NAHM+NRuGZle/cbZJasxPlnRjzza85u/IlDfdtcUAnE4ForII6t/boM5fGQnNhF+IXbyPw8IXVn;4:DVsJp55L9g31SxPFZBPTqRxCnA8rCwlqeLzdkApmTsyrFA30gGNyS0JHNuoerPk2fouybP9mO9miEX+2AeCcYEAmwL8/5QRPXVdExuAPcbXT/lYNQ00J5SLHy81DZS+rbxTDuB8Ycif4kW+sjpfEDOzhuQp0/HMQBZa6JsEX6PHaccQrhbqwJzzIbmOH7sqmfu07M19TlY8tL15ir8YzwCIBUv7DiE0rsolezPqd78nSHZbxk1VUN0thA1wOzPdIT1X6dGx8VaNdmxrdCBCmkA== X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3231020)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123562025)(20161123558100)(20161123564025)(20161123555025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0158;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0158; X-Forefront-PRVS: 047999FF16 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(346002)(376002)(39860400002)(189002)(199003)(24454002)(51914003)(23676003)(16576012)(105586002)(90366009)(229853002)(77096006)(67846002)(189998001)(81156014)(6486002)(2906002)(58126008)(316002)(230700001)(54906003)(3846002)(81166006)(68736007)(6116002)(76176999)(106356001)(6916009)(8936002)(50986999)(54356999)(101416001)(31686004)(64126003)(4326008)(36756003)(47776003)(97736004)(7736002)(25786009)(16526018)(66066001)(65956001)(65806001)(5660300001)(65826007)(86362001)(50466002)(53546010)(6666003)(305945005)(83506002)(2950100002)(53936002)(31696002)(6246003)(8676002)(33646002)(478600001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0158;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTU4OzIzOkp0S2VqQldhT2RWbUJpQVo4Q090RVVFRVhR?= =?utf-8?B?YkFpR1Fpd2xxcXE3VmFwb25UaHRQdmNMNFdROEFRdmVoRUFGdVlORlJqSDFz?= =?utf-8?B?YS9obGszd3FVMjQzRnhuMWJ5eTZnTVZvWlhjRkw4aURiYmJJMmpxZ0ZMUkIy?= =?utf-8?B?SFBORzhsYUNpMkpJVkU2aGM4WG1RaElyeTZQdFZrby9wTm1TQ3pKYUlFYVg2?= =?utf-8?B?My9DaWRuVnRMM1VlWUZGRU42aXFnSHNjdStNdW5ydWdObmdBLzB5bEk2VUxo?= =?utf-8?B?YVFwNDJQUTdLZVFaSE56K1F2QUcrUldITzFvN0ZjMEFaZjVXSVI0NHFqS1V0?= =?utf-8?B?SmVPMFhIamdBb1d2Q1l2NWVXTDZjT2ZWWG1pQ2ZFdWdtV2hRV0JMam5KOVNa?= =?utf-8?B?dEdSVm5MZEpUcit2Y0RMbFpuYksrNUI4Zk9zdVJQcEFkc3p5ZkNadnN3ZmZi?= =?utf-8?B?VHNiVmlzY1kxKzVLai8zK1VweFppVDdFaFNLMis0MHJqWkVqU2VoVkEyQlpt?= =?utf-8?B?dWo2TmdaQUowM3VOZkxKMzB4QTdZaER6ZXR3TUs0TmdoZ0ZoRklXNGZpVEx6?= =?utf-8?B?ZUY2MWxkL2VMKzNPbU9xa0lMZDBTZWg3UXhtSFlCeU1SM2ZtOTdpbWFrZXQ2?= =?utf-8?B?TFk3c3YxN0o1MnhEeHNZcnJZMVc0SnNrWmppYjRqQTVCaUZ1WlJwQ09ES1or?= =?utf-8?B?ZzZCeUVDdnVoMEcxemlDUnk4dDhBUkwyVmo3cW5WTi9BTE1ya0VLWkQzaUE0?= =?utf-8?B?QXNLWnNVRVBibCtkdllLVG82NW1SR1BxZ2w3RmFlclVibjV0cGNydWRZNWw5?= =?utf-8?B?emFObXZrME52Z1ZhK0FLYkk0VUU2LytadFRJaE5mQkxuSG9RTm1ibiswMnhx?= =?utf-8?B?THhCWGdaSi9PZjR1MEszSzMxODdQT1pXWDJFQUZaNmh6WG5VcGdZdElZejJM?= =?utf-8?B?VEh0dVRHNklsbHhtU1VxYmVLYWpOSkpNbUtmdHluWDJEamN6bk9RSU1zbVdZ?= =?utf-8?B?bk1YRE1DMm92SGtiaXJ6MGRqaTAxcFYrdnErYjFsbmNqUDBNUmcySUQ3aU5w?= =?utf-8?B?Z1h5Uk1lakh6VjFuM3orZ2UwcXpaMGlhejQ1enN1YmhpaXVTcGxBY25HRGJ6?= =?utf-8?B?K056TjFjV3ZrYlpwbTJjem52MXovdzFqS1hUWjQ4STZQSXRIZmRHM2tyaHdY?= =?utf-8?B?TjJlbkd4OWlieVVFa0toaVRvM3R0dGFNTlpIand2ajVieGVXWlFYVy9TSzRW?= =?utf-8?B?QmE5UFZFRk45eGZndXp1Tk5maXZlaEhFZWplMmtZejhvUHFZanZFOVQ2WkVo?= =?utf-8?B?aTVHUjBreFVEN3ByNGQyNGxXY1JBRlg0RDdicm0vTExLbnh4RHRobDZpRHky?= =?utf-8?B?aXN0YWxIVEl5R0VCWnE3Q1B2LzBHdG9PRzBWM2g0VDlGdm5paXlBcWdFVWh3?= =?utf-8?B?N2Y3ZDBoYjY4TkQyVGduVkpwSEpYdlR3UzZlUWRydmp0UWNmUEtxcEdZTDJL?= =?utf-8?B?Wms2T0JpenhFOTBmQWs5ZzFaM3cvYUhLTDNWSnpHcjR6aHlyQWQrU3JGNlNo?= =?utf-8?B?V3JhUExPaUFBMTAyMUg3MTdGM0ZqRVp0TVFFTFlIbXczUjVxT1B2d2hyOTh4?= =?utf-8?B?OWdra3Z0SkxxY0JpOGVBWHJRcEZ0TTBXaUZkYTNSQW8wVGFFTDBFTEJZN1pY?= =?utf-8?B?YzVRUjdnUDBNRkNHZXBoYTNydS9ZSUpZTm9FOUtua2JEUjlzb1BIWnJ2MDk0?= =?utf-8?B?TGNGbEdGREp5a0FwdVdkQ2ttYlB6K1YyYTlLdXMrckxkd3MrVjNxVmJoTCtk?= =?utf-8?B?c01YNTlMOGFSM0RZcjZPeTZnS3QzRktTK2V6U0JTSmI1am1ialpXZjBrOUx6?= =?utf-8?B?ZW5CdDg4MzE0MEptSUpXaEEydHN4WVZ4MkYzMXpZTnhZK1Nhc3lIV3hDMWt3?= =?utf-8?B?WDJXbGN5TG9RPT0=?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;6:wW8VjJuzKvxoluZ+u7d4j1r8yR3xIc8OBrrLGXx2DPlXJ/XfgMvatDWzoYYEF0h12QixcYEpvrP/+ZgkgnkdaRMb6mUYWjQB2WW60rWqqTQAfaLwbkfSrgb16bJhWLDVgtW8o+S0dW8RpJZquoR1HUGe/5jJYjXHglSXH26jeMlf48n2BIrvhIXg5g9fl7rc57U2Hrn5s06j2VyFT1f8y5SF8QT5Djj53/8wGatBjTqwGaUC7IRkk17tE61pDu6jR9QkXBT/t+1hWwMvEJTEK/KyLlF5xMlK0QhCD/vRWe6G4tAs/OPV20/Q0vUm5GcZVYZ9ojEUgiopUW3gkCX7Ea2aWdFAYgB+la9xTK9ql5w=;5:Mbv9T4fAO0roEnySsE3oGVeYu217DsIdkTeaGgoaulX0/xLwHIZlp27DVLlQLKC9PpVWuioKgFV8m9hD/mun6Cr3vbdBsdT5Vj5TJxlMf7GFPEgw6gVk7vVMoSrtSjhdH1FwcDlyAgC4kuzy4u+g/bTU/0DrJ0all8A67ORnU2w=;24:FixOsrPmiuYuQ+8C/tnOD5ZuimARvni/MdhuOOVuA/ZANE5vHOXePDxODiiIFdJUmTzdWn9YZsN22SHdWrszpMenIdJcT5yODQeJAk2GP4M=;7:8Fz6XWQBgJgHH7gZA+V17ibb+TDRi/SVIsbUmnFvqW9smyEHr+6NquKMwdlZXbbO4PxZM++qzS/LRs9upS0i1kHevDnX6xBVHUcey8fkcza0mkB+yP9abQrs7Lqfr+lbm1EQtCoU1JrbY++TfZW9olUrSfEEkRs0JNe79dZwWbC/P9xdsWaY7NnQ1IrZDkUEDY2+pyxp823Lp70DmY1Jq2sPp8JOYd9V1ZbKlpRpll5qYKtn+LQViH0wbX5qbt1T SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0158;20:mMlw8YA+DC1/YUP8QHUsGhrGihV8BT9f8QerfLlbm0pBBCbNvA3S4jit0LTzG+qArRliWFC2ApliN4ik9/Cite7S7EBzXWrhEhoMJsowJROFqwjWA083/dKkstSJemNDD6NaSrzO+h/kiUZjrgbXNO+atapavnUFymMg1ESYvnCJqiwtpyiw0+WF/alsmXefQeSaHY+/b9qNycq9/CVLtnHpNic+SQmaZgLKDeWUsoJSLOslv0EsAWfswZXO6l1G X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2017 17:32:43.1959 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a1aab991-88db-4585-7962-08d52217b9bc X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0158 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/02/2017 12:10 PM, Borislav Petkov wrote: ... >> drivers/crypto/ccp/psp-dev.c | 350 +++++++++++++++++++++++++++++++++++++++++++ >> drivers/crypto/ccp/psp-dev.h | 24 +++ >> drivers/crypto/ccp/sp-dev.c | 9 ++ >> drivers/crypto/ccp/sp-dev.h | 4 + >> include/linux/psp-sev.h | 143 ++++++++++++++++++ >> 5 files changed, 530 insertions(+) > > Some more cleanups: > > * If sev_data_init is per psp_device, you can simply embed it in the > struct psp_device and save yourself the complete allocation. > > * s/sev_ops_init/sev_misc_init/ because it doesn't do anything ops-like > > * save some header lines. > Thanks for the cleanup patch, I will apply these changes. Additionally, I will also embed the sev_user_data_platform_status in per psp_device struct instead of dvmem_kzalloc(). -Brijesh