From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934222AbdJRMIX (ORCPT ); Wed, 18 Oct 2017 08:08:23 -0400 Received: from lelnx194.ext.ti.com ([198.47.27.80]:56099 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932333AbdJRMIV (ORCPT ); Wed, 18 Oct 2017 08:08:21 -0400 Subject: Re: [PATCH 0/2] phy: ti-pipe3: Update PCIe PHY settings To: Bjorn Helgaas References: <20171009090338.26033-1-kishon@ti.com> <20171017193129.GM5641@bhelgaas-glaptop.roam.corp.google.com> CC: Bjorn Helgaas , Roger Quadros , , , , From: Kishon Vijay Abraham I Message-ID: <1f583d30-fdf4-e104-271c-8a36704cbaf2@ti.com> Date: Wed, 18 Oct 2017 17:38:15 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20171017193129.GM5641@bhelgaas-glaptop.roam.corp.google.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 18 October 2017 01:01 AM, Bjorn Helgaas wrote: > On Mon, Oct 09, 2017 at 02:33:36PM +0530, Kishon Vijay Abraham I wrote: >> This was supposed to only update ti-pipe3 PHY registers. However because >> of the way the ti-pipe3 PHY, OCP2SCP and PCIe controller are connected >> in dra7xx where >> >> PCIe controller --------------> ti-pipe3 PHY --------------> OCP2SCP >> depends on depends on >> >> updating ti-pipe3 PHY registers results in an abort. >> >> Though the dependency between ti-pipe3 PHY and OCP2SCP is created >> (OCP2SCP is parent of ti-pipe3 PHY), and enabling ti-pipe3 PHY clocks >> should in turn enable OCP2SCP (with the help of pm_runtime framework), >> this doesn't work in no_irq stage since pm_runtime is disabled during >> no_irq stage. Since pci-dra7xx enables/initializes ti-pipe3 phy in >> no_irq stage, OCP2SCP is not enabled resulting in an abort with ti-pipe3 >> PHY registers are accessed. >> >> In order to solve this a functional dependency is created between >> PCIe and ti-pipe3 PHY so that PCIe is suspended before PHY/OCP2SCP >> and resumed after PCIe PHY/OCP2SCP >> >> Kishon Vijay Abraham I (2): >> PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY > > s/PCI: dwc: dra7xx: Create functional dependency between PCIe and PHY/ > PCI: dra7xx: Create functional dependency between PCIe and PHY/ > > Should these be merged together? If it makes sense for you to merge them > together, here's my ack for the PCI piece: > > Acked-by: Bjorn Helgaas Yeah both should be merged together. I'll make the change you suggested, add your Ack and merge myself. Thanks Kishon