From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
"'Axel Lin'" <axel.lin@ingics.com>
Cc: "'Linus Walleij'" <linus.walleij@linaro.org>,
"'Kyungmin Park'" <kyungmin.park@samsung.com>,
linux-kernel@vger.kernel.org
Subject: RE: [PATCH] pinctrl: exynos5440/samsung: Staticize pcfgs
Date: Mon, 03 Dec 2012 18:08:26 +0900 [thread overview]
Message-ID: <1f6a01cdd135$c11149e0$4333dda0$%kim@samsung.com> (raw)
In-Reply-To: <CAJuYYwRdBdi+gG944ZcJk8xF6hLUD165iX0oLn9HWeyo3od+hA@mail.gmail.com>
Thomas Abraham wrote:
>
> On 27 November 2012 20:19, Axel Lin <axel.lin@ingics.com> wrote:
> > I got below build error with random config if CONFIG_PINCTRL_SAMSUNG=y
> &&
> > CONFIG_PINCTRL_EXYNOS5440=y.
> >
> > Fix the build error by making pcfgs static.
> >
> > LD drivers/pinctrl/built-in.o
> > drivers/pinctrl/pinctrl-exynos5440.o: In function `.LANCHOR0':
> > pinctrl-exynos5440.c:(.data+0x54): multiple definition of `pcfgs'
> > drivers/pinctrl/pinctrl-samsung.o:pinctrl-samsung.c:(.data+0x54): first
> defined here
> > make[2]: *** [drivers/pinctrl/built-in.o] Error 1
> > make[1]: *** [drivers/pinctrl] Error 2
> > make: *** [drivers] Error 2
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
>
> Acked-by: Thomas Abraham <thomas.abraham@linaro.org>
>
> Dear Mr. Kim,
>
> Could you please consider this patch in your next pull request for fixes.
>
Sure, I will.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
prev parent reply other threads:[~2012-12-03 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 14:49 Axel Lin
2012-12-01 23:06 ` Linus Walleij
2012-12-10 1:40 ` Kukjin Kim
2012-12-03 9:07 ` Thomas Abraham
2012-12-03 9:08 ` Kukjin Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='1f6a01cdd135$c11149e0$4333dda0$%kim@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=axel.lin@ingics.com \
--cc=kyungmin.park@samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®