Re: [PATCH 0/4] ACPI: CPPC: Fixes to limit actions to online CPUs

["Mario Limonciello (AMD) (kernel.org)" <superm1@kernel.org>]

On 11/5/2025 8:38 AM, Gautham R. Shenoy wrote:
> Hello,
> 
> Christopher Harris reported a regression between v6.10 to v6.11 that
> the amd-pstate driver failed to load even when the commandline had
> "amd_pstate=passive"
> (https://lore.kernel.org/lkml/CAM+eXpdDT7KjLV0AxEwOLkSJ2QtrsvGvjA2cCHvt1d0k2_C4Cw@mail.gmail.com/)
> 
> On debugging the issue it was observed that when the commandline
> contains "nosmt=force", the CPPC code fails when performing certain
> checks such as checking for the presence of preferred cores and
> validity of the _CPC object since it iterates through all "present"
> CPUs while the object state was populated only for "online" CPUs.
> 
> This patchset contains fixes to address this issue.
> 
> The first two patches in the series address the issue reported by
> Chris.
> 
> Patches 3 and 4 harden the code in a couple of more functions which
> iterated through the present CPUs when it is more apt to restrict the
> operations to online CPUs
> 
> 
> 
> Gautham R. Shenoy (4):
>    ACPI: CPPC: Detect preferred core availability on online CPUs
>    ACPI: CPPC: Check _CPC validity for only the online CPUs
>    ACPI: CPPC: Perform fast check switch only for online CPUs
>    ACPI: CPPC: Limit perf ctrs in PCC check only to online CPUs
> 
>   arch/x86/kernel/acpi/cppc.c | 2 +-
>   drivers/acpi/cppc_acpi.c    | 6 +++---
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 

The series looks good to me.

Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>

But I would say I noticed we are also using for_each_present_cpu() in 
amd-pstate with amd_pstate_change_mode_without_dvr_change().

Should that also get a similar change?