From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.128.43 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792673700; b=QgeupZOFTpFPMI5qmqPg+uo3eyGWDCysevHbPSPms4zcDOAIkYpeiUj67iLtkRdcItn3 1T6auhsAtshJEA4g44EukqmPXu2v5oVvA+N4e3JaJLgKhAJ5Fltn25QezK65bEhPh+ikV a4nxOXfK5e+UoLYNiil5I2gPD4zqpivB7mlqZQMgl0UiGYA/dN/iGWZBWP06I9wNOz9WU wMfrCw0r78DPZwEv72wmuvuCj1BmWPib70SlFeIZlbt0T43edvNTRtqvKRSt0ZYGp4CAo mt39JQ9nQJ72PmxLjfdk/hKhEX54RQzEVEF0z5tAf0Z2/xSTptcvRiowzAy+ENGcV/g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792673700; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References: Content-Language:From:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=jYF7S1s7Ov9hCjAhKpbMqkQvqhCJSe4k6JebACUrQ0U=; b=dQetMOeyqgqCB3Q0gbWP+CH2HPxPW4kEhOaWAUt6Hf1qBbh9RId6mU+x3KlN0zdCnYFT z5CUgXS/hQYLDTlbV84ecibmBnqo0bO4WO0NwC/eCmUauqRNbA2UU1QVAGu3dsT0L4qxa vWEU3sDOrgX6N7dCOK3jwCe9zM/YFqMJd8ZXso7Y7tXcZfhYfv26DsmZhMTwc1iktCAab 5qoqkVy5ONZ5iNEkgELN0OzyhaGwVucL+okcUp2CUoOkzgYHZs6L3YDrJ0sq+k5fGWt0U eYX1CpZ0MMUY9yUeXu4tDZcAAQid3l0DcSmFV4CrJ8zyxuOSor5ALLnDl6vSlgnjdzQ== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b="Tf/UrPXS"; arc=none smtp.remote-ip=209.85.128.43 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD218606A320 for ; Thu, 22 Oct 2026 12:54:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org AD218606A320 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=Tf/UrPXS Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-4956869750eso12335645e9.2 for ; Thu, 22 Oct 2026 05:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792673698; x=1793278498; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=jYF7S1s7Ov9hCjAhKpbMqkQvqhCJSe4k6JebACUrQ0U=; b=Tf/UrPXS6OMKvW6NT4sd1MVRCIhvkTZbkk2B3znuVBpcASONX6lht3nvJq94UwT9cp U1gdOal3613SHEmj2uMk/aymgbYEYU/YtNQASzO0343AxXAoKuM0vSBu0Xsc5RnXUHcU /mX0yZTImozVkLJ49VAm1wXxUCIYAHAbu54l7CtCPHdeXYFsIKuAO3E3hxL2lgh2AF57 hqpO1MCoO49LUQy1LYqJ/MKZ/SlkdI8/P2ul9BdL6l6FF+RPw4SvxY9FGG3v8ABwJHZ3 eM0W2VqBDwul+r7UiaASn6iGxOVU48cYXVgvfC1Six3ivjbvA2ShQPM/d9+dU6fAlmux 5zYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792673698; x=1793278498; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=jYF7S1s7Ov9hCjAhKpbMqkQvqhCJSe4k6JebACUrQ0U=; b=IlrmQ61qg4y91i7lJrUFgB4075rz4rJkk7wW+Q5+6ruZa6+0jToAYMuiA546yfGs9d nIpa7dfpsO8vCo7+1Kt31+Vgw5ZfhYCYSdK5jD7KPfg87n8rBClcpRvHxS1uMjNjAwO8 GKAhwAPbIv7pJi7Q9FIXVPUlQMoxnuT9PfiM41BDu2Zh5qtXIjblNUKWDqx7INaOSCrh PDu3UCdrQcFJHG8urqW8aKqiScihiT5ihoDaz2tu+Pf1dp7C/AG0ZGCYkZGu61v/sp2I 4qq+90tGZdZpkieh2nB0yOYX1nEqSsRiSgntj2uhq5LfISvDHtqqrzwl8FaFov+AbyDG +i6A== X-Forwarded-Encrypted: i=1; AKwUvBy5S8soPh1gQRLKCNmi9IvrXGDa1QMUm0sVAmbZTqi3aGxUO7iKLT+TnQgaN0jPsHgtIp5Hlcbj7h/MuGE=@vger.kernel.org X-Gm-Message-State: AFq9FYLUiAfEhy8C33AnrFwyEiXFsUOz5J8B0/Fb2BdeQUULTMpLvo7J VPPCeL2e6fBAPTCIcZo6xJyVMsDfnM4A1IHi5xngJUzCHrn0Ho7xjXI= X-Gm-Gg: AYBFou15rhnyCzv0F9e+LX8NYmMKZvDf4OSLAdVJhfPNIQ1ZRi9CkUaP3MIWwmGMOqZ Vld0OEO2aHXc89xlkBFWiLS6powdwFUFEu8dfn5oBGz+3wB6Xdc9gcTtAMK4M3ZVWAc/GcTzIfL UFL88agU9W3nSNAWOrLAxJenvUQeCRfZqZjR/QOVp13yAkn6RyiCZ4myW1K9u8BN722PzxCnYkz L7dW3d7OE1bAy6EqclPo90IaPAbPblETXPFiPSBeWsfNBQBEWxljAVbrVAshzJ2XW0M08M3IRea 9dhi/fQeEP0xbvZW5OdLYBMv8W4L9Z+gC9Rbzh4cMSbzsvmq3lsJ1IAGQUwUkkM1HtS7rAsj99k aa3Aeh/6alAjcHiJa1PBmBAHRmc2lF9Mm4uIMelzCurqHbWhtkrpZOVcfIlX/lMPDMRkRjNmCLR yySurUS+EMl7YsiqnHYUBxOkjBx7tx1h9r0qtCncsd73fS+9ZMoBJP797dHR7X/MKajf4b27M+W ZEyq9s9O2hirQZXdXJElUYYZVVcD2DG0S+F3X8ky2gDoxvJjoc8c2tgl1u1JKeNRHuY6zNJglRX RgjHh72lIMMUxyAbjq34BWjX0quGnxKpCrI+ X-Received: by 2002:a05:600c:1c2a:b0:4a1:e57b:667c with SMTP id 5b1f17b1804b1-4a1fdd4fe80mr121774905e9.26.1792673697832; Thu, 22 Oct 2026 05:54:57 -0700 (PDT) Received: from ?IPV6:2001:b07:2ec:601d:4b26:1672:75c7:805a? ([2001:b07:2ec:601d:4b26:1672:75c7:805a]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a203a447c8sm68550055e9.12.2026.10.22.05.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Oct 2026 05:54:57 -0700 (PDT) Message-ID: <1f6db59c-b7a9-41a1-8022-6713365fa09e@gmail.com> Date: Thu, 22 Oct 2026 14:54:53 +0200 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 03/13] drm/msm: look for lpac from dts To: Dmitry Baryshkov , Akhil P Oommen Cc: Rob Clark , Will Deacon , Robin Murphy , Joerg Roedel , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , iommu@lists.linux.dev, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org References: <20260705-descriptive-name-lpac-upstream-v1-0-01d50c3e0c99@gmail.com> <20260705-descriptive-name-lpac-upstream-v1-3-01d50c3e0c99@gmail.com> <54cb37bb-aaa5-4c5d-a563-acca4822dd35@oss.qualcomm.com> Content-Language: en-US From: Anna Maniscalco In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/9/26 9:39 PM, Dmitry Baryshkov wrote: > On Thu, Jul 09, 2026 at 05:54:23PM +0300, Dmitry Baryshkov wrote: >> On Thu, Jul 09, 2026 at 07:12:39PM +0530, Akhil P Oommen wrote: >>> On 7/7/2026 10:09 PM, Dmitry Baryshkov wrote: >>>> On Tue, Jul 07, 2026 at 05:02:43PM +0200, Anna Maniscalco wrote: >>>>> On 7/6/26 5:04 PM, Dmitry Baryshkov wrote: >>>>>> On Sun, Jul 05, 2026 at 09:13:37PM +0200, Anna Maniscalco wrote: >>>>>>> In order to associate the SID used by LPAC to it's own domain and >>>>>>> context bank we need a separate node on the DTS. >>>>>> Can we use iommu-map instead of adding a new device using the same >>>>>> addresses? You provide zero explanations, but it seems like you are >>>>>> trying to separate a part of the GPU into a separate device, but it's >>>>>> unnecessary. >>>>> What I was trying to say is that we need to map sid0 and sid1 to different >>>>> context banks. >>>>> >>>>> From what I recall, so long as we use the same dt node, the iommu drivert >>>>> provides no way of doing this. >>>>> >>>>> What kgsl does is having a node for the iommu and then subnodes for gfx lpac >>>>> and secure. >>>>> >>>>> The address on the lpac device doesn't really matter. I have very limted >>>>> knowledge of DTSs but I think we could just leave it out altogether? >>>> I think, you were poined to the Glymur Iris patches. Another option is >>>> the QDA driver being submitted too. Both ot them use iommu-map to >>>> describe the same usecase - a set of SIDs which are used by the device >>>> but which should not be a part of the defaut set. With it in place you >>>> don't need to have separate qcom,lpac devices, no additional properties, >>>> etc. >>>> >>>> I'd recommend following the same approach. >>> iiuc, the conclusion in this recent thread is to use child nodes for a >>> similar case: >>> https://lore.kernel.org/all/20260618151745.GD231643@ziepe.ca/ >> Let me check internally. > After a brief discussion: it can be either, depending on what suites > better (and if you can persuade DMA / IOMMU maintainers to let one extra > bus or not). > One thing sashiko is pointing out is that new dt should work with hold kernel so, in general moving sid1 from there would break it since old kernels don't know how to handle them separately. Not sure how to address this. Best regards, -- Anna Maniscalco