From: xiujianfeng <xiujianfeng@huawei.com>
To: Paul Moore <paul@paul-moore.com>
Cc: <jmorris@namei.org>, <serge@hallyn.com>,
<linux-security-module@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] lsm_audit: Clean up redundant NULL pointer check
Date: Tue, 28 Jun 2022 15:29:02 +0800 [thread overview]
Message-ID: <1f736550-b9ac-04f8-9056-6c3cd0f2d8fe@huawei.com> (raw)
In-Reply-To: <CAHC9VhR8k-MDnHsMcdYb5SondWGem19CRPx5p23WtkcrHFaBnQ@mail.gmail.com>
Hi,
在 2022/6/15 10:07, Paul Moore 写道:
> On Tue, Jun 14, 2022 at 8:13 AM Xiu Jianfeng <xiujianfeng@huawei.com> wrote:
>> The implements of {ip,tcp,udp,dccp,sctp,ipv6}_hdr(skb) guarantee that
>> they will never return NULL, and elsewhere user don't do the check
>> as well, so remove the check here.
>>
>> Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
>> ---
>> security/lsm_audit.c | 14 +-------------
>> 1 file changed, 1 insertion(+), 13 deletions(-)
> Reviewed-by: Paul Moore <paul@paul-moore.com>
Thanks for the review, and kindly ping here ...
prev parent reply other threads:[~2022-06-28 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-14 12:10 Xiu Jianfeng
2022-06-15 2:07 ` Paul Moore
2022-06-28 7:29 ` xiujianfeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f736550-b9ac-04f8-9056-6c3cd0f2d8fe@huawei.com \
--to=xiujianfeng@huawei.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=paul@paul-moore.com \
--cc=serge@hallyn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®