From: Jon Hunter <jonathanh@nvidia.com>
To: Sheetal <sheetal@nvidia.com>, Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>
Cc: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Thierry Reding <thierry.reding@kernel.org>,
Sameer Pujar <spujar@nvidia.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mohan Kumar <mkumard@nvidia.com>,
linux-sound@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v2 0/2] ASoC: tegra: ASRC ratio control updates
Date: Wed, 4 Nov 2026 15:09:06 +0000 [thread overview]
Message-ID: <1f7a7e79-1539-4303-9d73-e6195b9e470f@nvidia.com> (raw)
In-Reply-To: <20261005085227.2133834-1-sheetal@nvidia.com>
On 05/10/2026 09:52, Sheetal wrote:
> This RFC updates the Tegra ASRC software ratio controls so userspace
> programs the integer and fractional ratio parts through one paired ALSA
> mixer control.
>
> This is a userspace-visible ALSA mixer control ABI change. Existing
> userspace that programs the ratio with separate controls must switch from
> the legacy commands:
>
> amixer -c APE cset name="ASRC1 Ratio<N> Integer Part" \
> <integer part>
> amixer -c APE cset name="ASRC1 Ratio<N> Fractional Part" \
> <fractional part>
>
> to the paired control:
>
> amixer -c APE cset name="ASRC1 Ratio<N>" \
> "<integer part>,<fractional part>"
>
> For example:
>
> amixer -c APE cset name="ASRC1 Ratio1" "0,715827882"
>
> The ABI change is needed because the previous separate controls can expose
> hardware to a transient mixed ratio when one part has been updated but the
> other still contains the old value. The paired control lets the driver
> validate and program the full ratio together.
>
> For active streams, the driver only unlocks and re-locks the stream when
> the new software ratio differs from the cached ratio by more than 20%.
> Hardware allows direct updates for smaller ratio changes, while larger
> jumps require the stream lock to be refreshed.
This still applies fine on -next and I am fine with the above ABI
change. With that, for the series ...
Acked-by: Jon Hunter <jonathanh@nvidia.com>
Thanks!
Jon
--
nvpublic
prev parent reply other threads:[~2026-11-04 15:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-05 8:52 Sheetal
2026-10-05 8:52 ` [RFC PATCH v2 1/2] ASoC: tegra: Update ASRC ratio controls Sheetal
2026-10-05 8:52 ` [RFC PATCH v2 2/2] ASoC: tegra: Cache ASRC ratios until streams are active Sheetal
2026-11-04 15:09 ` Jon Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f7a7e79-1539-4303-9d73-e6195b9e470f@nvidia.com \
--to=jonathanh@nvidia.com \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=perex@perex.cz \
--cc=sheetal@nvidia.com \
--cc=spujar@nvidia.com \
--cc=thierry.reding@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®