From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6726CC10F14 for ; Sun, 6 Oct 2019 15:12:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 39C3721479 for ; Sun, 6 Oct 2019 15:12:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="iMtXxQKu" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725985AbfJFPMm (ORCPT ); Sun, 6 Oct 2019 11:12:42 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:46451 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726586AbfJFPMj (ORCPT ); Sun, 6 Oct 2019 11:12:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570374756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ayjqkd+6F5tmm8AS54Re2o3Pyp4pTiT6+zdlOJcfMbk=; b=iMtXxQKu4JgplokUir2dhHC7o1lyg70GslKoON/BL9g0OqUEQxMALrl0Cu7BGc+Xg/vvLH OzNzB2XT30c4kJnxz6BA9kR8HEa6H/E7yXXHl/yVmlyVv9sXa34GU+S8mqTyAs8+g8R3/i +T5yV8JeATTbTRx/sdds/XpHaZ53cVU= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-282-q3AaKOdwNey05WLHfG21Ng-1; Sun, 06 Oct 2019 11:12:35 -0400 Received: by mail-ed1-f70.google.com with SMTP id c23so7347241edb.14 for ; Sun, 06 Oct 2019 08:12:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=BuDpUhvI7aRpTgMipmKvy1072necfiHV1oVcWtdfdWk=; b=cOJj7BykXk0HasjyAW9adBzcULC+8wfGpDVT46f0Gj342Jp27uEsrT/00VA6QlGiGB qxYHas/9TGAX9I3xhFQnYXQDwAs/r/mHVgOqeswfiAQK0Xm1DTd9FZZPK3RDplnwh8UF AXoatcTYTAima1DTkNEEszAHTwqwFsGLdlQcV2qbA0dybqBzen+Zf2mOLcWC7Fc9X6Bv SJ+XhdVHCkx4V5qzSkubw/SkvUFnp1f5xcJTBcz1BrZloSumqymzHLCl47iUU0qBCgE8 IrteXS0waq7RbBg0PH2N9parUdno74czjYp2n10wltIJOKGKTnsHaa+qxPcyvrAKheRj ariQ== X-Gm-Message-State: APjAAAXKjiwNQl7RWCuIzL3tPYsMOnB/EYAsJftkfiWmuK1LBjP3IUnJ Kllb9Sy2rNbnXKdBkha/4dapUJMS8MvTiNIPBn/LOQw1ZeMRxHm47Rp0+BovZYLO/rypVZm2G29 pPZ003IT6M+bMnj4AacDGZtFM X-Received: by 2002:a50:d5c5:: with SMTP id g5mr25262077edj.57.1570374753789; Sun, 06 Oct 2019 08:12:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8xuAN6JoJIhDgzdot8v327ojmhlD04wuzq2pbA3tEuFPmtIbMqOD0YWQ9GkC5Sgd5GtB9dw== X-Received: by 2002:a50:d5c5:: with SMTP id g5mr25262061edj.57.1570374753598; Sun, 06 Oct 2019 08:12:33 -0700 (PDT) Received: from localhost.localdomain ([109.38.129.160]) by smtp.gmail.com with ESMTPSA id n10sm168731ejr.82.2019.10.06.08.12.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 06 Oct 2019 08:12:32 -0700 (PDT) Subject: Re: [PATCH] hwmon: abituguru: make array probe_order static, makes object smaller To: Colin King , Jean Delvare , Guenter Roeck , linux-hwmon@vger.kernel.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org References: <20191006145231.24022-1-colin.king@canonical.com> From: Hans de Goede Message-ID: <1f7b29da-27f4-8dbb-c18b-e6cdc094d1dc@redhat.com> Date: Sun, 6 Oct 2019 17:12:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191006145231.24022-1-colin.king@canonical.com> Content-Language: en-US X-MC-Unique: q3AaKOdwNey05WLHfG21Ng-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/6/19 4:52 PM, Colin King wrote: > From: Colin Ian King >=20 > Don't populate the array probe_order on the stack but instead make it > static. Makes the object code smaller by 94 bytes. >=20 > Before: > text=09 data=09 bss=09 dec=09 hex=09filename > 41473=09 13448=09 320=09 55241=09 d7c9=09drivers/hwmon/abitugur= u.o >=20 > After: > text=09 data=09 bss=09 dec=09 hex=09filename > 41315=09 13512=09 320=09 55147=09 d76b=09drivers/hwmon/abitugur= u.o >=20 > (gcc version 9.2.1, amd64) >=20 > Signed-off-by: Colin Ian King Looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/hwmon/abituguru.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/hwmon/abituguru.c b/drivers/hwmon/abituguru.c > index a5cf6b2a6e49..681f0623868f 100644 > --- a/drivers/hwmon/abituguru.c > +++ b/drivers/hwmon/abituguru.c > @@ -1264,7 +1264,7 @@ static int abituguru_probe(struct platform_device *= pdev) > =09 * El weirdo probe order, to keep the sysfs order identical to the > =09 * BIOS and window-appliction listing order. > =09 */ > -=09const u8 probe_order[ABIT_UGURU_MAX_BANK1_SENSORS] =3D { > +=09static const u8 probe_order[ABIT_UGURU_MAX_BANK1_SENSORS] =3D { > =09=090x00, 0x01, 0x03, 0x04, 0x0A, 0x08, 0x0E, 0x02, > =09=090x09, 0x06, 0x05, 0x0B, 0x0F, 0x0D, 0x07, 0x0C }; > =20 >=20