From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6893AAF65 for ; Fri, 31 Jul 2026 08:48:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785487739; cv=none; b=PI0RjHsXMAJtRUyGUKbq/1FuTlTp1VY6ZS8bumqGOnNCTlD2vR044Vgs9Cz1UjsOg6gtkwicltDocJ4vTWBh27x3u8t6B9QmpGcY60+MLGRc4gVQMtQ4QpWIUxb6ju/vzusR5nGc1ygKzVObxzYdLq4zWN9zpSWDR4juZZKvyyk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785487739; c=relaxed/simple; bh=yqVzdwQIdhlxVwRNjZYeO0qa1Ah/nRrtlZwReCGfUGA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=R8uGaZjQ5auZYjAePQoFXLHWQh/9+a5Gcva2wURxTIm2Io6YaiugtZUHrDvf6jDu+9D5VfpGaaO6a0eirQfnT4xG4dAmdIvbsVCZJMAOwDWX89ms+RDRO4C9tILMWnelp7RTk2QtT9ojVwMzv33iwLQ1B6vZDpi9IZyW3mhXwfs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GCupiym0; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=b3f2i4jT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GCupiym0"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="b3f2i4jT" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V8ZpVc3675591 for ; Fri, 31 Jul 2026 08:48:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YuohLgv2ewEMxWehRE3OJp4yXClrJcRe5nvz3u5mbkw=; b=GCupiym08Ro3L1vA y+aaawzkdT4YtUjsdKw//xK+zyCA1AkSObg0w9XN0wUNmMEWDQP9/oZDf0iJ1Cuy Zn4Yx7QtqnUrgR5giYckvAUAQ4NAQoAgrQylpScr/AVP98+iqDOa+XcLo4J1/czG kYbLxI6lyXXRnlF1n0/GHQEdcnnqgjoTTBsTLpMs3GvzeqaoO3sRXIY4UUZk73OT q7j5niPs8vMk//XFItZKxz9+ltNe3QQU9bNw3yCbCBVVcCmoj5qLEfv6hFt1Bz+E pMiJBaE6aXuz2MZ6mYH54QIg2whu3932+YubrUCfNDhSSfqNQgVaBCwkNgedNS7n mATsdg== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frrb781n9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 08:48:54 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2cacd6d37edso9557025ad.0 for ; Fri, 31 Jul 2026 01:48:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785487733; x=1786092533; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to:content-type; bh=YuohLgv2ewEMxWehRE3OJp4yXClrJcRe5nvz3u5mbkw=; b=b3f2i4jTV3KtPNhMJUy3MiNao9+gOi36S3ZP123FMbnssCO+Bcsd482Yoz0DFoz5kP GRQ/237F2cbjPIO38EwrL/aL9tua3T634BIc9WonevDuQSCHkGIHPUO1VBEcqFZOi5Gw UYMfzB0J74vgSG3Y3Uzi/JWrLDp4iwvGHHGispAkrir9wYOmTKaRzlZWE4oiSRwwbZkn 8CNRBdHij/6zJZhoEWqEJiDZWFsZNZmh7uRMToRmch9mD5Lal0h42l4eXE8k9RyunyxO ar6nNO7inCL/XywoYLgEHqGjFgWV+qihpDyWj5MboIwYzg2+e97496sMXq/QVBKzIiCP b9Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785487733; x=1786092533; h=content-transfer-encoding:content-type:in-reply-to:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YuohLgv2ewEMxWehRE3OJp4yXClrJcRe5nvz3u5mbkw=; b=K3QSb6ciKPqo3wJALVsJe+SK8uQCZZtG9QvVxiJMzTWmPGx+FCPa5cRFmAjX2VxccP vAT4mMhIiq7GOMJRziA61L0LnhqMgzNxDvdi+Hvo2lfmTe6va0oj2v2EbYXglzbeQ+88 QjCsrM9te06gThYukvbYKKolIadw4OAwAh/873w0YC9XzCiU5GprksHLhtGMYNbG5dPA rIWgXTzLv8PLm+N5vSsu8xa5fMNHHaoC8/0hB4qGb7ZIypP3xdoAzEhiTeC2aIlD10lp KJsxZuBUb4NYfn2UywSkO+z4oiz44XruZ1i60ROak2KtKrqSR30NiUTzPZZFRF4nF4JY lNGw== X-Forwarded-Encrypted: i=1; AHgh+RrptIEt7nBWt/dSZjBlWw77H+9H/nb8pID0Sd5EQyuVCfkfxFeQJ9Pqvv8DMOO6tCNgWMxIglizayt29S0=@vger.kernel.org X-Gm-Message-State: AOJu0YwlN5Mp8k+XS5saS6LlCuhIb2dYSgtFWGT6mzgWJd9EVaHtCsKw 1fEOLmos5z+DSszVOZrOvAZw8nybXmyEZ30y1cK0ibbsHR4qNFYBGaiL2jJJkeAMn/tPREWn+kF 2nvJVe6EtQTnNzTHKBtMt8DB7bghsBEx7//5fSkh7UyITDQLkllu8y/2ykTJDGOKcWzI= X-Gm-Gg: AR+sD13rFDluMfVtHX4ybD0IyaLvkiAykUCdZ573uW1fpOc4hw5Tsz8Tc8i215VL6MW /IsJiaBoQUJ6OjGyF9QkV6jhbCjME+pYaad4fxCATGdfghWEBeJMlYaXOt6MOaCdqX7OXLkbHvN P/7+VmIKFIyt/d1zeKG4QQ5wOnqP4OS30XfLmNgnFNoXw//L49f/YKFf3xWG5Fj8ReI+/x6HGbV 2NHzTJljSy9dVE0zmhTcMd6DqrdZwuxaNG+w/xti9NLY/dDRuS2/YmT+hkNISv4MNIdwQBZ1wXA 0+MwVfwIGGRuoA3K6EDP6FD6f2NWjcL9Q87Im+s4TzSd3P4Rz+PxVua1ntKB6mY0tpo+2/MOKwL +hUbwqwkX45wj9xlmxLl5ZahEnEYJB7W2xF91co/Drpl/PxJ5oofclzpYdc8nBTAifIM/G7BNXQ == X-Received: by 2002:a17:903:2f4c:b0:2be:3850:297e with SMTP id d9443c01a7336-2d046e7db1emr13839435ad.31.1785487732763; Fri, 31 Jul 2026 01:48:52 -0700 (PDT) X-Received: by 2002:a17:903:2f4c:b0:2be:3850:297e with SMTP id d9443c01a7336-2d046e7db1emr13839105ad.31.1785487732202; Fri, 31 Jul 2026 01:48:52 -0700 (PDT) Received: from [10.133.33.123] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2d04ae68cf7sm2700115ad.31.2026.07.31.01.48.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 01:48:51 -0700 (PDT) Message-ID: <1f80cdf0-2ca8-4b28-9192-b42bd61abff1@oss.qualcomm.com> Date: Fri, 31 Jul 2026 16:48:48 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/5] wifi: ath12k: skip connection_loss_work for MLO beacon miss To: Jose Ignacio Tornos Martinez , jjohnson@kernel.org Cc: ath11k@lists.infradead.org, ath12k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260727162748.963275-1-jtornosm@redhat.com> <20260727162748.963275-6-jtornosm@redhat.com> From: Baochen Qiang Content-Language: en-US In-Reply-To: <20260727162748.963275-6-jtornosm@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=I7hVgtgg c=1 sm=1 tr=0 ts=6a6c6178 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=20KFwNOVAAAA:8 a=Mojy9TJRF7p0t743WAkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA2MyBTYWx0ZWRfXzNx4l0m2o1hF NuXveSH6RVsL52rWie0suCJKOgHyWwnrRfxgcND56ghUJ3J6CgXOuzvles/ZltO5rQr55HuExeo DHlCjqDRwI9pWdhS1Ig3aqtiZ1DwNi/g7kaRHFLhxhnR5gukVmpipERMNcm+motiet3qZEGGSTm G4R5QOiWJ/dgNAiex6rC+6iBwTYXPDSWyPW0/O4nC3fJJ5ek5uBWxqn9jeLw/i6V4Us5pJTffUa xAzvCpjdWg4tPuL88quXIAV1auvW0kJIMWaiEdiSwjepJy2vGID+1OH7uMhN4rcLdBOqYAPtrtw Prdm7vdPG2eyM+leHFmR6frSDH5HNCR7Dl56saZUCGsTXjc0PwDnS2JFqEoM01nd9Rv+ik2f/5a swouIGyAhVH7rTA+oN8lmlgAruxqUHe9Qd56XChD87PCfUUfnACRBna8SD0ZPxQraD9/PqTI54j voJDHGlPVTzwKpN+t2Q== X-Proofpoint-GUID: 7mE7K_6hZPwgz3vCxPPNieQhXMYgsWhY X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA2MyBTYWx0ZWRfX3caxisDE7Phd OKLd6BNIBPxXIPKMVWGRbGDrtkMwkqPjvalvEgK93PMj3dlBZrYoeceBHpWMd7fzYShOHmSp+1n c3YpqCgU57VnfdclvSwruU4Gxvy93Z8= X-Proofpoint-ORIG-GUID: 7mE7K_6hZPwgz3vCxPPNieQhXMYgsWhY X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 bulkscore=0 spamscore=0 impostorscore=0 phishscore=0 malwarescore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310063 On 7/28/2026 12:27 AM, Jose Ignacio Tornos Martinez wrote: > When firmware reports a beacon miss, ath12k queues connection_loss_work > as a 3-second backup timer that forces a full VIF disconnect via > ieee80211_connection_loss(). This work can only be cancelled when a > beacon frame arrives through WMI in ath12k_mac_handle_beacon_iter(). > > In MLO, this mechanism causes periodic spurious disconnections because > the firmware does not reliably forward beacon frames to the host via > WMI, making the cancellation path ineffective. The result is a full > VIF disconnect every ~16 seconds during normal MLO operation, easily > reproducible under heavy traffic. > > Skip queueing connection_loss_work for MLO VIFs. The mac80211 AP probe > triggered by ieee80211_beacon_loss() is sufficient to detect real AP > unreachability. Other MLO-capable drivers such as mt76 and rtw89 > similarly rely on ieee80211_beacon_loss() without adding a backup > disconnect timer. > > Tested on WCN7850 with MLO (Wi-Fi 7). > > Signed-off-by: Jose Ignacio Tornos Martinez > --- > drivers/net/wireless/ath/ath12k/mac.c | 11 +++++++++-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c > index af09153ad9d9..dfd69822c5ce 100644 > --- a/drivers/net/wireless/ath/ath12k/mac.c > +++ b/drivers/net/wireless/ath/ath12k/mac.c > @@ -2008,9 +2008,16 @@ void ath12k_mac_handle_beacon_miss(struct ath12k *ar, > * (done by mac80211) succeeds but beacons do not resume then it > * doesn't make sense to continue operation. Queue connection loss work > * which can be cancelled when beacon is received. > + * > + * Skip for MLO because connection_loss_work disconnects the entire > + * VIF based on a single link's beacon miss, and its cancellation > + * mechanism (beacon reception via WMI) is unreliable. The mac80211 > + * probe triggered by ieee80211_beacon_loss() above is sufficient > + * to detect real AP unreachability. > */ > - ieee80211_queue_delayed_work(hw, &arvif->connection_loss_work, > - ATH12K_CONNECTION_LOSS_HZ); > + if (!ieee80211_vif_is_mld(vif)) > + ieee80211_queue_delayed_work(hw, &arvif->connection_loss_work, > + ATH12K_CONNECTION_LOSS_HZ); with this, patch 4/5's MLO branch is never reachable > } > > static void ath12k_mac_vif_sta_connection_loss_work(struct work_struct *work)