From: Suman Anna <s-anna@ti.com>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Santosh Shilimkar <ssantosh@kernel.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-arm-msm@vger.kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>,
Dave Gerlach <d-gerlach@ti.com>
Subject: Re: [PATCH 1/2] soc: ti: Use remoteproc auto_boot feature
Date: Fri, 23 Dec 2016 11:05:58 -0600 [thread overview]
Message-ID: <1f847af8-6bde-4645-aea4-7e9b02306e39@ti.com> (raw)
In-Reply-To: <9092e066-b2ad-ee42-de5f-d66b84a10cfd@codeaurora.org>
Hi Sarang,
>>
>> On 12/15/2016 06:03 PM, Sarangdhar Joshi wrote:
>>> The function wkup_m3_rproc_boot_thread waits for asynchronous
>>> firmware loading to complete successfully before calling
>>> rproc_boot(). The same can be achieved by just setting
>>> rproc->auto_boot flag. Change this. As a result this change
>>> removes wkup_m3_rproc_boot_thread and moves m3_ipc->sync_complete
>>> initialization to the wkup_m3_ipc_probe().
>>>
>>> Other than the current usage, the firmware_loading_complete is
>>> only used in rproc_del() where it's no longer needed. This
>>> change is in preparation for removing firmware_loading_complete
>>> completely.
>>
>> Based on the comments so far, I am assuming that you are dropping this
>> series.
>
> No, may not be dropping this. Will try to handle it differently in
> rproc_del() (probably by making use of some state flag).
>>
>> In any case, this series did break our PM stack. We definitely don't
>> want to auto-boot the wkup_m3_rproc device, that responsibility will
>> need to stay with the wkup_m3_ipc driver.
>
> Which scenario did it break? Booting up rproc device before
> wkup_m3_ipc_probe() causes issues?
Yes, our state machine requires the wkup_m3_ipc driver to control the
boot of the wkup_m3 remoteproc. The wkup_m3 is not a typical remoteproc,
it is our PM master and is responsible for putting the host processor
into suspend and waking it up in system suspend/cpuidle paths.
The remoteproc infrastructure is only used for load/boot, but the Linux
PM state machine and communication is all controlled by the wkup_m3_ipc
driver.
>
> Nevertheless, I think Bjorn's suggestion of just dropping the call to
> wait_for_completion() and keeping kthread looks good, also because of
> the fact that rproc_boot() anyways calls request_firmware() and no
> longer needed to wait on asynchronous loading of firmware.
Yeah, I will have to test this, but looking at current code, this should
mostly be ok because of the remoteproc core changes w.r.t resource table
parsing.
regards
Suman
next prev parent reply other threads:[~2016-12-23 17:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 0:03 Sarangdhar Joshi
2016-12-16 0:03 ` [PATCH 2/2] remoteproc: Remove firmware_loading_complete Sarangdhar Joshi
2016-12-16 8:26 ` loic pallardy
2016-12-16 19:28 ` Bjorn Andersson
2016-12-17 2:41 ` Sarangdhar Joshi
2016-12-22 3:16 ` [PATCH 1/2] soc: ti: Use remoteproc auto_boot feature Suman Anna
2016-12-22 13:02 ` Bjorn Andersson
2016-12-23 0:07 ` Sarangdhar Joshi
2016-12-23 16:55 ` Suman Anna
2016-12-23 0:01 ` Sarangdhar Joshi
2016-12-23 17:05 ` Suman Anna [this message]
2016-12-23 23:57 ` Suman Anna
2017-01-03 23:52 ` Sarangdhar Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f847af8-6bde-4645-aea4-7e9b02306e39@ti.com \
--to=s-anna@ti.com \
--cc=bjorn.andersson@linaro.org \
--cc=d-gerlach@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sboyd@codeaurora.org \
--cc=spjoshi@codeaurora.org \
--cc=ssantosh@kernel.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®