mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
	Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	linux-nvme@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvmet-auth: select the intended CRYPTO_DH_RFC7919_GROUPS
Date: Wed, 20 Jul 2022 13:39:29 +0200	[thread overview]
Message-ID: <1f8867c6-1bdf-0614-aeed-d39e328fda82@suse.de> (raw)
In-Reply-To: <20220720113717.31854-1-lukas.bulwahn@gmail.com>

On 7/20/22 13:37, Lukas Bulwahn wrote:
> Commit 71ebe3842ebe ("nvmet-auth: Diffie-Hellman key exchange support")
> intends to select 'Support for RFC 7919 FFDHE group parameters' for using
> FFDHE groups for NVMe In-Band Authentication.
> 
> It however selects CRYPTO_DH_GROUPS_RFC7919, instead of the intended
> CRYPTO_DH_RFC7919_GROUPS; notice the swapping of words here.
> 
> Correct the select to the intended config option.
> 
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
> ---
>   drivers/nvme/target/Kconfig | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/target/Kconfig b/drivers/nvme/target/Kconfig
> index f0c91f7686a3..79fc64035ee3 100644
> --- a/drivers/nvme/target/Kconfig
> +++ b/drivers/nvme/target/Kconfig
> @@ -93,7 +93,7 @@ config NVME_TARGET_AUTH
>   	select CRYPTO_SHA256
>   	select CRYPTO_SHA512
>   	select CRYPTO_DH
> -	select CRYPTO_DH_GROUPS_RFC7919
> +	select CRYPTO_DH_RFC7919_GROUPS
>   	help
>   	  This enables support for NVMe over Fabrics In-band Authentication
>   
Reviewed-by: Hannes Reinecke <hare@suse.de>

Cheers,

Hannes

  reply	other threads:[~2022-07-20 11:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 11:37 Lukas Bulwahn
2022-07-20 11:39 ` Hannes Reinecke [this message]
2022-07-21  5:41 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f8867c6-1bdf-0614-aeed-d39e328fda82@suse.de \
    --to=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kch@nvidia.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=lukas.bulwahn@gmail.com \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®