From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3F390381B17 for ; Thu, 21 May 2026 10:21:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358870; cv=none; b=ViyxBfgVVWMRX6BqRPFpZhoX0nJHnB3oiQYtL28WeEDTXXqRyimd8olCpq5FiYcukIT7W6B5cfKj8XwntYymv6pabKe40WTpxvtN2MpV/22M1tt165QC7zYZmmokRt33J7EyNWY6jLrnpC9soHUFRJS6/0POezqVWkRkrQmao+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779358870; c=relaxed/simple; bh=GlKwVxIKRPrLXP2M5NJL6ousDoY1C7FVqTiZqRGfsfs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=K8LVzY10M3Vpj6C645r5T6rgwjmMA50kyq+Rq6Bho384HAUT7/rwBKN5v8H2Mgb6dc50zf6bCZR3iUpkdjKBarY7NwUP1qLKIV3HSIQlIbCRtE/SlRXS0pToTbjlDEAdNwDCQVWHZeE8DS+DRs8wvUNDzUjL2Di5S2rAmF947rY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=gVbyJk9Z; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZCyHGeaS; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="gVbyJk9Z"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZCyHGeaS" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64L99kGp3527330 for ; Thu, 21 May 2026 10:21:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= E8AgKI2FPi0wA1YJ7p7PafK1iciweieJGNbDfdWAWDs=; b=gVbyJk9Z9D3fPJva DVBd6GaFTX8IPKEAEAXQ2Q3gNWF6QF5AMvP4ZL3G6ovlJBzsTu0TcY1ju+Rqe7X2 tNoDNHq6G7w6RSbWC7c0LZifV6pMwKmXbBgidAqIrAXChCJCyBHdB3saUSRil3yf QyLRsLoXYAX+Z5G3+N2NXhKOE9B+dB9Ccv7mSCJ8OZN7p1dJoahWbs7/U7skzQ3a QCTZ7wSGY1UqiMd6q+3YuG8ffA+r2WWCme6yb7iQ4fM432g5tPwZ6Hfwgjk9ukmL wmLPdPW1nR3zkPd88jFv3zO9+Zzlc53L4hSpDz5Hlgbv6uSSp+CNPm5efngfzxM1 JLRqpA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e9vhbh2p1-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 21 May 2026 10:21:07 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-90f5edb7516so137717285a.3 for ; Thu, 21 May 2026 03:21:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1779358866; x=1779963666; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E8AgKI2FPi0wA1YJ7p7PafK1iciweieJGNbDfdWAWDs=; b=ZCyHGeaSHtN/GPuaIqbdL66UGMbsURjzWKRsKL7Jepm5JB/m3CCpzqONObf2ig6tlz q2W6pzCn4CM4oTxIllLuIHb2KrqPQa8+dSozwHda7dE68FdYUG1RpYeCF9WSUElJcTKG W3m0BFhkWxXUn4bH9i3vk5H4zLe07KDD4Ok77e8dRrKT76tbTfkoEM0RAsg1SZGOND9s +sWtz4qJcWRTGAzqDlywEa5xS9yiBlzCZ7ChRASld+GgbfDFPpqrnwHR/avLUmKFh2Gp n5Z9u/QSdo1zwAJPHkQzB+kC/TrzHLFgGvJv5VECkgiFb5YLwSwtx1XgsbVjaGrGtuEy 3WjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779358866; x=1779963666; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E8AgKI2FPi0wA1YJ7p7PafK1iciweieJGNbDfdWAWDs=; b=Gb4V8ieuDnJow4d0i9Dspj19xPSOBusmv2IKCuaXRFevd/WViC3ldAGY+q4nZtU6o0 c7VMCHJJJDJBJhM8Twcl555xfi5S/GTf0Lxoq30trzie7gJmf6qaFyt3SPKqarhaWclb Ow6h97UJL+7mq3c8LolqIUoNoXOKUrTXOh4xEyYAcYGNB/1kv7ja0dnnKuBu/PxyGJFl KGsxd5lgB1y3bo+P03PKsdbJXt8ZEJ8/tejz4QpIvW4W3ioHwNYO6/MzRqm+bsFSSdGo sDfE3wuqf1UQ/SQ0BLWbAvKyV7hkrJ/8f68Bj4xRpDXIH5IIISyQ+icmAcL8NCjgwhRO KLXQ== X-Forwarded-Encrypted: i=1; AFNElJ8QQAU4pYNG0v/DDI+E3HIq2cXCHFsHLV33D1JBWifqsMAt/+nyut4wkbqy9jRYnvwsBMdMI4IJAVz17dQ=@vger.kernel.org X-Gm-Message-State: AOJu0YzTDLKiGFDQdXSm8p/mg+4k66lVfkNvHs7TmHu0W5W3LGVaRxKK pmz0SkNmk6RB/vSqJBt8N5O48K8J9hVBqUiKVP5DLFiG4Wza2OkrHh598Z/okx/fjGud8FbHhvL nnAV7G8NL5Unx6CJMC+cR6HVkIr2MdpTvu/VxzqnusOSYkM8szl8ObzpMfGfQegxTfiQ= X-Gm-Gg: Acq92OGJeOxrjHS9/eu9evhBWeiaOGXW389XRrII3QJ+cU5vyHxZphcubaHUsOR7uTZ f16uaCB0IDTUb+Mlu29xk98alQveCaQpgiqMhAy2fcnYSMcBfa+U+N65shAt8M1uIuq8AJS8/MI LULXvDdFGykmIcILpJ+HfpeyFGqtOv0Ib4u6UhOcOVHT+vtMgZMzMcRul4OM+X5MXbWYxqWFTib 7THqrgxrjJr2KnCmfJxd3DabN5jN0wHf10OigfUd4uYrhdtYrvhnzEM33G32MFzwu2u6oVMounJ Rkc/azND/yyRTsMGSgO4Nk62LzsVwMdsjF2Efr5dMzxLggzP2mclOV0b/g9hxQygOvByAXmy79i 3QjPjAcENgu+vOJYyViPJt4hJF7T1timXhbJ1DGt40M2pJH8Ij/et+E42xZihlv2r7PQABEZtUZ PCBTk= X-Received: by 2002:a05:620a:44c1:b0:913:b4b9:5ec8 with SMTP id af79cd13be357-914a2d26193mr164013985a.6.1779358866574; Thu, 21 May 2026 03:21:06 -0700 (PDT) X-Received: by 2002:a05:620a:44c1:b0:913:b4b9:5ec8 with SMTP id af79cd13be357-914a2d26193mr164011885a.6.1779358866118; Thu, 21 May 2026 03:21:06 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bdc8a4101c1sm27619166b.35.2026.05.21.03.21.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 May 2026 03:21:05 -0700 (PDT) Message-ID: <1f8f46c7-8332-44ee-992e-0b9ca1c0ffef@oss.qualcomm.com> Date: Thu, 21 May 2026 12:21:03 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/4] firmware: qcom: scm: Add minidump SRAM support To: Mukesh Ojha , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Robert Marko , Guru Das Srinagesh Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260519171442.1582987-1-mukesh.ojha@oss.qualcomm.com> <20260519171442.1582987-4-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260519171442.1582987-4-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTIxMDEwMiBTYWx0ZWRfX2CNkVqtXHl5N 3rT2fbm7WWXgfrpUTBbKUa8RSQOnr7QR94rKQKttIpSOXgooJ8mWm50xz6QMhVe9sJejPNFCxW2 8BhSWLCXkmPdvgiSRtwmTP3IKMjXFkghSdsWgRicSLTwMpOqVu0LsgZBBUpKbAgtz8U56+qlKna PQY2vn7/2Fc0EsrkpLO54bWNs4Dfv6oiqCfTeJZhq1b5wlu4iKjZe9Pgw+aK5ekKh6/PRcpbPS2 O2qrX2p9FeoFbm2cfdmR09oz7pS9TIXT4aqV/YP1aZFkyeuheMbzVt0IAnHHI9QCXUH/gcgrwb0 hi9yFAMDLMxezXJva2C55B3g9wW3OkIRKzv3bCy+qhZ34BwCSLVCUtXic1eMEiJWFoiC/lE4QdM sWgxVcgjMoWq1r+TVHrNxNkZelwcbrmXT2V+IQp3y57TOkqOiaTzx3u+3htlldTIwTFyE28FJJq xQakai/zxL8ms8ij/iw== X-Authority-Analysis: v=2.4 cv=GYAnWwXL c=1 sm=1 tr=0 ts=6a0edc93 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=y6rW8TDjuTIuaxCCkQgA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-GUID: f3VCSd_kXfgLrDaWIBiylWTbgWpLmNuu X-Proofpoint-ORIG-GUID: f3VCSd_kXfgLrDaWIBiylWTbgWpLmNuu X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-21_01,2026-05-18_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605210102 On 5/19/26 7:14 PM, Mukesh Ojha wrote: > On most Qualcomm SoCs where minidump is supported, a word in always-on > SRAM is shared between the kernel and boot firmware. Before DDR is > initialised on the warm reset following a crash, firmware reads this > word to decide if minidump is enabled and collect a minidump and where > to deliver it (USB upload to a host, or save to local storage). > > The SRAM region is described by a 'sram' phandle on the SCM DT node. > If the property is absent the feature is silently disabled, keeping > existing SoCs unaffected. > > Expose a 'minidump_dest' module parameter (default: usb) so the user can > select the destination. Only the string names "usb" or "storage" are > accepted; an invalid value is rejected with -EINVAL. Changing the > destination while minidump mode is already active updates SRAM immediately. > > Signed-off-by: Mukesh Ojha > --- [...] > +static int qcom_scm_map_minidump_sram(struct device *dev, void __iomem **out) > +{ > + struct device_node *np = dev->of_node; > + struct device_node *sram_np; > + struct resource res; > + int ret; > + > + if (!of_property_present(np, "sram")) > + return 0; I think of_parse_phandle() calls this indirectly already > + > + sram_np = of_parse_phandle(np, "sram", 0); > + if (!sram_np) > + return -EINVAL; > + > + ret = of_address_to_resource(sram_np, 0, &res); > + of_node_put(sram_np); > + if (ret) > + return ret; > + > + if (resource_size(&res) < sizeof(u32)) { > + dev_err(dev, "minidump SRAM region too small\n"); > + return -EINVAL; I don't know if this is possible in practice Konrad