From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9D08C433B4 for ; Tue, 11 May 2021 08:40:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D1C4613AF for ; Tue, 11 May 2021 08:40:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230518AbhEKIl2 (ORCPT ); Tue, 11 May 2021 04:41:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229995AbhEKIlZ (ORCPT ); Tue, 11 May 2021 04:41:25 -0400 Received: from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com [IPv6:2a00:1450:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 860BDC061574; Tue, 11 May 2021 01:40:18 -0700 (PDT) Received: by mail-wr1-x42b.google.com with SMTP id s8so19254212wrw.10; Tue, 11 May 2021 01:40:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8P8YUXV3r09GjsOJAGpWzwWQ5lBClxrJsUsHflmR2xo=; b=mgnOS45VL1Yx9S7uYp5mwYv5ODZAnRHFdlMb2+hrv/poajlBb6dNbpsxZhsPt553FQ IhzRFrYF4P9x2rO0lYEAd8BIceEo90NYhQ+XuT+e0MKspurfyKzYjclLSxIJ6M4JPjiZ +uEErshLiue6pcNllcIHF/gcLzJitGEXSv0+hOskks5rLeeSQ4nIIrvulcUFZLYTPZEC 4iR+6eVufZmo0101C+GEZHbZIJxuVZpQcjlAvyxjV34VMIRWbiaN2XFKg8Xcm+dfEhBu ZurFMiStU7rGZiW8WYf5WNRzQ8qrJ91EGqCKqRgi4rHyxJgYWIXam6375DVgs0KcwBOU mGBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8P8YUXV3r09GjsOJAGpWzwWQ5lBClxrJsUsHflmR2xo=; b=mafMTiPQ6ahv205r5DRsjoo7lTyaqYQPG1ed7G1PgDHP4hLwBq4hfa36x+Lz7IPZ3y BT+GSaJUNImWZqvN8AbYkVKKC0i+tW2DAN1u806HRtW46L7bZsyBvCj3na2kyk6e9f1X brmiKYoJf/pgNR6vEWBNgAHZDnAd4VQZOxTjdyPszYYDlEVPC9hUGA5eDR8lBrcalwft 1W1OUpAxT8iHtz7O4bhr5ZiseRYy37QTdINDx+sWJaEd2NjMVj4rRY3CIO+URxOJAg3g ylS+JXv4fksWlMuH5dcAVWOBd0/7nZ8wD7M7nOULNmL4v93WP5FChEiXYW2CC7u9Yina TElQ== X-Gm-Message-State: AOAM530VxfCdf5baDxx1xMHRA/9RxkzTCey/Yo7bd2vOqrbosttrma4L GzVCFLuiZ4zRpXfv5s28yAKPKnI0BRU= X-Google-Smtp-Source: ABdhPJzY1DEmt2pk+Dq1qbAxjzlR+yzbp4ZE+RLk2SnmOiLw3v5a/i+hx7gpVFHpS765jKLjrBu/bQ== X-Received: by 2002:a5d:6752:: with SMTP id l18mr35447424wrw.422.1620722414857; Tue, 11 May 2021 01:40:14 -0700 (PDT) Received: from [192.168.2.202] (p5487be9d.dip0.t-ipconnect.de. [84.135.190.157]) by smtp.gmail.com with ESMTPSA id y21sm2945643wmi.15.2021.05.11.01.40.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 01:40:14 -0700 (PDT) Subject: Re: [PATCH] usb: xhci: Increase timeout for HC halt To: Greg Kroah-Hartman Cc: Mathias Nyman , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210511002933.1612871-1-luzmaximilian@gmail.com> From: Maximilian Luz Message-ID: <1f912115-b46d-b1b2-54b4-f1b2bcd0ef8a@gmail.com> Date: Tue, 11 May 2021 10:40:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/11/21 8:26 AM, Greg Kroah-Hartman wrote: > On Tue, May 11, 2021 at 02:29:33AM +0200, Maximilian Luz wrote: >> On some devices (specifically the SC8180x based Surface Pro X with >> QCOM04A6) HC halt / xhci_halt() times out during boot. Manually binding >> the xhci-hcd driver at some point later does not exhibit this behavior. >> To work around this, double XHCI_MAX_HALT_USEC, which also resolves this >> issue. >> >> Signed-off-by: Maximilian Luz >> --- >> drivers/usb/host/xhci-ext-caps.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) > > Should this go to stable kernels as well? Ah sorry, didn't think about that since the device in question currently requires a couple of other fixes to be usable. But I guess it would be good to have this in stable. Regards, Max