mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gao Xiang <hsiangkao@linux.alibaba.com>
To: Sandeep Dhavale <dhavale@google.com>
Cc: linux-erofs@lists.ozlabs.org, LKML <linux-kernel@vger.kernel.org>,
	Nathan Huckleberry <nhuck@google.com>,
	Yue Hu <huyue2@coolpad.com>,
	kernel-team@android.com
Subject: Re: [PATCH v5] erofs: add per-cpu threads for decompression as an option
Date: Tue, 28 Feb 2023 13:01:43 +0800	[thread overview]
Message-ID: <1f926a20-6b45-137d-4e78-30025ba33574@linux.alibaba.com> (raw)
In-Reply-To: <CAB=BE-Svf7TMPs-eA+sVuGtYjVWfKd1Nd_AkA9im4Op7TCLW3g@mail.gmail.com>

Hi Sandeep,

On 2023/2/28 12:47, Sandeep Dhavale via Linux-erofs wrote:
> Hi all,
> I completed the tests and the results are consistent with
> our previous observation. We can see that removing WQ_UNBOUND
> helps but the scheduling latency by using high priority per cpu
> kthreads is even lower. Below is the table.
> 
> |---------------------+-------+-------+------+-------|
> | Table               | avg   | med   | min  | max   |
> |---------------------+-------+-------+------+-------|
> | Default erofs       | 19323 | 19758 | 3986 | 35051 |
> |---------------------+-------+-------+------+-------|
> | !WQ_UNBOUND         | 11202 | 10798 | 3493 | 19822 |
> |---------------------+-------+-------+------+-------|
> | hipri pcpu kthreads | 7182  | 7017  | 2463 | 12300 |
> |---------------------+-------+-------+------+-------|

May I ask did it test with different setup since the test results
in the original commit message are:

+-------------------------+-----------+----------------+---------+
|                         | workqueue | kthread_worker |  diff   |
+-------------------------+-----------+----------------+---------+
| Average (us)            |     15253 |           2914 | -80.89% |
| Median (us)             |     14001 |           2912 | -79.20% |
| Minimum (us)            |      3117 |           1027 | -67.05% |
| Maximum (us)            |     30170 |           3805 | -87.39% |
| Standard deviation (us) |      7166 |            359 |         |
+-------------------------+-----------+----------------+---------+

Otherwise it looks good to me for now, hopefully helpful to Android
users.

Thanks,
Gao Xiang

> 
> 
> Thanks,
> Sandeep.

  reply	other threads:[~2023-02-28  5:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-08  9:33 Gao Xiang
2023-02-23 18:29 ` Eric Biggers
2023-02-23 18:52   ` Gao Xiang
2023-02-23 19:08     ` Gao Xiang
2023-02-24  0:13       ` Sandeep Dhavale
2023-02-28  4:47         ` Sandeep Dhavale
2023-02-28  5:01           ` Gao Xiang [this message]
2023-02-28  5:51             ` Sandeep Dhavale
2023-02-28  5:58               ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f926a20-6b45-137d-4e78-30025ba33574@linux.alibaba.com \
    --to=hsiangkao@linux.alibaba.com \
    --cc=dhavale@google.com \
    --cc=huyue2@coolpad.com \
    --cc=kernel-team@android.com \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhuck@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®