From: Jens Axboe <axboe@kernel.dk>
To: Yang Yang <yang.yang@vivo.com>,
Omar Sandoval <osandov@osandov.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: onlyfever@icloud.com
Subject: Re: [PATCH v2] kyber: introduce kyber_depth_updated()
Date: Mon, 22 Feb 2021 12:38:07 -0700 [thread overview]
Message-ID: <1f94990f-2732-547a-09f4-42d5a6ab77d7@kernel.dk> (raw)
In-Reply-To: <20210205091311.129498-1-yang.yang@vivo.com>
On 2/5/21 2:13 AM, Yang Yang wrote:
> Hang occurs when user changes the scheduler queue depth, by writing to
> the 'nr_requests' sysfs file of that device.
>
> The details of the environment that we found the problem are as follows:
> an eMMC block device
> total driver tags: 16
> default queue_depth: 32
> kqd->async_depth initialized in kyber_init_sched() with queue_depth=32
>
> Then we change queue_depth to 256, by writing to the 'nr_requests' sysfs
> file. But kqd->async_depth don't be updated after queue_depth changes.
> Now the value of async depth is too small for queue_depth=256, this may
> cause hang.
>
> This patch introduces kyber_depth_updated(), so that kyber can update
> async depth when queue depth changes.
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-02-22 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 9:13 Yang Yang
2021-02-22 9:49 ` Yang Yang
2021-02-22 19:36 ` Omar Sandoval
2021-02-22 19:38 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f94990f-2732-547a-09f4-42d5a6ab77d7@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=onlyfever@icloud.com \
--cc=osandov@osandov.com \
--cc=yang.yang@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®