From: Jens Axboe <axboe@kernel.dk>
To: Li Jinlin <lijinlin3@huawei.com>, tj@kernel.org
Cc: cgroups@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linfeilong@huawei.com,
louhongxiang@huawei.com
Subject: Re: [PATCH] blk-throttle: fix UAF by deleteing timer in blk_throtl_exit()
Date: Tue, 7 Sep 2021 08:37:06 -0600 [thread overview]
Message-ID: <1f962850-06d6-f50b-2c2f-e6d5bfd3823a@kernel.dk> (raw)
In-Reply-To: <20210907121242.2885564-1-lijinlin3@huawei.com>
On 9/7/21 6:12 AM, Li Jinlin wrote:
> From: Li Jinlin <lijinlin3@huawei.com>
>
> The pending timer has been set up in blk_throtl_init(). However, the
> timer is not deleted in blk_throtl_exit(). This means that the timer
> handler may still be running after freeing the timer, which would
> result in a use-after-free.
>
> Fix by calling del_timer_sync() to delete the timer in blk_throtl_exit().
Applied, thanks.
--
Jens Axboe
prev parent reply other threads:[~2021-09-07 14:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-07 12:12 Li Jinlin
2021-09-07 14:37 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f962850-06d6-f50b-2c2f-e6d5bfd3823a@kernel.dk \
--to=axboe@kernel.dk \
--cc=cgroups@vger.kernel.org \
--cc=lijinlin3@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®