From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F24229E10B for ; Wed, 19 Nov 2025 07:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.125.188.123 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763535896; cv=none; b=IRmm+wKfjBlZrzUKUp3BZDZy6NJRgJSjnYWfPWw6y/7oP4m15tctKu1G3L7daDOPXZTKFnpY1tklkkDamRTa35kVa+YKshHrFtQ1ZQfRJb2+eR1iC2ur6D2Vls/jHOsysUaVfhjcKiS3roKHtKZGK1pnP3Zsha/6PfVxZx11lto= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763535896; c=relaxed/simple; bh=p9MgnD7JWagPo+CZ04Zw2ECvO8+TLxO2KuHDtWJ6mTs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UIeLrVX3RaNVYgpld/3CtzPPjxMpBRWqWsXETpoTNcZjsMMw+p4IC7QQvABOwWplLI4/bp2qJet/aRkcDDAAJKMvQ1ZNd3bxkt6FW54FH8CvOo3KGkeX3BAg3HLDBXhCgG4Vx7eFI2QGr6kI9BHiueqQzQ4C9+59Xwwy9jeV5kI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com; spf=pass smtp.mailfrom=canonical.com; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b=Tki1XztF; arc=none smtp.client-ip=185.125.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=canonical.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=canonical.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (4096-bit key) header.d=canonical.com header.i=@canonical.com header.b="Tki1XztF" Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id DEE333F74E for ; Wed, 19 Nov 2025 07:04:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20251003; t=1763535885; bh=HCDUZaE5+206zSZomo9Fg7tLxJqm77Cnmdl1n2fzVyI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Tki1XztFLwuzoARxvGyH5BNk+yfVC+dsm6BHI1PlcMZ8TGxUSU8yqRcE2vZJGGN/r KJRy+Hdo+B9B2VJ5+ewTs7S7YKnBk2NaXeUyQXqe4yuVuwN7NteMbDoTSaZg9qjqMu Cyh2aL+HJ7FotYgqFLi0CYLpzDoCEtryFo0btz623OBZP1ZtUBsmlq4P0PDsFJfU7d 4i7/bRQU4D0K8ob0T4W9KSpvlzosal+WNeKCIyt5LnXgYOR/s8aLTGD2NO78H8BQQ8 ofoQqFuGUYGUiLJNBBPHKcQs5KTGxY5fmGekJ/VIMMowocygtFAQiwVayyQEqNvwCy uun5a94CpFACntNY/nZavFRe+nIW7uWyIlWaLELpNULZMTeA1F4HiwFFtsfx+c749d UlOOQMpnoi+MpVYoTjyuuM10LEMvtQl/HuoIw3dJ+Tb4Ts9ePEiBrhNE6hG3kiIYbg Z6V39Cl2oHmOTuKBrVfKsTpPc850lmeIYaUQekUZF4ePuP449X4IBjRVQFSLgWxGeR dW6ZoGqZk9bee33iiDawel3D5FknuyLRBzgcixa+D+EE2oyHzFQ/099sbl1qK/D6CB 8sRKXo8kcMDMb5IXyeBkGZ6WMZtf2Md4fjK+/93/bohkPCn+YZEEv3OsXk6TL4gNtr gS6DH6UTxIpcFjDfCqMQZccs= Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-429c521cf2aso5216275f8f.3 for ; Tue, 18 Nov 2025 23:04:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763535885; x=1764140685; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HCDUZaE5+206zSZomo9Fg7tLxJqm77Cnmdl1n2fzVyI=; b=orgL7AEJRd4VVW1qnhlMAqph6FGI9KBfKpa2ZNHoMzYlF1eykwoJyI7+fq9p19RI2a lQDM3hY/TlSp1fbpRVTmAIAgwwhhVtKSBCGGXqqAF18UHPy9zOUOh9IHp/XZa7oqZt3l 0dHsBrhqmddmNOJTY+ILAtc9qzXj4/hRIM73TWklFwRZQuXQmF2GcSAuHiiF8xF7iqFd swxoAnxVk4oxzkFs09j+WfvUIn2nilW8IIM+Hn/Kq0PJJ3+JmzBE4a73ZDDIpttaaGZ7 0B3N1i85hblVDj5HxVIqi2pFjzW5sCGHsILvqQeUncUDucpQSvP0nFzYq5RPECTOG3rM J7Xw== X-Forwarded-Encrypted: i=1; AJvYcCVYbeB+aTY8pJhfKDqPsPZSeB6X14ZOSi/hs9At1DkOX6PA8V50CkQ7txhTXqnMrXOMcBSbz4k7BnkXL14=@vger.kernel.org X-Gm-Message-State: AOJu0Yy/xTbUfv1nnawcfTPziCz0E17WfdEnrvd8cMQ9v2qSkjJcsKNa t6tM2+M+OSTFeGLYzRU+rQ46KTP3a4ald5KPR43aJPl6tbOSvIaWN9eKWgIwNc/0smT9qKx84wY B9nANItqvk5KMDGE5Zp7iSC7l0bsYGGQKbW4/9+I0CSF28CRIA5TwehTlfKdCqEvOSJmcWEDLex fHnNd5fg== X-Gm-Gg: ASbGncvFx8rNRgiOoe0SG3ASng9hSUXo/RcOBHoCRH2h6no38KD00mQApv7uaxstzt/ uXUpZ3sRb4pko2aRDHsuh4FQz+Yd+sM9OJOMkDqnLY0qBVx727P4uYImy+++/LCgEsKG37gQZYQ 0A3T5eCNvUb3G6hOroUUMqr2M0kVQPzz3jmikLegn2/IsLDuv4/TVkUEPYxhVeWcd0dt4Bx3QhN 3hfybDgn+Z9BEpH10iBzfr8DTcCNC7gtR5IwTQqGAIWgOvSmKtI70+nf1oM5POPjHXO4JZQLSu4 7PqjFmZNee3P98CypA7xDjX2koWbhd7gj04BsWWXwTe6yhBtB5iHhwekzSMTkyQfzbqea1CyMz1 W263HWB8xfDA9yepfrt+Dcczp+6q8ACzYgDZhZoSIu7ogSpX4/TfZMIPcqolzWQhRRMcumNhcbO eniZoxaQk= X-Received: by 2002:a5d:64c5:0:b0:42b:47da:c316 with SMTP id ffacd0b85a97d-42b5934afdfmr17476414f8f.26.1763535884656; Tue, 18 Nov 2025 23:04:44 -0800 (PST) X-Google-Smtp-Source: AGHT+IEqVppj0kaC1T4AK8/+ki8hXQuFnAQjHrtuYAj2Vyhso+rWSDHbQHj+3SMP9d2Ef4b6qHHLeA== X-Received: by 2002:a5d:64c5:0:b0:42b:47da:c316 with SMTP id ffacd0b85a97d-42b5934afdfmr17476387f8f.26.1763535884152; Tue, 18 Nov 2025 23:04:44 -0800 (PST) Received: from [192.168.123.154] (ip-005-147-080-091.um06.pools.vodafone-ip.de. [5.147.80.91]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53e85cc0sm37190082f8f.17.2025.11.18.23.04.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 23:04:43 -0800 (PST) Message-ID: <1f96a267-f5c6-498e-a2c4-7a47a73ea7e7@canonical.com> Date: Wed, 19 Nov 2025 08:04:41 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 0/8] Add support for StarFive VisionFive 2 Lite board To: Conor Dooley , Hal Feng Cc: E Shattow , Emil Renner Berthing , Albert Ou , Bjorn Helgaas , Conor Dooley , Krzysztof Kozlowski , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Lorenzo Pieralisi , Manivannan Sadhasivam , Palmer Dabbelt , Paul Walmsley , "Rafael J . Wysocki" , Rob Herring , Viresh Kumar , "devicetree@vger.kernel.org" , "linux-riscv@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20251107095530.114775-1-hal.feng@starfivetech.com> <4a55301a-ef7e-4b47-8151-621cfba36ddd@freeshell.de> <20251118-throwing-marina-14a87d65465a@spud> Content-Language: en-US From: Heinrich Schuchardt In-Reply-To: <20251118-throwing-marina-14a87d65465a@spud> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/19/25 00:10, Conor Dooley wrote: > On Tue, Nov 18, 2025 at 02:12:58AM +0000, Hal Feng wrote: >>> All, >>> >>> I repeat that the suggestion was made months ago (by Hal) to split out the >>> OPP tables per-board from the period of time when I was complaining about >>> 1.5GHz JH-7110 operation pushing TDP into over-temperature thermal limit >>> on Milk-V Mars CM SoM. >>> >>> Whether or not JH7110S is a new compatible should follow precedence in >>> Linux development. JH-7110S is evidently the same tape-out as JH-7110 and >>> however you deal with that in Linux is the appropriate way to deal with that >>> here. Selection of OPP table for correct operation will be determined by >>> bootloader, where, it is demonstrated by patch series sent to U-Boot >>> upstream to be selected ** per-board ** based on EEPROM content as if it >>> was any other JH-7110 board deciding dts based on EEPROM content. Given >>> that it is the same tape-out I do not find a valid justification for a new >>> compatible in the stack of adjacent software besides going along with some >>> kind of marketing-driven answer about whether or not this is a new SoC. >>> >>> What I care about now is that the VisionFive 2 Lite series is in good enough >>> shape and there's a possibility to act on this months-old suggestion to split out >>> the OPP tables which as we have confirmed the JH7110S is the same SoC as >>> JH7110 it makes a lot of sense to do. >>> >>> How is it supposed to work for binned silicon in Linux? >> >> Hi, Conor, Emil, >> >> What do you think about this? Hope to hear from you. > > Can someone just give me a yes/no question out of this thread? I'm not > really immediately sure what's being asked of me. What exactly do you > want to do with the opp-tables? "Split out" isn't super clear. Does that > mean into board files? I am guessing it does, since you're saying that a > particular board cannot support the 1.5 GHz mode. It's not unusual > though to use delete node for unsupported opp-table entries, could that > be done instead? > > FWIW, this weekend is -rc7, so I won't be applying any new material > after that. > There was agreement that the JH7110 and JH7110S need different operating points. This is realized via the different includes for the VisionFive 2 Lite boards and the other boards. Support for the new compatible string "starfive,jh7110s" used by the VisionFive 2 Lite is already implemented in OpenSBI where it is needed for platform support (specifically reboot). It is also used in tag next-20251119 in drivers/cpufreq/cpufreq-dt-platdev.c. There is no technical need to role this back. The changes in OpenSBI and the cpu frequency driver could have been avoided by using compatible = "starfive,visionfive-2-lite-emmc", "starfive,jh7110s", "starfive,jh7110" to indicate that JH7110s is just a variety of JH7110. This also would match the best practice example in Documentation/devicetree/usage-model.rst: compatible = "ti,omap3-beagleboard", "ti,omap3450", "ti,omap3"; I guess we could add that third compatible value in a later patch. As U-Boot uses the Linux device-trees too, I have built U-Boot with the updated device-trees and had no problem to boot all supported JH7110 and JH7110S devices including the StarFive VisionFive 2 Lite. A bootph-pre-ram property for booting from SD-card that was already missing before the series can be added via a separate patch. I think we should go ahead as is. Best regards Heinrich