mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mario Limonciello <mario.limonciello@amd.com>
To: Dhananjay Ugwekar <Dhananjay.Ugwekar@amd.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	gautham.shenoy@amd.com, perry.yuan@amd.com, rafael@kernel.org,
	viresh.kumar@linaro.org
Subject: Re: [PATCH 0/4] cpufreq/amd-pstate:Cleanups
Date: Wed, 23 Oct 2024 08:15:26 -0500	[thread overview]
Message-ID: <1f98dce5-acff-4c3b-8190-8230070fbe7f@amd.com> (raw)
In-Reply-To: <20241023102108.5980-1-Dhananjay.Ugwekar@amd.com>

On 10/23/2024 05:21, Dhananjay Ugwekar wrote:
> Explicitly rename functions that enable CPPC as *_cppc_*.
> 
> Do not clear MSR_AMD_CPPC_ENABLE as it is a set-once register, i.e. it
> cannot be cleared.
> 
> Propagate the epp value to shared mem in the reenable function.
> 
> Replicate the offline flow of MSR based systems in shared mem systems.
> 
> Dhananjay Ugwekar (4):
>    cpufreq/amd-pstate: Rename functions that enable CPPC
>    cpufreq/amd-pstate: Do not attempt to clear MSR_AMD_CPPC_ENABLE
>    cpufreq/amd-pstate: Call cppc_set_epp_perf in the reenable function
>    cpufreq/amd-pstate: Align offline flow of shared memory and MSR based
>      systems
> 
>   drivers/cpufreq/amd-pstate.c | 39 ++++++++++++++++++++++--------------
>   1 file changed, 24 insertions(+), 15 deletions(-)
> 

Thanks!

Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>

      parent reply	other threads:[~2024-10-23 13:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 10:21 Dhananjay Ugwekar
2024-10-23 10:21 ` [PATCH 1/4] cpufreq/amd-pstate: Rename functions that enable CPPC Dhananjay Ugwekar
2024-10-24  4:48   ` Yuan, Perry
2024-10-23 10:21 ` [PATCH 2/4] cpufreq/amd-pstate: Do not attempt to clear MSR_AMD_CPPC_ENABLE Dhananjay Ugwekar
2024-10-25 16:24   ` Gautham R. Shenoy
2024-10-23 10:21 ` [PATCH 3/4] cpufreq/amd-pstate: Call cppc_set_epp_perf in the reenable function Dhananjay Ugwekar
2024-10-24  5:14   ` Yuan, Perry
2024-10-25 16:24   ` Gautham R. Shenoy
2024-10-23 10:21 ` [PATCH 4/4] cpufreq/amd-pstate: Align offline flow of shared memory and MSR based systems Dhananjay Ugwekar
2024-10-25 17:11   ` Gautham R. Shenoy
2024-10-23 13:15 ` Mario Limonciello [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f98dce5-acff-4c3b-8190-8230070fbe7f@amd.com \
    --to=mario.limonciello@amd.com \
    --cc=Dhananjay.Ugwekar@amd.com \
    --cc=gautham.shenoy@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=perry.yuan@amd.com \
    --cc=rafael@kernel.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®