mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Markus Elfring <Markus.Elfring@web.de>
To: Shuhao Fu <sfual@cse.ust.hk>, Steve French <sfrench@samba.org>,
	Steve French <smfrench@gmail.com>,
	linux-cifs@vger.kernel.org, samba-technical@lists.samba.org
Cc: Bharath SM <bharathsm@microsoft.com>,
	Paulo Alcantara <pc@manguebit.org>,
	Ronnie Sahlberg <ronniesahlberg@gmail.com>,
	Shyam Prasad N <sprasad@microsoft.com>,
	Tom Talpey <tom@talpey.com>, LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] smb: client: Fix refcount leak for cifs_sb_tlink
Date: Thu, 16 Oct 2025 09:21:46 +0200	[thread overview]
Message-ID: <1f9e946d-91e3-4f9a-b26c-e69537cbbd4c@web.de> (raw)
In-Reply-To: <aPBeBxTQLeyFl4mx@chcpu18>

> Fix three refcount inconsistency issues related to `cifs_sb_tlink`.

I find such an introduction sentence not so relevant here.


> Comments for `cifs_sb_tlink` state that `cifs_put_tlink()` needs to be 
> called after successful calls to `cifs_sb_tlink()`. Three calls fail to
> update refcount accordingly, leading to possible resource leaks.

* Can it be preferred to refer to the term “reference count”?

* Would you find a description of corresponding case distinctions more helpful?

* May resource leaks be indicated also in the summary phrase?

* Would it be helpful to append parentheses to function names at more places?

* Is there a need to mention change steps more individually?
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17#n94

* Will development interests grow for the application of scope-based resource management?


Regards,
Markus

  parent reply	other threads:[~2025-10-16  7:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-16  2:52 Shuhao Fu
2025-10-16  3:12 ` Steve French
2025-10-16  7:21 ` Markus Elfring [this message]
2025-10-16 16:00   ` Steve French

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1f9e946d-91e3-4f9a-b26c-e69537cbbd4c@web.de \
    --to=markus.elfring@web.de \
    --cc=bharathsm@microsoft.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-cifs@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pc@manguebit.org \
    --cc=ronniesahlberg@gmail.com \
    --cc=samba-technical@lists.samba.org \
    --cc=sfrench@samba.org \
    --cc=sfual@cse.ust.hk \
    --cc=smfrench@gmail.com \
    --cc=sprasad@microsoft.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®