Re: [PATCH v13 0/3] PCI: trace: Add a RAS tracepoint to monitor link speed changes

[Shuai Xue <xueshuai@linux.alibaba.com>]

在 2025/10/25 19:41, Shuai Xue 写道:
> changes since v12:
> - add Reviewed-by tag for PATCH 1 from Steve
> - add Reviewed-by tag for PATCH 1-3 from Ilpo
> - add comments for why use string to define tracepoint per Steve
> - minor doc improvements from Ilpo
> - remove use pci_speed_string to fix PCI dependends which cause build error on sparc64
> 
> changes since v11:
> - rebase to Linux 6.18-rc1 (no functional changes)
> 
> changes since v10:
> - explicitly include header file per Ilpo
> - add comma on any non-terminator entry  per Ilpo
> - compile trace.o under CONFIG_TRACING per Ilpo
> 
> changes since v9:
> - add a documentation about PCI tracepoints per Bjorn
> - create a dedicated drivers/pci/trace.c that always defines the PCI tracepoints per Steve
> - move tracepoint callite into __pcie_update_link_speed() per Lukas and Bjorn
> 
> changes since v8:
> - rewrite commit log from Bjorn
> - move pci_hp_event to a common place (include/trace/events/pci.h) per Ilpo
> - rename hotplug event strings per Bjorn and Lukas
> - add PCIe link tracepoint per Bjorn, Lukas, and Ilpo
> 
> changes since v7:
> - replace the TRACE_INCLUDE_PATH to avoid macro conflict per Steven
> - pick up Reviewed-by from Lukas Wunner
> 
> Hotplug events are critical indicators for analyzing hardware health, and
> surprise link downs can significantly impact system performance and reliability.
> In addition, PCIe link speed degradation directly impacts system performance and
> often indicates hardware issues such as faulty devices, physical layer problems,
> or configuration errors.
> 
> This patch set add PCI hotplug and PCIe link tracepoint to help analyze PCI
> hotplug events and PCIe link speed degradation.
> 
> Shuai Xue (3):
>    PCI: trace: Add a generic RAS tracepoint for hotplug event
>    PCI: trace: Add a RAS tracepoint to monitor link speed changes
>    Documentation: tracing: Add documentation about PCI tracepoints
> 

Hi, Bjorn,

Gentle ping.

Do you have any further concerns about this patch set?

Shuai