From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753680AbdJPPEX (ORCPT ); Mon, 16 Oct 2017 11:04:23 -0400 Received: from mout.web.de ([212.227.17.11]:60223 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753222AbdJPPEU (ORCPT ); Mon, 16 Oct 2017 11:04:20 -0400 Subject: [PATCH 1/4] char/snsc: Adjust one function call together with a variable assignment From: SF Markus Elfring To: kernel-janitors@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman Cc: LKML References: Message-ID: <1fa3d6ea-bd7d-5036-399a-8b9187dccffa@users.sourceforge.net> Date: Mon, 16 Oct 2017 17:04:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:Gppg+KcytIipTvEajo9BPrIvVaderrZbeMHg7BXYJmsYrqw3Qt1 6bpSmMfbIlvJZf5Gsd/ZjoKjiom02A5rteC5CUWa8E7+OYHkhsIZkQxblvQrcSLkqIX3ObC b5O/XXUB209YMXiVdw21HCZoM/ZI+8L8Cd+MBAo/B/CPF/C9RxUC4/e3uMFgiwq1pDGX/bS 1XFPjb2jw8t6Dy38Qgduw== X-UI-Out-Filterresults: notjunk:1;V01:K0:iCXMp4YrZ1A=:OdKN29t83HokRCsqNLFuW3 9i8XSe7LOx0D+j537hRbZ4Cp788AZDRhOH4dj7+FRlmxAtcQtBGSm5rHll/OcIZELsnA57Ks9 TyflYVzG4j41pFYzfICfmnEH4/PrRnSJQhuBBSHv4zG78ZecngHfcHZFnuOUy/vgtjccErU23 Zd2wVyIWtCLFBqZyaw/bYnDyRj4bT/77NpY/bIAnLwNKHVI1iv9trIUo1ldqrV6ryKUbu6Lbj 4CUTSiZ8l9S2uuOrBYv+CnyIu4N2kZ2uvaerjlnDDQehAfe8EAV996527sUMU7X3Ag1sKD+Pr iuGW2iQdjUrlP5i2hfIwiLHsPgXWSd5BrJKmyk7+SCR8ZhxnkwF9kj9aa6UzsKmowTDa6hqwa uOPTMF175iW51259G+kjwNZePdT1GwVuyYt/nPKJGXHXj9O8n5Ge0DcfzSQLX8ZSHj3zGIp69 6fls87EnLvjHmKACndJN1sDcoMqMZl+qTxeWkAKXHUqRFl9qQa4FLySLIvu62/PRDe2FBQYT9 kOaGwK5VVcBhPslAKIyWImaZ/nd3Y2IXdZyGDFfSwa98Ukq5MHEoOpMHNBgobeY+yHJ82vcFL Pz2g+M9PDbYryzjqm1zuVuCBAzaAQNZg/iguduFtDSFb119VCkocKlqd0Of93CmwhooL5SZUD iBGhpbh5dVM5qbEm3Xz2t2/O9HW3PjBRat6CaaNoMSJ1S+lI+4X7fkYdKk8IQsGKC2LbOo2sF qp3l/bb9j8roXecT4VXwMXQbGA3818rYZYyS49yawD0OvAu8OdRdCKtbXkr1+uqG98Dgloxyc W2epsxnJE0CqiFnjjGVOE1NXmD64UmGBLb1hSZBrRypnzbZA6w= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Mon, 16 Oct 2017 16:15:21 +0200 The script "checkpatch.pl" pointed information out like the following. ERROR: do not use assignment in if condition Thus fix the affected source code place. Signed-off-by: Markus Elfring --- drivers/char/snsc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/char/snsc.c b/drivers/char/snsc.c index 6aa32679fd58..f551a625686a 100644 --- a/drivers/char/snsc.c +++ b/drivers/char/snsc.c @@ -419,7 +419,8 @@ scdrv_init(void) /* initialize sysctl device data fields */ scd->scd_nasid = cnodeid_to_nasid(cnode); - if (!(salbuf = kmalloc(SCDRV_BUFSZ, GFP_KERNEL))) { + salbuf = kmalloc(SCDRV_BUFSZ, GFP_KERNEL); + if (!salbuf) { printk("%s: failed to allocate driver buffer" "(%s%s)\n", __func__, SYSCTL_BASENAME, devname); -- 2.14.2