From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938631AbdD0StR (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Apr 2017 14:49:17 -0400
Received: from smtprelay.synopsys.com ([198.182.60.111]:45066 "EHLO
        smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933007AbdD0StL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Apr 2017 14:49:11 -0400
Subject: Re: [alsa-devel] [PATCH] ASoC: dwc: disallow building designware_pcm
 as a module
To: Mark Brown <broonie@kernel.org>, Takashi Iwai <tiwai@suse.de>
References: <20170418151834.c7e5fivmgn73sbwd@sirena.org.uk>
 <1492532010.28092.12.camel@v3.sk>
 <20170418171519.csiftftd434psyn5@sirena.org.uk>
 <2e39b000-bf25-6447-b53b-047401041f4e@synopsys.com>
 <1492618461.28092.18.camel@v3.sk>
 <03a3fbbb-7221-f4ee-5b1b-8fff518ea82c@synopsys.com>
 <20170420194646.qcpu7w3acjyfmeu5@sirena.org.uk>
 <s5h37d2su8h.wl-tiwai@suse.de>
 <376c5933-9321-5399-74c7-6fd4943fab3d@synopsys.com>
 <s5hshl2kpst.wl-tiwai@suse.de>
 <20170421104915.x7gxt5yqcuewa7rv@sirena.org.uk>
CC: Jose Abreu <Jose.Abreu@synopsys.com>, Lubomir Rintel <lkundrak@v3.sk>,
        <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org>,
        Arnd Bergmann <arnd@arndb.de>
From: Jose Abreu <Jose.Abreu@synopsys.com>
Message-ID: <1fa94590-3dbf-922d-4fe7-1a507eec4b32@synopsys.com>
Date: Thu, 27 Apr 2017 19:49:04 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170421104915.x7gxt5yqcuewa7rv@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.107.19.111]
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,


On 21-04-2017 11:49, Mark Brown wrote:
> On Fri, Apr 21, 2017 at 12:39:30PM +0200, Takashi Iwai wrote:
>> Jose Abreu wrote:
>>> Maybe rename to "dwc-i2s.c" and "dwc-pcm.c" (as the folder is
>>> called "dwc") and let the module still be called "designware-i2s"?
>> Lubomir's patch keeps the module name intact.  My point is that rename
>> of a file isn't nice to look at the git commit history, so it's better
>> to be avoided as much as possible.  But in this case, it looks
>> unavoidable.
> Right.  Renaming the source file is the lesser evil, it's possible
> people might have the module name in their configuration for their
> systems somewhere.

I agree. I just noticed today that without a valid license tag we
get unresolved symbols when inserting pcm module so this patch is
really needed as a fix.

Lubomir, could you address the review comments and resend? If you
are not available let me know and I will fix and resend the patch
with your sign-off.

Best regards,
Jose Miguel Abreu