mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Luis Felipe Hernandez <luis.hernandez093@gmail.com>,
	Pavel Pisa <pisa@cmp.felk.cvut.cz>,
	Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Ondrej Ille <ondrej.ille@gmail.com>,
	Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
	linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] docs: Fix kernel-doc error in CAN driver
Date: Tue, 22 Jul 2025 12:22:36 -0700	[thread overview]
Message-ID: <1faa5e2e-6b1b-4fea-9132-8a840357927f@infradead.org> (raw)
In-Reply-To: <20250722035352.21807-1-luis.hernandez093@gmail.com>



On 7/21/25 8:53 PM, Luis Felipe Hernandez wrote:
> Fix kernel-doc formatting issue causing unexpected indentation error
> in ctucanfd driver documentation build. Convert main return values
> to bullet list format while preserving numbered sub-list in order to
> correct indentation error and visual structure in rendered html.
> 
> Signed-off-by: Luis Felipe Hernandez <luis.hernandez093@gmail.com>
> 
> ---
> Changes since v2:
> - Focus only on CAN driver (GPU and I3C already fixed by Bagas Sanjaya)
> - Remove blank line that caused unwanted 'Description' output
> - Keep numbered sub-list format as suggested by Randy Dunlap
> - Move changelog after cutter as suggested by Vincent Mailhol
> 
> Link(v2): https://lore.kernel.org/all/20250720152401.70720-1-luis.hernandez093@gmail.com/
> Link(v1): https://lore.kernel.org/all/20250703023511.82768-1-luis.hernandez093@gmail.com/
> ---
>  drivers/net/can/ctucanfd/ctucanfd_base.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/net/can/ctucanfd/ctucanfd_base.c b/drivers/net/can/ctucanfd/ctucanfd_base.c
> index bf6398772960..8bd3f0fc385c 100644
> --- a/drivers/net/can/ctucanfd/ctucanfd_base.c
> +++ b/drivers/net/can/ctucanfd/ctucanfd_base.c
> @@ -506,11 +506,12 @@ static bool ctucan_is_txt_buf_writable(struct ctucan_priv *priv, u8 buf)
>   * @buf:	TXT Buffer index to which frame is inserted (0-based)
>   * @isfdf:	True - CAN FD Frame, False - CAN 2.0 Frame
>   *
> - * Return: True - Frame inserted successfully
> - *	   False - Frame was not inserted due to one of:
> - *			1. TXT Buffer is not writable (it is in wrong state)
> - *			2. Invalid TXT buffer index
> - *			3. Invalid frame length
> + * Return:
> + * * True - Frame inserted successfully
> + * * False - Frame was not inserted due to one of:
> + *	1. TXT Buffer is not writable (it is in wrong state)
> + *	2. Invalid TXT buffer index
> + *	3. Invalid frame length
>   */
>  static bool ctucan_insert_frame(struct ctucan_priv *priv, const struct canfd_frame *cf, u8 buf,
>  				bool isfdf)

Looks good. Thanks for doing this.

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

-- 
~Randy

      parent reply	other threads:[~2025-07-22 19:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22  3:53 Luis Felipe Hernandez
2025-07-22  4:06 ` Vincent Mailhol
2025-07-22  6:37   ` Pavel Pisa
2025-07-22  7:27     ` Vincent Mailhol
2025-07-22  7:57       ` Pavel Pisa
2025-07-22  8:50         ` Vincent Mailhol
2025-07-22 10:41           ` Marc Kleine-Budde
2025-07-22 19:22 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1faa5e2e-6b1b-4fea-9132-8a840357927f@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis.hernandez093@gmail.com \
    --cc=mailhol.vincent@wanadoo.fr \
    --cc=mkl@pengutronix.de \
    --cc=ondrej.ille@gmail.com \
    --cc=pisa@cmp.felk.cvut.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®