From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752159AbeAZMiq (ORCPT ); Fri, 26 Jan 2018 07:38:46 -0500 Received: from lelnx194.ext.ti.com ([198.47.27.80]:39617 "EHLO lelnx194.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751751AbeAZMio (ORCPT ); Fri, 26 Jan 2018 07:38:44 -0500 Subject: Re: [PATCH v1 2/2] fbdev: Kconfig: Add HAS_IOMEM dependency for FB_OPENCORES To: Thomas Huth , Farhan Ali , , , CC: , , References: <033e4a497792b2fa484c1288b9ed05c068565088.1516892845.git.alifm@linux.vnet.ibm.com> <036978d8-0628-9841-4bc1-b09c5231b577@redhat.com> From: Tomi Valkeinen Message-ID: <1fae3814-705e-a221-5e58-cef8da3a2f7d@ti.com> Date: Fri, 26 Jan 2018 14:38:29 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <036978d8-0628-9841-4bc1-b09c5231b577@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 26/01/18 14:33, Thomas Huth wrote: > On 25.01.2018 16:47, Farhan Ali wrote: >> The Opencores framebuffer device uses I/O memory and with >> CONFIG_HAS_IOMEM disabled will lead to build errors: >> >> ERROR: "devm_ioremap_resource" [drivers/video/fbdev/ocfb.ko] undefined! >> >> Fix this by adding HAS_IOMEM dependency for FB_OPENCORES. >> >> Signed-off-by: Farhan Ali >> --- >> drivers/video/fbdev/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig >> index 5e58f5e..8667e5d 100644 >> --- a/drivers/video/fbdev/Kconfig >> +++ b/drivers/video/fbdev/Kconfig >> @@ -976,7 +976,7 @@ config FB_PVR2 >> >> config FB_OPENCORES >> tristate "OpenCores VGA/LCD core 2.0 framebuffer support" >> - depends on FB && HAS_DMA >> + depends on FB && HAS_DMA && HAS_IOMEM >> select FB_CFB_FILLRECT >> select FB_CFB_COPYAREA >> select FB_CFB_IMAGEBLIT > > I think it would be better if fbdevs in general would depend on > HAS_IOMEM ... or could there be any frame buffer devices without IOMEM ? There are some small ones which are updated with, say, i2c (ssd1307fb.c). I think those don't need iomem. Tomi -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki